Re: Review Request 63281: Clean up TaskList component layout.

2017-10-25 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63281/#review189268
---


Ship it!




Master (5201cf1) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 25, 2017, 8:08 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63281/
> ---
> 
> (Updated Oct. 25, 2017, 8:08 p.m.)
> 
> 
> Review request for Aurora, Kai Huang and Reza Motamedi.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Clean up TaskList component layout by separating out some of the components 
> (to help with extensibility).
> 
> 
> Diffs
> -
> 
>   ui/src/main/js/components/TaskList.js 
> e1685ce1b81b8b1f26056a71f68a32bf7c38bb5a 
>   ui/src/main/js/components/TaskListItem.js PRE-CREATION 
>   ui/src/main/js/components/TaskListItemActions.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/TaskList-test.js 
> c222b61de65c6333e9689123302206802871eb90 
>   ui/src/main/js/components/__tests__/TaskListItem-test.js PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63281/diff/2/
> 
> 
> Testing
> ---
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 63281: Clean up TaskList component layout.

2017-10-25 Thread David McLaughlin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63281/
---

(Updated Oct. 25, 2017, 8:08 p.m.)


Review request for Aurora, Kai Huang and Reza Motamedi.


Changes
---

Rebase.


Repository: aurora


Description
---

Clean up TaskList component layout by separating out some of the components (to 
help with extensibility).


Diffs (updated)
-

  ui/src/main/js/components/TaskList.js 
e1685ce1b81b8b1f26056a71f68a32bf7c38bb5a 
  ui/src/main/js/components/TaskListItem.js PRE-CREATION 
  ui/src/main/js/components/TaskListItemActions.js PRE-CREATION 
  ui/src/main/js/components/__tests__/TaskList-test.js 
c222b61de65c6333e9689123302206802871eb90 
  ui/src/main/js/components/__tests__/TaskListItem-test.js PRE-CREATION 


Diff: https://reviews.apache.org/r/63281/diff/2/

Changes: https://reviews.apache.org/r/63281/diff/1-2/


Testing
---

./gradlew ui:test
./gradlew ui:lint


Thanks,

David McLaughlin

Re: Review Request 63281: Clean up TaskList component layout.

2017-10-25 Thread Reza Motamedi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63281/#review189228
---


Ship it!




Ship It!

- Reza Motamedi


On Oct. 24, 2017, 11:32 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63281/
> ---
> 
> (Updated Oct. 24, 2017, 11:32 p.m.)
> 
> 
> Review request for Aurora, Kai Huang and Reza Motamedi.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Clean up TaskList component layout by separating out some of the components 
> (to help with extensibility).
> 
> 
> Diffs
> -
> 
>   ui/src/main/js/components/TaskList.js 
> 4a4b8d365737b002acbe47c2d9b0253c5ce4f2ed 
>   ui/src/main/js/components/TaskListItem.js PRE-CREATION 
>   ui/src/main/js/components/TaskListItemActions.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/TaskList-test.js 
> c222b61de65c6333e9689123302206802871eb90 
>   ui/src/main/js/components/__tests__/TaskListItem-test.js PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63281/diff/1/
> 
> 
> Testing
> ---
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 63281: Clean up TaskList component layout.

2017-10-25 Thread Kai Huang 


> On Oct. 25, 2017, 5:10 p.m., Kai Huang wrote:
> > ui/src/main/js/components/TaskListItemActions.js
> > Lines 3 (patched)
> > 
> >
> > s/TaskListItemActioins/TaskListItemHost/ ?
> 
> David McLaughlin wrote:
> The idea is that we might add more actions in the future.

Ah, that will make sense.


- Kai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63281/#review189207
---


On Oct. 24, 2017, 11:32 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63281/
> ---
> 
> (Updated Oct. 24, 2017, 11:32 p.m.)
> 
> 
> Review request for Aurora, Kai Huang and Reza Motamedi.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Clean up TaskList component layout by separating out some of the components 
> (to help with extensibility).
> 
> 
> Diffs
> -
> 
>   ui/src/main/js/components/TaskList.js 
> 4a4b8d365737b002acbe47c2d9b0253c5ce4f2ed 
>   ui/src/main/js/components/TaskListItem.js PRE-CREATION 
>   ui/src/main/js/components/TaskListItemActions.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/TaskList-test.js 
> c222b61de65c6333e9689123302206802871eb90 
>   ui/src/main/js/components/__tests__/TaskListItem-test.js PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63281/diff/1/
> 
> 
> Testing
> ---
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 63281: Clean up TaskList component layout.

2017-10-25 Thread David McLaughlin 


> On Oct. 25, 2017, 5:10 p.m., Kai Huang wrote:
> > ui/src/main/js/components/TaskListItemActions.js
> > Lines 3 (patched)
> > 
> >
> > s/TaskListItemActioins/TaskListItemHost/ ?

The idea is that we might add more actions in the future.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63281/#review189207
---


On Oct. 24, 2017, 11:32 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63281/
> ---
> 
> (Updated Oct. 24, 2017, 11:32 p.m.)
> 
> 
> Review request for Aurora, Kai Huang and Reza Motamedi.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Clean up TaskList component layout by separating out some of the components 
> (to help with extensibility).
> 
> 
> Diffs
> -
> 
>   ui/src/main/js/components/TaskList.js 
> 4a4b8d365737b002acbe47c2d9b0253c5ce4f2ed 
>   ui/src/main/js/components/TaskListItem.js PRE-CREATION 
>   ui/src/main/js/components/TaskListItemActions.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/TaskList-test.js 
> c222b61de65c6333e9689123302206802871eb90 
>   ui/src/main/js/components/__tests__/TaskListItem-test.js PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63281/diff/1/
> 
> 
> Testing
> ---
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 63281: Clean up TaskList component layout.

2017-10-25 Thread Kai Huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63281/#review189207
---


Ship it!




LGTM


ui/src/main/js/components/TaskListItemActions.js
Lines 3 (patched)


s/TaskListItemActioins/TaskListItemHost/ ?


- Kai Huang


On Oct. 24, 2017, 11:32 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63281/
> ---
> 
> (Updated Oct. 24, 2017, 11:32 p.m.)
> 
> 
> Review request for Aurora, Kai Huang and Reza Motamedi.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Clean up TaskList component layout by separating out some of the components 
> (to help with extensibility).
> 
> 
> Diffs
> -
> 
>   ui/src/main/js/components/TaskList.js 
> 4a4b8d365737b002acbe47c2d9b0253c5ce4f2ed 
>   ui/src/main/js/components/TaskListItem.js PRE-CREATION 
>   ui/src/main/js/components/TaskListItemActions.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/TaskList-test.js 
> c222b61de65c6333e9689123302206802871eb90 
>   ui/src/main/js/components/__tests__/TaskListItem-test.js PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63281/diff/1/
> 
> 
> Testing
> ---
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 63281: Clean up TaskList component layout.

2017-10-24 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63281/#review189118
---


Ship it!




Master (38476ab) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 24, 2017, 11:32 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63281/
> ---
> 
> (Updated Oct. 24, 2017, 11:32 p.m.)
> 
> 
> Review request for Aurora, Kai Huang and Reza Motamedi.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Clean up TaskList component layout by separating out some of the components 
> (to help with extensibility).
> 
> 
> Diffs
> -
> 
>   ui/src/main/js/components/TaskList.js 
> 4a4b8d365737b002acbe47c2d9b0253c5ce4f2ed 
>   ui/src/main/js/components/TaskListItem.js PRE-CREATION 
>   ui/src/main/js/components/TaskListItemActions.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/TaskList-test.js 
> c222b61de65c6333e9689123302206802871eb90 
>   ui/src/main/js/components/__tests__/TaskListItem-test.js PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63281/diff/1/
> 
> 
> Testing
> ---
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>