Re: Review Request 63383: Suppress multiline logging from mesos callbacks

2017-10-28 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63383/#review189508
---



This has been submitted already 
https://github.com/apache/aurora/commit/fb64e3a9ffac224fc008298a30b6f1213edce525

Closing

- Stephan Erb


On Oct. 28, 2017, 1:46 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63383/
> ---
> 
> (Updated Oct. 28, 2017, 1:46 a.m.)
> 
> 
> Review request for Aurora and Jordan Ly.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Log messages like this:
> ```console
> W1026 02:55:19.450 [Thread-4822, 
> MesosCallbackHandler$MesosCallbackHandlerImpl] Lost executor value: 
> "thermos-foo-prod-bar-2-40501be8-11fd-417a-8ad3-326c014e8466"
>  on slave value: "efe603c2-8b52-4cc1-b9f4-43a4eb06d29b-S1521"
>  with status 9
> ```
> become:
> ```console
> W1026 02:55:19.450 [Thread-4822, 
> MesosCallbackHandler$MesosCallbackHandlerImpl] Lost executor: 
> "thermos-foo-prod-bar-2-40501be8-11fd-417a-8ad3-326c014e8466" on slave: 
> "efe603c2-8b52-4cc1-b9f4-43a4eb06d29b-S1521" with status 9
> ```
> 
> And messages like this:
> ```console
> I1026 00:00:23.271 [Thread-1152062, 
> MesosCallbackHandler$MesosCallbackHandlerImpl] Received status update for 
> task foo-prod-bar-25-6ac5d5e9-2563-4cd0-a4a8-eb19a990bad4 in state 
> TASK_FAILED from SOURCE_AGENT with REASON_CONTAINER_LIMITATION_MEMORY: Memory 
> limit exceeded: Requested: 14464MB Maximum Used: 14464MB
> 
> MEMORY STATISTICS:
> cache 0
> rss 15166603264
> rss_huge 0
> mapped_file 0
> writeback 0
> pgpgin 6430645
> pgpgout 2727861
> pgfault 6441533
> pgmajfault 4
> inactive_anon 0
> active_anon 15166365696
> inactive_file 0
> active_file 0
> unevictable 0
> hierarchical_memory_limit 15166603264
> total_cache 0
> total_rss 15166603264
> total_rss_huge 0
> total_mapped_file 0
> total_writeback 0
> total_pgpgin 6430645
> total_pgpgout 2727861
> total_pgfault 6441533
> total_pgmajfault 4
> total_inactive_anon 0
> total_active_anon 15166365696
> total_inactive_file 0
> total_active_file 0
> total_unevictable 0
> 
> 
> ```
> 
> become:
> ```console
> I1027 18:48:40.793 [Thread-754, 
> MesosCallbackHandler$MesosCallbackHandlerImpl] Received status update for 
> task foo-prod-bar-11-c39221c6-fd87-40cf-a5a8-555f7bea33f8 in state 
> TASK_FAILED from SOURCE_AGENT with REASON_CONTAINER_LIMITATION_MEMORY: Memory 
> limit exceeded: Requested: 14464MB Maximum Used: 14464MB (truncated)
> ```
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java 
> e93c4fa15a7cc1b025dcb0f29319bc774c62e2c9 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java 
> 51d0371007564bc0af32e256dbae8b57113536c2 
> 
> 
> Diff: https://reviews.apache.org/r/63383/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 63383: Suppress multiline logging from mesos callbacks

2017-10-27 Thread Joshua Cohen 


> On Oct. 28, 2017, 12:08 a.m., Jordan Ly wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java
> > Lines 303-305 (patched)
> > 
> >
> > Does Mesos send any other important information on new lines? I am 
> > mostly worried about losing potentially valuable debugging info.
> 
> Bill Farner wrote:
> Not to my knowledge; historically the message (multi-line or not) has 
> been of little value even for debugging.

Is the info that we're truncating here also available in the Mesos logs 
somewhere?


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63383/#review189497
---


On Oct. 27, 2017, 11:46 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63383/
> ---
> 
> (Updated Oct. 27, 2017, 11:46 p.m.)
> 
> 
> Review request for Aurora and Jordan Ly.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Log messages like this:
> ```console
> W1026 02:55:19.450 [Thread-4822, 
> MesosCallbackHandler$MesosCallbackHandlerImpl] Lost executor value: 
> "thermos-foo-prod-bar-2-40501be8-11fd-417a-8ad3-326c014e8466"
>  on slave value: "efe603c2-8b52-4cc1-b9f4-43a4eb06d29b-S1521"
>  with status 9
> ```
> become:
> ```console
> W1026 02:55:19.450 [Thread-4822, 
> MesosCallbackHandler$MesosCallbackHandlerImpl] Lost executor: 
> "thermos-foo-prod-bar-2-40501be8-11fd-417a-8ad3-326c014e8466" on slave: 
> "efe603c2-8b52-4cc1-b9f4-43a4eb06d29b-S1521" with status 9
> ```
> 
> And messages like this:
> ```console
> I1026 00:00:23.271 [Thread-1152062, 
> MesosCallbackHandler$MesosCallbackHandlerImpl] Received status update for 
> task foo-prod-bar-25-6ac5d5e9-2563-4cd0-a4a8-eb19a990bad4 in state 
> TASK_FAILED from SOURCE_AGENT with REASON_CONTAINER_LIMITATION_MEMORY: Memory 
> limit exceeded: Requested: 14464MB Maximum Used: 14464MB
> 
> MEMORY STATISTICS:
> cache 0
> rss 15166603264
> rss_huge 0
> mapped_file 0
> writeback 0
> pgpgin 6430645
> pgpgout 2727861
> pgfault 6441533
> pgmajfault 4
> inactive_anon 0
> active_anon 15166365696
> inactive_file 0
> active_file 0
> unevictable 0
> hierarchical_memory_limit 15166603264
> total_cache 0
> total_rss 15166603264
> total_rss_huge 0
> total_mapped_file 0
> total_writeback 0
> total_pgpgin 6430645
> total_pgpgout 2727861
> total_pgfault 6441533
> total_pgmajfault 4
> total_inactive_anon 0
> total_active_anon 15166365696
> total_inactive_file 0
> total_active_file 0
> total_unevictable 0
> 
> 
> ```
> 
> become:
> ```console
> I1027 18:48:40.793 [Thread-754, 
> MesosCallbackHandler$MesosCallbackHandlerImpl] Received status update for 
> task foo-prod-bar-11-c39221c6-fd87-40cf-a5a8-555f7bea33f8 in state 
> TASK_FAILED from SOURCE_AGENT with REASON_CONTAINER_LIMITATION_MEMORY: Memory 
> limit exceeded: Requested: 14464MB Maximum Used: 14464MB (truncated)
> ```
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java 
> e93c4fa15a7cc1b025dcb0f29319bc774c62e2c9 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java 
> 51d0371007564bc0af32e256dbae8b57113536c2 
> 
> 
> Diff: https://reviews.apache.org/r/63383/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 63383: Suppress multiline logging from mesos callbacks

2017-10-27 Thread Bill Farner 


> On Oct. 27, 2017, 5:08 p.m., Jordan Ly wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java
> > Lines 303-305 (patched)
> > 
> >
> > Does Mesos send any other important information on new lines? I am 
> > mostly worried about losing potentially valuable debugging info.

Not to my knowledge; historically the message (multi-line or not) has been of 
little value even for debugging.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63383/#review189497
---


On Oct. 27, 2017, 4:46 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63383/
> ---
> 
> (Updated Oct. 27, 2017, 4:46 p.m.)
> 
> 
> Review request for Aurora and Jordan Ly.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Log messages like this:
> ```console
> W1026 02:55:19.450 [Thread-4822, 
> MesosCallbackHandler$MesosCallbackHandlerImpl] Lost executor value: 
> "thermos-foo-prod-bar-2-40501be8-11fd-417a-8ad3-326c014e8466"
>  on slave value: "efe603c2-8b52-4cc1-b9f4-43a4eb06d29b-S1521"
>  with status 9
> ```
> become:
> ```console
> W1026 02:55:19.450 [Thread-4822, 
> MesosCallbackHandler$MesosCallbackHandlerImpl] Lost executor: 
> "thermos-foo-prod-bar-2-40501be8-11fd-417a-8ad3-326c014e8466" on slave: 
> "efe603c2-8b52-4cc1-b9f4-43a4eb06d29b-S1521" with status 9
> ```
> 
> And messages like this:
> ```console
> I1026 00:00:23.271 [Thread-1152062, 
> MesosCallbackHandler$MesosCallbackHandlerImpl] Received status update for 
> task foo-prod-bar-25-6ac5d5e9-2563-4cd0-a4a8-eb19a990bad4 in state 
> TASK_FAILED from SOURCE_AGENT with REASON_CONTAINER_LIMITATION_MEMORY: Memory 
> limit exceeded: Requested: 14464MB Maximum Used: 14464MB
> 
> MEMORY STATISTICS:
> cache 0
> rss 15166603264
> rss_huge 0
> mapped_file 0
> writeback 0
> pgpgin 6430645
> pgpgout 2727861
> pgfault 6441533
> pgmajfault 4
> inactive_anon 0
> active_anon 15166365696
> inactive_file 0
> active_file 0
> unevictable 0
> hierarchical_memory_limit 15166603264
> total_cache 0
> total_rss 15166603264
> total_rss_huge 0
> total_mapped_file 0
> total_writeback 0
> total_pgpgin 6430645
> total_pgpgout 2727861
> total_pgfault 6441533
> total_pgmajfault 4
> total_inactive_anon 0
> total_active_anon 15166365696
> total_inactive_file 0
> total_active_file 0
> total_unevictable 0
> 
> 
> ```
> 
> become:
> ```console
> I1027 18:48:40.793 [Thread-754, 
> MesosCallbackHandler$MesosCallbackHandlerImpl] Received status update for 
> task foo-prod-bar-11-c39221c6-fd87-40cf-a5a8-555f7bea33f8 in state 
> TASK_FAILED from SOURCE_AGENT with REASON_CONTAINER_LIMITATION_MEMORY: Memory 
> limit exceeded: Requested: 14464MB Maximum Used: 14464MB (truncated)
> ```
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java 
> e93c4fa15a7cc1b025dcb0f29319bc774c62e2c9 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java 
> 51d0371007564bc0af32e256dbae8b57113536c2 
> 
> 
> Diff: https://reviews.apache.org/r/63383/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 63383: Suppress multiline logging from mesos callbacks

2017-10-27 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63383/#review189498
---


Ship it!




Master (f6c40a2) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 27, 2017, 11:46 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63383/
> ---
> 
> (Updated Oct. 27, 2017, 11:46 p.m.)
> 
> 
> Review request for Aurora and Jordan Ly.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Log messages like this:
> ```console
> W1026 02:55:19.450 [Thread-4822, 
> MesosCallbackHandler$MesosCallbackHandlerImpl] Lost executor value: 
> "thermos-foo-prod-bar-2-40501be8-11fd-417a-8ad3-326c014e8466"
>  on slave value: "efe603c2-8b52-4cc1-b9f4-43a4eb06d29b-S1521"
>  with status 9
> ```
> become:
> ```console
> W1026 02:55:19.450 [Thread-4822, 
> MesosCallbackHandler$MesosCallbackHandlerImpl] Lost executor: 
> "thermos-foo-prod-bar-2-40501be8-11fd-417a-8ad3-326c014e8466" on slave: 
> "efe603c2-8b52-4cc1-b9f4-43a4eb06d29b-S1521" with status 9
> ```
> 
> And messages like this:
> ```console
> I1026 00:00:23.271 [Thread-1152062, 
> MesosCallbackHandler$MesosCallbackHandlerImpl] Received status update for 
> task foo-prod-bar-25-6ac5d5e9-2563-4cd0-a4a8-eb19a990bad4 in state 
> TASK_FAILED from SOURCE_AGENT with REASON_CONTAINER_LIMITATION_MEMORY: Memory 
> limit exceeded: Requested: 14464MB Maximum Used: 14464MB
> 
> MEMORY STATISTICS:
> cache 0
> rss 15166603264
> rss_huge 0
> mapped_file 0
> writeback 0
> pgpgin 6430645
> pgpgout 2727861
> pgfault 6441533
> pgmajfault 4
> inactive_anon 0
> active_anon 15166365696
> inactive_file 0
> active_file 0
> unevictable 0
> hierarchical_memory_limit 15166603264
> total_cache 0
> total_rss 15166603264
> total_rss_huge 0
> total_mapped_file 0
> total_writeback 0
> total_pgpgin 6430645
> total_pgpgout 2727861
> total_pgfault 6441533
> total_pgmajfault 4
> total_inactive_anon 0
> total_active_anon 15166365696
> total_inactive_file 0
> total_active_file 0
> total_unevictable 0
> 
> 
> ```
> 
> become:
> ```console
> I1027 18:48:40.793 [Thread-754, 
> MesosCallbackHandler$MesosCallbackHandlerImpl] Received status update for 
> task foo-prod-bar-11-c39221c6-fd87-40cf-a5a8-555f7bea33f8 in state 
> TASK_FAILED from SOURCE_AGENT with REASON_CONTAINER_LIMITATION_MEMORY: Memory 
> limit exceeded: Requested: 14464MB Maximum Used: 14464MB (truncated)
> ```
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java 
> e93c4fa15a7cc1b025dcb0f29319bc774c62e2c9 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java 
> 51d0371007564bc0af32e256dbae8b57113536c2 
> 
> 
> Diff: https://reviews.apache.org/r/63383/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 63383: Suppress multiline logging from mesos callbacks

2017-10-27 Thread Jordan Ly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63383/#review189497
---


Fix it, then Ship it!




One small question, but overall LGTM.


src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java
Lines 303-305 (patched)


Does Mesos send any other important information on new lines? I am mostly 
worried about losing potentially valuable debugging info.


- Jordan Ly


On Oct. 27, 2017, 11:46 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63383/
> ---
> 
> (Updated Oct. 27, 2017, 11:46 p.m.)
> 
> 
> Review request for Aurora and Jordan Ly.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Log messages like this:
> ```console
> W1026 02:55:19.450 [Thread-4822, 
> MesosCallbackHandler$MesosCallbackHandlerImpl] Lost executor value: 
> "thermos-foo-prod-bar-2-40501be8-11fd-417a-8ad3-326c014e8466"
>  on slave value: "efe603c2-8b52-4cc1-b9f4-43a4eb06d29b-S1521"
>  with status 9
> ```
> become:
> ```console
> W1026 02:55:19.450 [Thread-4822, 
> MesosCallbackHandler$MesosCallbackHandlerImpl] Lost executor: 
> "thermos-foo-prod-bar-2-40501be8-11fd-417a-8ad3-326c014e8466" on slave: 
> "efe603c2-8b52-4cc1-b9f4-43a4eb06d29b-S1521" with status 9
> ```
> 
> And messages like this:
> ```console
> I1026 00:00:23.271 [Thread-1152062, 
> MesosCallbackHandler$MesosCallbackHandlerImpl] Received status update for 
> task foo-prod-bar-25-6ac5d5e9-2563-4cd0-a4a8-eb19a990bad4 in state 
> TASK_FAILED from SOURCE_AGENT with REASON_CONTAINER_LIMITATION_MEMORY: Memory 
> limit exceeded: Requested: 14464MB Maximum Used: 14464MB
> 
> MEMORY STATISTICS:
> cache 0
> rss 15166603264
> rss_huge 0
> mapped_file 0
> writeback 0
> pgpgin 6430645
> pgpgout 2727861
> pgfault 6441533
> pgmajfault 4
> inactive_anon 0
> active_anon 15166365696
> inactive_file 0
> active_file 0
> unevictable 0
> hierarchical_memory_limit 15166603264
> total_cache 0
> total_rss 15166603264
> total_rss_huge 0
> total_mapped_file 0
> total_writeback 0
> total_pgpgin 6430645
> total_pgpgout 2727861
> total_pgfault 6441533
> total_pgmajfault 4
> total_inactive_anon 0
> total_active_anon 15166365696
> total_inactive_file 0
> total_active_file 0
> total_unevictable 0
> 
> 
> ```
> 
> become:
> ```console
> I1027 18:48:40.793 [Thread-754, 
> MesosCallbackHandler$MesosCallbackHandlerImpl] Received status update for 
> task foo-prod-bar-11-c39221c6-fd87-40cf-a5a8-555f7bea33f8 in state 
> TASK_FAILED from SOURCE_AGENT with REASON_CONTAINER_LIMITATION_MEMORY: Memory 
> limit exceeded: Requested: 14464MB Maximum Used: 14464MB (truncated)
> ```
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java 
> e93c4fa15a7cc1b025dcb0f29319bc774c62e2c9 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java 
> 51d0371007564bc0af32e256dbae8b57113536c2 
> 
> 
> Diff: https://reviews.apache.org/r/63383/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>