Re: Review Request 65233: Allow for injection of custom OfferSets, removed OfferOrder and OfferSelector

> On Jan. 19, 2018, 8:27 p.m., Stephan Erb wrote: > > The patch itself looks fine! However, I have difficulties assesing it > > properly as I am missing a bit of context. What is the main customization > > that you aim to implement using the new interface? > > > > I am also curious what is

Re: Review Request 65233: Allow for injection of custom OfferSets, removed OfferOrder and OfferSelector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65233/#review195870 --- Ship it! Master (c4c55ff) is green with this patch.

Re: Review Request 65233: Allow for injection of custom OfferSets, removed OfferOrder and OfferSelector

> On Jan. 20, 2018, 2:16 a.m., Bill Farner wrote: > > docs/reference/scheduler-configuration.md > > Lines 179 (patched) > > > > > > Odd to see `OfferSetImpl` here. Should be a module, right? Yep! Good catch,

Re: Review Request 65233: Allow for injection of custom OfferSets, removed OfferOrder and OfferSelector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65233/#review195867 --- Ship it! docs/reference/scheduler-configuration.md Lines 179

Re: Review Request 65233: Allow for injection of custom OfferSets, removed OfferOrder and OfferSelector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65233/#review195866 --- Ship it! Master (c4c55ff) is green with this patch.

Re: Review Request 65233: Allow for injection of custom OfferSets, removed OfferOrder and OfferSelector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65233/ --- (Updated Jan. 20, 2018, 1:31 a.m.) Review request for Aurora, David

Re: Review Request 65233: Allow for injection of custom OfferSets, removed OfferOrder and OfferSelector

> On Jan. 19, 2018, 7:27 p.m., Stephan Erb wrote: > > The patch itself looks fine! However, I have difficulties assesing it > > properly as I am missing a bit of context. What is the main customization > > that you aim to implement using the new interface? > > > > I am also curious what is

Re: Review Request 65233: Allow for injection of custom OfferSets, removed OfferOrder and OfferSelector

> On Jan. 19, 2018, 8:27 p.m., Stephan Erb wrote: > > The patch itself looks fine! However, I have difficulties assesing it > > properly as I am missing a bit of context. What is the main customization > > that you aim to implement using the new interface? > > > > I am also curious what is

Re: Review Request 65233: Allow for injection of custom OfferSets, removed OfferOrder and OfferSelector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65233/#review195845 --- Ship it! LGTM. RELEASE-NOTES.md Lines 15-17 (original),

Re: Review Request 65233: Allow for injection of custom OfferSets, removed OfferOrder and OfferSelector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65233/#review195846 --- Ship it! Master (c4c55ff) is green with this patch.

Re: Review Request 65233: Allow for injection of custom OfferSets, removed OfferOrder and OfferSelector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65233/#review195840 --- Ship it! Master (c4c55ff) is green with this patch.