Re: Review Request 65769: Remove unused module in RecoveryTool, move TaskTestUtil to test folder
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65769/#review199394 --- Ship it! Ship It! - Stephan Erb On Feb. 23, 2018, 7:04 p.m., Jordan Ly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65769/ > --- > > (Updated Feb. 23, 2018, 7:04 p.m.) > > > Review request for Aurora, David McLaughlin, Renan DelValle, and Bill Farner. > > > Repository: aurora > > > Description > --- > > Removing an unused `TierModule` from `RecoveryTool`. > > Additionally, resolved an old TODO and moved `TaskTestUtil` to the test > folder. It seems that the old version of JMH could not see test sources but > https://github.com/melix/jmh-gradle-plugin/issues/31 and the upgrade to 0.4.4 > seems to fix that. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java > 2b61c273860a33472890fc22e06b3c53d2086999 > > src/main/java/org/apache/aurora/scheduler/storage/durability/RecoveryTool.java > 7cb4c52bc6e890f48a8bc9fe21c54cea38644808 > > > Diff: https://reviews.apache.org/r/65769/diff/1/ > > > Testing > --- > > `./gradlew test` > `./gradlew jmh` > > end-to-end tests pass. > > > Thanks, > > Jordan Ly > >
Re: Review Request 65769: Remove unused module in RecoveryTool, move TaskTestUtil to test folder
> On March 16, 2018, 7:02 p.m., Stephan Erb wrote: > > Is this RecoveryTool just a prototype or used for real? If it is the > > preferred backup way now, we have to update > > https://github.com/apache/aurora/blob/master/docs/operations/backup-restore.md. > > Jordan Ly wrote: > I would call it a prototype for now. It has been tested in ad-hoc > environments but not at scale or production yet. I've been meaning to > properly vet it but I have not gotten a chance yet. Ok, thanks for the clarification. - Stephan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65769/#review199333 --- On Feb. 23, 2018, 7:04 p.m., Jordan Ly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65769/ > --- > > (Updated Feb. 23, 2018, 7:04 p.m.) > > > Review request for Aurora, David McLaughlin, Renan DelValle, and Bill Farner. > > > Repository: aurora > > > Description > --- > > Removing an unused `TierModule` from `RecoveryTool`. > > Additionally, resolved an old TODO and moved `TaskTestUtil` to the test > folder. It seems that the old version of JMH could not see test sources but > https://github.com/melix/jmh-gradle-plugin/issues/31 and the upgrade to 0.4.4 > seems to fix that. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java > 2b61c273860a33472890fc22e06b3c53d2086999 > > src/main/java/org/apache/aurora/scheduler/storage/durability/RecoveryTool.java > 7cb4c52bc6e890f48a8bc9fe21c54cea38644808 > > > Diff: https://reviews.apache.org/r/65769/diff/1/ > > > Testing > --- > > `./gradlew test` > `./gradlew jmh` > > end-to-end tests pass. > > > Thanks, > > Jordan Ly > >
Re: Review Request 65769: Remove unused module in RecoveryTool, move TaskTestUtil to test folder
> On March 16, 2018, 6:02 p.m., Stephan Erb wrote: > > Is this RecoveryTool just a prototype or used for real? If it is the > > preferred backup way now, we have to update > > https://github.com/apache/aurora/blob/master/docs/operations/backup-restore.md. I would call it a prototype for now. It has been tested in ad-hoc environments but not at scale or production yet. I've been meaning to properly vet it but I have not gotten a chance yet. - Jordan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65769/#review199333 --- On Feb. 23, 2018, 6:04 p.m., Jordan Ly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65769/ > --- > > (Updated Feb. 23, 2018, 6:04 p.m.) > > > Review request for Aurora, David McLaughlin, Renan DelValle, and Bill Farner. > > > Repository: aurora > > > Description > --- > > Removing an unused `TierModule` from `RecoveryTool`. > > Additionally, resolved an old TODO and moved `TaskTestUtil` to the test > folder. It seems that the old version of JMH could not see test sources but > https://github.com/melix/jmh-gradle-plugin/issues/31 and the upgrade to 0.4.4 > seems to fix that. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java > 2b61c273860a33472890fc22e06b3c53d2086999 > > src/main/java/org/apache/aurora/scheduler/storage/durability/RecoveryTool.java > 7cb4c52bc6e890f48a8bc9fe21c54cea38644808 > > > Diff: https://reviews.apache.org/r/65769/diff/1/ > > > Testing > --- > > `./gradlew test` > `./gradlew jmh` > > end-to-end tests pass. > > > Thanks, > > Jordan Ly > >
Re: Review Request 65769: Remove unused module in RecoveryTool, move TaskTestUtil to test folder
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65769/#review199333 --- Is this RecoveryTool just a prototype or used for real? If it is the preferred backup way now, we have to update https://github.com/apache/aurora/blob/master/docs/operations/backup-restore.md. - Stephan Erb On Feb. 23, 2018, 7:04 p.m., Jordan Ly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65769/ > --- > > (Updated Feb. 23, 2018, 7:04 p.m.) > > > Review request for Aurora, David McLaughlin, Renan DelValle, and Bill Farner. > > > Repository: aurora > > > Description > --- > > Removing an unused `TierModule` from `RecoveryTool`. > > Additionally, resolved an old TODO and moved `TaskTestUtil` to the test > folder. It seems that the old version of JMH could not see test sources but > https://github.com/melix/jmh-gradle-plugin/issues/31 and the upgrade to 0.4.4 > seems to fix that. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java > 2b61c273860a33472890fc22e06b3c53d2086999 > > src/main/java/org/apache/aurora/scheduler/storage/durability/RecoveryTool.java > 7cb4c52bc6e890f48a8bc9fe21c54cea38644808 > > > Diff: https://reviews.apache.org/r/65769/diff/1/ > > > Testing > --- > > `./gradlew test` > `./gradlew jmh` > > end-to-end tests pass. > > > Thanks, > > Jordan Ly > >
Re: Review Request 65769: Remove unused module in RecoveryTool, move TaskTestUtil to test folder
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65769/#review199222 --- Ship it! Ship It! - Renan DelValle On Feb. 23, 2018, 10:04 a.m., Jordan Ly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65769/ > --- > > (Updated Feb. 23, 2018, 10:04 a.m.) > > > Review request for Aurora, David McLaughlin, Renan DelValle, and Bill Farner. > > > Repository: aurora > > > Description > --- > > Removing an unused `TierModule` from `RecoveryTool`. > > Additionally, resolved an old TODO and moved `TaskTestUtil` to the test > folder. It seems that the old version of JMH could not see test sources but > https://github.com/melix/jmh-gradle-plugin/issues/31 and the upgrade to 0.4.4 > seems to fix that. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java > 2b61c273860a33472890fc22e06b3c53d2086999 > > src/main/java/org/apache/aurora/scheduler/storage/durability/RecoveryTool.java > 7cb4c52bc6e890f48a8bc9fe21c54cea38644808 > > > Diff: https://reviews.apache.org/r/65769/diff/1/ > > > Testing > --- > > `./gradlew test` > `./gradlew jmh` > > end-to-end tests pass. > > > Thanks, > > Jordan Ly > >
Re: Review Request 65769: Remove unused module in RecoveryTool, move TaskTestUtil to test folder
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65769/#review199219 --- bump - Jordan Ly On Feb. 23, 2018, 6:04 p.m., Jordan Ly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65769/ > --- > > (Updated Feb. 23, 2018, 6:04 p.m.) > > > Review request for Aurora, David McLaughlin, Renan DelValle, and Bill Farner. > > > Repository: aurora > > > Description > --- > > Removing an unused `TierModule` from `RecoveryTool`. > > Additionally, resolved an old TODO and moved `TaskTestUtil` to the test > folder. It seems that the old version of JMH could not see test sources but > https://github.com/melix/jmh-gradle-plugin/issues/31 and the upgrade to 0.4.4 > seems to fix that. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java > 2b61c273860a33472890fc22e06b3c53d2086999 > > src/main/java/org/apache/aurora/scheduler/storage/durability/RecoveryTool.java > 7cb4c52bc6e890f48a8bc9fe21c54cea38644808 > > > Diff: https://reviews.apache.org/r/65769/diff/1/ > > > Testing > --- > > `./gradlew test` > `./gradlew jmh` > > end-to-end tests pass. > > > Thanks, > > Jordan Ly > >
