Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67141/#review203529 --- Ship it! Master (83025f4) is green with this patch. ./build-s

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67141/#review203528 --- Ship it! Ship It! - Stephan Erb On May 17, 2018, 4:07 a.m.,

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67141/#review203525 --- @ReviewBot retry - Jordan Ly On May 17, 2018, 2:07 a.m., Santho

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67141/#review203355 --- Ship it! Ship It! - Renan DelValle On May 16, 2018, 7:07 p.m

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67141/#review203308 --- Master (805a53f) is red with this patch. ./build-support/jenkins

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67141/ --- (Updated May 16, 2018, 7:07 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67141/#review203301 --- Master (805a53f) is red with this patch. ./build-support/jenkins

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67141/ --- (Updated May 16, 2018, 4:44 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

> On May 16, 2018, 1:22 p.m., Stephan Erb wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > > Lines 263 (patched) > > > > > > Just by looking at this it is not clear what `statusKey` means. Maybe > >

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

> On May 16, 2018, 10:02 a.m., Jordan Ly wrote: > > src/main/java/org/apache/aurora/scheduler/storage/durability/WriteRecorder.java > > Lines 257-258 (patched) > > > > > > For additional backwards compatability, we c

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

> On May 16, 2018, 10:22 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/storage/durability/WriteRecorder.java > > Lines 257-258 (patched) > > > > > > If we use a feature toggle here operators

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

> On May 16, 2018, 8:22 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/storage/durability/WriteRecorder.java > > Lines 257-258 (patched) > > > > > > If we use a feature toggle here operators c

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67141/#review203269 --- In general, this looks good to me. api/src/main/thrift/org/apach

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

> On May 16, 2018, 5:02 p.m., Jordan Ly wrote: > > Mostly LGTM. > > > > This patch only allows for a better rollback story if you are developing > > from HEAD? You might have to cut a release after this patch so there is > > -1/+1 version compatability otherwise you may need to note this in th

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67141/#review203251 --- Master (805a53f) is red with this patch. ./build-support/jenkins

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

> On May 16, 2018, 5:02 p.m., Jordan Ly wrote: > > Mostly LGTM. > > > > This patch only allows for a better rollback story if you are developing > > from HEAD? You might have to cut a release after this patch so there is > > -1/+1 version compatability otherwise you may need to note this in th

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67141/#review203243 --- Fix it, then Ship it! Mostly LGTM. This patch only allows for

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67141/#review203242 --- @ReviewBot retry - Jordan Ly On May 15, 2018, 9:15 p.m., Santho

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67141/#review203167 --- Master (805a53f) is red with this patch. ./build-support/jenkins

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67141/ --- (Updated May 15, 2018, 2:15 p.m.) Review request for Aurora, David McLaughlin,