Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-21 Thread Bill Farner
On April 17, 2015, 5:59 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java, lines 142-144 https://reviews.apache.org/r/32597/diff/5/?file=931268#file931268line142 ``` SetString allSlaves =

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597/#review81030 --- Ship it! LGTM overall, but i'd like to converge on the

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597/ --- (Updated April 21, 2015, 9:15 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-21 Thread Maxim Khutornenko
On April 17, 2015, 5:59 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java, lines 142-144 https://reviews.apache.org/r/32597/diff/5/?file=931268#file931268line142 ``` SetString allSlaves =

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597/#review81085 --- Ship it! Master (d10d2d1) is green with this patch.

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-20 Thread Maxim Khutornenko
On April 16, 2015, 11:08 p.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java, line 183 https://reviews.apache.org/r/32597/diff/5/?file=931268#file931268line183 Don't we want `pendingGroups.remove(group)`? This will only

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-20 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597/ --- (Updated April 21, 2015, 1:12 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-20 Thread Maxim Khutornenko
On April 17, 2015, 5:59 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java, lines 142-144 https://reviews.apache.org/r/32597/diff/5/?file=931268#file931268line142 ``` SetString allSlaves =

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597/#review80873 --- Ship it! Master (4b90339) is green with this patch.

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597/#review80480 ---

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-16 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597/#review80396 --- Ship it!

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597/ --- (Updated April 15, 2015, 7:05 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-15 Thread Maxim Khutornenko
On April 15, 2015, 7:58 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java, line 140 https://reviews.apache.org/r/32597/diff/4/?file=930944#file930944line140 How about ``` ImmutableSet.copyOf(Sets.union(

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597/#review80292 --- Ship it! Master (b18dc44) is green with this patch.

Re: Review Request 32597: Improving async preemptor efficiency.

2015-03-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597/#review78150 --- This patch does not apply cleanly on master (3ab8a9e), do you need