On April 17, 2015, 5:59 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java,
lines 142-144
https://reviews.apache.org/r/32597/diff/5/?file=931268#file931268line142
```
SetString allSlaves =
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32597/#review81030
---
Ship it!
LGTM overall, but i'd like to converge on the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32597/
---
(Updated April 21, 2015, 9:15 p.m.)
Review request for Aurora, Bill Farner and
On April 17, 2015, 5:59 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java,
lines 142-144
https://reviews.apache.org/r/32597/diff/5/?file=931268#file931268line142
```
SetString allSlaves =
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32597/#review81085
---
Ship it!
Master (d10d2d1) is green with this patch.
On April 16, 2015, 11:08 p.m., Zameer Manji wrote:
src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java,
line 183
https://reviews.apache.org/r/32597/diff/5/?file=931268#file931268line183
Don't we want `pendingGroups.remove(group)`?
This will only
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32597/
---
(Updated April 21, 2015, 1:12 a.m.)
Review request for Aurora, Bill Farner and
On April 17, 2015, 5:59 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java,
lines 142-144
https://reviews.apache.org/r/32597/diff/5/?file=931268#file931268line142
```
SetString allSlaves =
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32597/#review80873
---
Ship it!
Master (4b90339) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32597/#review80480
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32597/#review80396
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32597/
---
(Updated April 15, 2015, 7:05 p.m.)
Review request for Aurora, Bill Farner and
On April 15, 2015, 7:58 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java,
line 140
https://reviews.apache.org/r/32597/diff/4/?file=930944#file930944line140
How about
```
ImmutableSet.copyOf(Sets.union(
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32597/#review80292
---
Ship it!
Master (b18dc44) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32597/#review78150
---
This patch does not apply cleanly on master (3ab8a9e), do you need
15 matches
Mail list logo