Re: Review Request 33202: Fixing benchmarks.

[Bill Farner]

> On April 15, 2015, 3:07 a.m., Bill Farner wrote:
> > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java, line 135
> > 
> >
> > IMHO the empty string is a wart, and emphasizes my point about letting 
> > the consumer decide if they want stats.  I won't harp on it, but i think 
> > this has made the code less reusable.
> 
> Maxim Khutornenko wrote:
> This is hardly a good example though as we always want stats in 
> production. I will be happy to reconsider should we have a real counter case. 
> So far, every time we deal with caches we always want more visibility.

This probably makes a good case for a decorating implementation of an 
interface.  No urgency, of course...but something to keep in mind as things 
evolve.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33202/#review80148
---


On April 15, 2015, 12:32 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33202/
> ---
> 
> (Updated April 15, 2015, 12:32 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Benchmark module configuration got broken by recent refactoring.
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 011350540d4f5091ff5f8a3c646f40f3f63357fd 
> 
> Diff: https://reviews.apache.org/r/33202/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew jmh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 33202: Fixing benchmarks.

[Maxim Khutornenko]

> On April 15, 2015, 3:07 a.m., Bill Farner wrote:
> > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java, line 135
> > 
> >
> > IMHO the empty string is a wart, and emphasizes my point about letting 
> > the consumer decide if they want stats.  I won't harp on it, but i think 
> > this has made the code less reusable.

This is hardly a good example though as we always want stats in production. I 
will be happy to reconsider should we have a real counter case. So far, every 
time we deal with caches we always want more visibility.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33202/#review80148
---


On April 15, 2015, 12:32 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33202/
> ---
> 
> (Updated April 15, 2015, 12:32 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Benchmark module configuration got broken by recent refactoring.
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 011350540d4f5091ff5f8a3c646f40f3f63357fd 
> 
> Diff: https://reviews.apache.org/r/33202/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew jmh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 33202: Fixing benchmarks.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33202/#review80148
---

Ship it!


Thanks!


src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java


IMHO the empty string is a wart, and emphasizes my point about letting the 
consumer decide if they want stats.  I won't harp on it, but i think this has 
made the code less reusable.


- Bill Farner


On April 15, 2015, 12:32 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33202/
> ---
> 
> (Updated April 15, 2015, 12:32 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Benchmark module configuration got broken by recent refactoring.
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 011350540d4f5091ff5f8a3c646f40f3f63357fd 
> 
> Diff: https://reviews.apache.org/r/33202/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew jmh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 33202: Fixing benchmarks.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33202/#review80142
---

Ship it!


Master (51b29c5) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On April 15, 2015, 12:32 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33202/
> ---
> 
> (Updated April 15, 2015, 12:32 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Benchmark module configuration got broken by recent refactoring.
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 011350540d4f5091ff5f8a3c646f40f3f63357fd 
> 
> Diff: https://reviews.apache.org/r/33202/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew jmh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 33202: Fixing benchmarks.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33202/
---

Review request for Aurora and Bill Farner.


Repository: aurora


Description
---

Benchmark module configuration got broken by recent refactoring.


Diffs
-

  src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
011350540d4f5091ff5f8a3c646f40f3f63357fd 

Diff: https://reviews.apache.org/r/33202/diff/


Testing
---

./gradlew jmh


Thanks,

Maxim Khutornenko