Re: Review Request 33366: download url for stdout/stderr broken
On April 20, 2015, 6:14 p.m., Aurora ReviewBot wrote: Master (b18dc44) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing @ReviewBot retry Bhuvan Arumugam wrote: @ReviewBot retry Unfortunately the bot will not read comments on a reply, only the text in a separate review. However, a retry won't help in this case since the bot has rightly flagged that the patch changes src/main but not src/test. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/#review80771 --- On April 20, 2015, 5:57 p.m., Bhuvan Arumugam wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/ --- (Updated April 20, 2015, 5:57 p.m.) Review request for Aurora. Bugs: AURORA-1135 https://issues.apache.org/jira/browse/AURORA-1135 Repository: aurora Description --- Fix the path to download stdout/stderr. Make it relative to sandbox. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1135 Diffs - src/main/python/apache/thermos/observer/http/file_browser.py 2f48594a87724b84bad7e149eb4d63c71ea954ee Diff: https://reviews.apache.org/r/33366/diff/ Testing --- Thanks, Bhuvan Arumugam
Re: Review Request 33366: download url for stdout/stderr broken
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/#review80771 --- Master (b18dc44) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On April 20, 2015, 5:57 p.m., Bhuvan Arumugam wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/ --- (Updated April 20, 2015, 5:57 p.m.) Review request for Aurora. Bugs: AURORA-1135 https://issues.apache.org/jira/browse/AURORA-1135 Repository: aurora Description --- Fix the path to download stdout/stderr. Make it relative to sandbox. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1135 Diffs - src/main/python/apache/thermos/observer/http/file_browser.py 2f48594a87724b84bad7e149eb4d63c71ea954ee Diff: https://reviews.apache.org/r/33366/diff/ Testing --- Thanks, Bhuvan Arumugam
Re: Review Request 33366: download url for stdout/stderr broken
On April 20, 2015, 6:14 p.m., Aurora ReviewBot wrote: Master (b18dc44) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing @ReviewBot retry @ReviewBot retry - Bhuvan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/#review80771 --- On April 20, 2015, 5:57 p.m., Bhuvan Arumugam wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/ --- (Updated April 20, 2015, 5:57 p.m.) Review request for Aurora. Bugs: AURORA-1135 https://issues.apache.org/jira/browse/AURORA-1135 Repository: aurora Description --- Fix the path to download stdout/stderr. Make it relative to sandbox. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1135 Diffs - src/main/python/apache/thermos/observer/http/file_browser.py 2f48594a87724b84bad7e149eb4d63c71ea954ee Diff: https://reviews.apache.org/r/33366/diff/ Testing --- Thanks, Bhuvan Arumugam
Re: Review Request 33366: download url for stdout/stderr broken
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/#review80772 --- Thanks for the fix! A few requests: - Please add test coverage, even if rudimentary. - Please lift the first line of your description to the Summary, Fix the path to download stdout/stderr. The summary becomes the first line of the commit message, so it's ideal for it to explain the fix rather than state the problem. - Bill Farner On April 20, 2015, 5:57 p.m., Bhuvan Arumugam wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/ --- (Updated April 20, 2015, 5:57 p.m.) Review request for Aurora. Bugs: AURORA-1135 https://issues.apache.org/jira/browse/AURORA-1135 Repository: aurora Description --- Fix the path to download stdout/stderr. Make it relative to sandbox. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1135 Diffs - src/main/python/apache/thermos/observer/http/file_browser.py 2f48594a87724b84bad7e149eb4d63c71ea954ee Diff: https://reviews.apache.org/r/33366/diff/ Testing --- Thanks, Bhuvan Arumugam
Review Request 33366: download url for stdout/stderr broken
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/ --- Review request for Aurora. Bugs: AURORA-1135 https://issues.apache.org/jira/browse/AURORA-1135 Repository: aurora Description --- Fix the path to download stdout/stderr. Make it relative to sandbox. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1135 Diffs - src/main/python/apache/thermos/observer/http/file_browser.py 2f48594a87724b84bad7e149eb4d63c71ea954ee Diff: https://reviews.apache.org/r/33366/diff/ Testing --- Thanks, Bhuvan Arumugam
Re: Review Request 33366: download url for stdout/stderr broken
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/#review80777 --- @wfarner, thank you for the review comment. I did ReviewBot retry before I saw your 1st comment. I will revise the patch with unittests. - Bhuvan Arumugam On April 20, 2015, 5:57 p.m., Bhuvan Arumugam wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/ --- (Updated April 20, 2015, 5:57 p.m.) Review request for Aurora. Bugs: AURORA-1135 https://issues.apache.org/jira/browse/AURORA-1135 Repository: aurora Description --- Fix the path to download stdout/stderr. Make it relative to sandbox. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1135 Diffs - src/main/python/apache/thermos/observer/http/file_browser.py 2f48594a87724b84bad7e149eb4d63c71ea954ee Diff: https://reviews.apache.org/r/33366/diff/ Testing --- Thanks, Bhuvan Arumugam
