Re: Review Request 33456: Adding logging threadpool executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33456/#review81725 --- src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java https://reviews.apache.org/r/33456/#comment132156 Have you considered creating factory methods that apply decorators to ExecutorServices? That would potentially save this code from the combinatoric explosion we seem to be heading towards. ForwardingExecutorService [1] could be helpful to minimize the code to implement decorators. [1] http://docs.guava-libraries.googlecode.com/git-history/release/javadoc/com/google/common/util/concurrent/ForwardingExecutorService.html - Bill Farner On April 22, 2015, 10:58 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33456/ --- (Updated April 22, 2015, 10:58 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- Our async EventBus is using a regular executor thus potentially hiding unhandled errors. Diffs - src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java f657e057b5bbff69971876e104ff0e47b2dc4faa src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 3a4d40adc1abe170b5b80644db9f079751d8a9bf src/test/java/org/apache/aurora/scheduler/base/AsyncUtilTest.java e990f528aac768b5c9b829c9544045a831e094fe Diff: https://reviews.apache.org/r/33456/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 33456: Adding logging threadpool executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33456/#review81240 --- Ship it! Master (352e0ef) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On April 22, 2015, 10:58 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33456/ --- (Updated April 22, 2015, 10:58 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- Our async EventBus is using a regular executor thus potentially hiding unhandled errors. Diffs - src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java f657e057b5bbff69971876e104ff0e47b2dc4faa src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 3a4d40adc1abe170b5b80644db9f079751d8a9bf src/test/java/org/apache/aurora/scheduler/base/AsyncUtilTest.java e990f528aac768b5c9b829c9544045a831e094fe Diff: https://reviews.apache.org/r/33456/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Review Request 33456: Adding logging threadpool executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33456/ --- Review request for Aurora and Bill Farner. Repository: aurora Description --- Our async EventBus is using a regular executor thus potentially hiding unhandled errors. Diffs - src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java f657e057b5bbff69971876e104ff0e47b2dc4faa src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 3a4d40adc1abe170b5b80644db9f079751d8a9bf src/test/java/org/apache/aurora/scheduler/base/AsyncUtilTest.java e990f528aac768b5c9b829c9544045a831e094fe Diff: https://reviews.apache.org/r/33456/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
