Re: Review Request 33530: Simplify storage bindings, remove shims that are now mostly getting in the way.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33530/#review81536 --- Ship it! Master (7f3e4e3) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On April 24, 2015, 7:07 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33530/ > --- > > (Updated April 24, 2015, 7:07 p.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Repository: aurora > > > Description > --- > > This is mostly lifting DbStorage to prominence, removing the now-thin > MemStorage. > > > Diffs > - > > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java > 12f42a92a28c68fcc55bf2f0b130ffed8c4d4879 > src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java > d20b088f57624142d1adfac58ac54a33e4ae6403 > src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java > c7456aa2c565900e090bc6003b55be34e6d51dd1 > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > 087abe5cafded6f184fa1219d93c5aa7a4dc778f > > src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java > 586b53b0bdecbd7f1087268bcbc9a04bebf076a2 > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java > 439d8cc6d9eca673e907824d3d6412b08791069a > src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java > 49db52df2d24ae25dd3993038cd99a653ee66e8f > src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java > a821de35c859b11f9bb3d02ed02c21a7537d3626 > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java > bb59cdf2e20e10ba4b0235f53637116fa58567f9 > src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java > c5db52b2b5f419ba16388b2ed18e4a415087 > src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java > 9068aa4457c10ef790205d43df9540c4b07e2759 > src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java > 4a8d404cc0106d10feb469c3ba36b8e36dd20279 > src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java > bd1aaa1bc04f41804a8d4941f3fdd305ccb98bc4 > src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java > 9035484bef39e2deff2526bbdfbd2af503898720 > > src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java > 91cf5ed67bf0bc229a3122331ae3cd6045fd3b85 > src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java > d4f8b5b60860c2e9244d72fc6e8361c330594efe > > src/test/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImplTest.java > d313326e63fec30a58c593b34774b2aa33af4e6d > src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java > 2f14205331b67b0f7bfd1b1b15fc0f945b046323 > src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java > c7fd3e5e370a0100fa48460668c522a9a454d2ad > src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java > 82e9c76762c370cbf4a46cae6ca9ea61bea90f03 > src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java > 254b23116b78aefed694768d5b3c98077dfaf069 > src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java > 743f5ba92d28ddc22e82c9b4896ae5c3d8e288bb > src/test/java/org/apache/aurora/scheduler/storage/db/DbUtil.java > 1eaf3fe77c1d130ead77a171e0c7950fb646c264 > src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java > 30e2328912a512cbf98fcc2f307ebcefcc9d8734 > src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java > 20c92044774d953aa5f1556a0053240b348e8f16 > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java > 802c0901dc88fd587fde539682287f7dd527d661 > > Diff: https://reviews.apache.org/r/33530/diff/ > > > Testing > --- > > > Thanks, > > Bill Farner > >
Re: Review Request 33530: Simplify storage bindings, remove shims that are now mostly getting in the way.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33530/#review81533 --- Ship it! Ship It! - Maxim Khutornenko On April 24, 2015, 7:07 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33530/ > --- > > (Updated April 24, 2015, 7:07 p.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Repository: aurora > > > Description > --- > > This is mostly lifting DbStorage to prominence, removing the now-thin > MemStorage. > > > Diffs > - > > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java > 12f42a92a28c68fcc55bf2f0b130ffed8c4d4879 > src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java > d20b088f57624142d1adfac58ac54a33e4ae6403 > src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java > c7456aa2c565900e090bc6003b55be34e6d51dd1 > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > 087abe5cafded6f184fa1219d93c5aa7a4dc778f > > src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java > 586b53b0bdecbd7f1087268bcbc9a04bebf076a2 > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java > 439d8cc6d9eca673e907824d3d6412b08791069a > src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java > 49db52df2d24ae25dd3993038cd99a653ee66e8f > src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java > a821de35c859b11f9bb3d02ed02c21a7537d3626 > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java > bb59cdf2e20e10ba4b0235f53637116fa58567f9 > src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java > c5db52b2b5f419ba16388b2ed18e4a415087 > src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java > 9068aa4457c10ef790205d43df9540c4b07e2759 > src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java > 4a8d404cc0106d10feb469c3ba36b8e36dd20279 > src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java > bd1aaa1bc04f41804a8d4941f3fdd305ccb98bc4 > src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java > 9035484bef39e2deff2526bbdfbd2af503898720 > > src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java > 91cf5ed67bf0bc229a3122331ae3cd6045fd3b85 > src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java > d4f8b5b60860c2e9244d72fc6e8361c330594efe > > src/test/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImplTest.java > d313326e63fec30a58c593b34774b2aa33af4e6d > src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java > 2f14205331b67b0f7bfd1b1b15fc0f945b046323 > src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java > c7fd3e5e370a0100fa48460668c522a9a454d2ad > src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java > 82e9c76762c370cbf4a46cae6ca9ea61bea90f03 > src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java > 254b23116b78aefed694768d5b3c98077dfaf069 > src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java > 743f5ba92d28ddc22e82c9b4896ae5c3d8e288bb > src/test/java/org/apache/aurora/scheduler/storage/db/DbUtil.java > 1eaf3fe77c1d130ead77a171e0c7950fb646c264 > src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java > 30e2328912a512cbf98fcc2f307ebcefcc9d8734 > src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java > 20c92044774d953aa5f1556a0053240b348e8f16 > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java > 802c0901dc88fd587fde539682287f7dd527d661 > > Diff: https://reviews.apache.org/r/33530/diff/ > > > Testing > --- > > > Thanks, > > Bill Farner > >
Review Request 33530: Simplify storage bindings, remove shims that are now mostly getting in the way.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33530/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora Description --- This is mostly lifting DbStorage to prominence, removing the now-thin MemStorage. Diffs - src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 12f42a92a28c68fcc55bf2f0b130ffed8c4d4879 src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java d20b088f57624142d1adfac58ac54a33e4ae6403 src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java c7456aa2c565900e090bc6003b55be34e6d51dd1 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 087abe5cafded6f184fa1219d93c5aa7a4dc778f src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java 586b53b0bdecbd7f1087268bcbc9a04bebf076a2 src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 439d8cc6d9eca673e907824d3d6412b08791069a src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 49db52df2d24ae25dd3993038cd99a653ee66e8f src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java a821de35c859b11f9bb3d02ed02c21a7537d3626 src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java bb59cdf2e20e10ba4b0235f53637116fa58567f9 src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java c5db52b2b5f419ba16388b2ed18e4a415087 src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 9068aa4457c10ef790205d43df9540c4b07e2759 src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 4a8d404cc0106d10feb469c3ba36b8e36dd20279 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java bd1aaa1bc04f41804a8d4941f3fdd305ccb98bc4 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 9035484bef39e2deff2526bbdfbd2af503898720 src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java 91cf5ed67bf0bc229a3122331ae3cd6045fd3b85 src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java d4f8b5b60860c2e9244d72fc6e8361c330594efe src/test/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImplTest.java d313326e63fec30a58c593b34774b2aa33af4e6d src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 2f14205331b67b0f7bfd1b1b15fc0f945b046323 src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java c7fd3e5e370a0100fa48460668c522a9a454d2ad src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java 82e9c76762c370cbf4a46cae6ca9ea61bea90f03 src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 254b23116b78aefed694768d5b3c98077dfaf069 src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java 743f5ba92d28ddc22e82c9b4896ae5c3d8e288bb src/test/java/org/apache/aurora/scheduler/storage/db/DbUtil.java 1eaf3fe77c1d130ead77a171e0c7950fb646c264 src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java 30e2328912a512cbf98fcc2f307ebcefcc9d8734 src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 20c92044774d953aa5f1556a0053240b348e8f16 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 802c0901dc88fd587fde539682287f7dd527d661 Diff: https://reviews.apache.org/r/33530/diff/ Testing --- Thanks, Bill Farner
