Re: Review Request 33608: Added a status update throughput benchmark.

2015-05-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/#review82598 --- Master (d3b6e13) is green with this patch.

Re: Review Request 33608: Added a status update throughput benchmark.

2015-04-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/#review82163 ---

Re: Review Request 33608: Added a status update throughput benchmark.

2015-04-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/#review82048 ---

Re: Review Request 33608: Added a status update throughput benchmark.

2015-04-29 Thread Ben Mahler
On April 29, 2015, 10:31 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverModule.java, line 45 https://reviews.apache.org/r/33608/diff/3/?file=945461#file945461line45 If anything, you should expose Scheduler.class to hide the

Re: Review Request 33608: Added a status update throughput benchmark.

2015-04-29 Thread Ben Mahler
On April 29, 2015, 10:38 p.m., Bill Farner wrote: src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java, line 179 https://reviews.apache.org/r/33608/diff/3/?file=945456#file945456line179 This requires libmesos.so to be available, which i don't think we should do.

Re: Review Request 33608: Added a status update throughput benchmark.

2015-04-29 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/ --- (Updated April 30, 2015, 12:35 a.m.) Review request for Aurora and Maxim

Re: Review Request 33608: Added a status update throughput benchmark.

2015-04-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/#review82077 --- Master (f77daf7) is green with this patch.

Re: Review Request 33608: Added a status update throughput benchmark.

2015-04-28 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/ --- (Updated April 29, 2015, 12:48 a.m.) Review request for Aurora and Maxim

Re: Review Request 33608: Added a status update throughput benchmark.

2015-04-28 Thread Ben Mahler
On April 28, 2015, 1:30 a.m., Kevin Sweeney wrote: src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java, lines 105-110 https://reviews.apache.org/r/33608/diff/1/?file=943452#file943452line105 You probably want

Re: Review Request 33608: Added a status update throughput benchmark.

2015-04-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/#review81765 --- Master (e9d723d) is red with this patch.

Review Request 33608: Added a status update throughput benchmark.

2015-04-27 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1283