Re: Review Request 34300: Do better sanitation on the client side when encountering unbound pystachio refs

2015-06-22 Thread Kevin Sweeney
On June 4, 2015, 4:55 p.m., Kevin Sweeney wrote: src/main/python/apache/aurora/config/thrift.py, line 218 https://reviews.apache.org/r/34300/diff/3/?file=975774#file975774line218 Why set this at all? Does the scheduler read this field? Brian Wickman wrote: it is not. i will

Re: Review Request 34300: Do better sanitation on the client side when encountering unbound pystachio refs

2015-06-04 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34300/#review86742 --- Ship it! src/main/python/apache/aurora/config/thrift.py

Re: Review Request 34300: Do better sanitation on the client side when encountering unbound pystachio refs

2015-06-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34300/#review86028 --- Ship it! Master (827b9ab) is green with this patch.

Re: Review Request 34300: Do better sanitation on the client side when encountering unbound pystachio refs

2015-06-01 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34300/ --- (Updated June 1, 2015, 6:05 p.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 34300: Do better sanitation on the client side when encountering unbound pystachio refs

2015-05-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34300/#review85258 --- Master (6db13ba) is red with this patch.

Re: Review Request 34300: Do better sanitation on the client side when encountering unbound pystachio refs

2015-05-26 Thread Brian Wickman
On May 16, 2015, 1:17 a.m., Kevin Sweeney wrote: src/main/python/apache/aurora/config/schema/base.py, line 98 https://reviews.apache.org/r/34300/diff/1/?file=961840#file961840line98 Would be nice to have a wrapper here like Deprecated(Map(String, String)) You filed

Re: Review Request 34300: Do better sanitation on the client side when encountering unbound pystachio refs

2015-05-26 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34300/ --- (Updated May 26, 2015, 9:03 p.m.) Review request for Aurora and Kevin Sweeney.

Review Request 34300: Do better sanitation on the client side when encountering unbound pystachio refs

2015-05-15 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34300/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description