Re: Review Request 34373: Exposing task reconciliation stats.

2015-05-19 Thread Maxim Khutornenko
> On May 19, 2015, 9:46 p.m., Ben Mahler wrote: > > src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java, lines > > 214-217 > > > > > > Any reason not to pass the '`reason`' directly, rather than passing th

Re: Review Request 34373: Exposing task reconciliation stats.

2015-05-19 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34373/#review84394 --- Looks good to me. :) src/main/java/org/apache/aurora/scheduler/Use

Re: Review Request 34373: Exposing task reconciliation stats.

2015-05-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34373/#review84236 --- Ship it! Master (920263b) is green with this patch. ./build-suppo

Re: Review Request 34373: Exposing task reconciliation stats.

2015-05-18 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34373/#review84231 --- Ship it! Ship It! - Zameer Manji On May 18, 2015, 3:42 p.m., Max

Re: Review Request 34373: Exposing task reconciliation stats.

2015-05-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34373/ --- (Updated May 18, 2015, 10:42 p.m.) Review request for Aurora, Ben Mahler and Za

Re: Review Request 34373: Exposing task reconciliation stats.

2015-05-18 Thread Maxim Khutornenko
> On May 18, 2015, 10:05 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java, line 204 > > > > > > Special-casing the reconsiliation reason and not the others smells like > >

Re: Review Request 34373: Exposing task reconciliation stats.

2015-05-18 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34373/#review84226 --- src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java

Re: Review Request 34373: Exposing task reconciliation stats.

2015-05-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34373/#review84224 --- Ship it! Master (920263b) is green with this patch. ./build-suppo

Review Request 34373: Exposing task reconciliation stats.

2015-05-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34373/ --- Review request for Aurora, Ben Mahler and Zameer Manji. Bugs: AURORA-1047 h