Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-02-02 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review117480
---


Ship it!




Master (3fc9dc2) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 2, 2016, 8:50 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35990/
> ---
> 
> (Updated Feb. 2, 2016, 8:50 p.m.)
> 
> 
> Review request for Aurora, Bill Farner, Zhitao Li, and Zameer Manji.
> 
> 
> Bugs: AURORA-1052
> https://issues.apache.org/jira/browse/AURORA-1052
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Map Aurora task metadata to Mesos task labels
> 
> 
> Diffs
> -
> 
>   NEWS a6c2a906ee8e018cca756c1af0d20f221120d42f 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> fcad0e735b676e8da9b2b1d4d0d5e734a717b2d8 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> cc2a4155008672056410086b05b6cc875485f669 
> 
> Diff: https://reviews.apache.org/r/35990/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-02-02 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/
---

(Updated Feb. 2, 2016, 9:50 p.m.)


Review request for Aurora, Bill Farner, Zhitao Li, and Zameer Manji.


Changes
---

Rebase


Bugs: AURORA-1052
https://issues.apache.org/jira/browse/AURORA-1052


Repository: aurora


Description
---

Map Aurora task metadata to Mesos task labels


Diffs (updated)
-

  NEWS a6c2a906ee8e018cca756c1af0d20f221120d42f 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
fcad0e735b676e8da9b2b1d4d0d5e734a717b2d8 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
cc2a4155008672056410086b05b6cc875485f669 

Diff: https://reviews.apache.org/r/35990/diff/


Testing
---

./gradlew -Pq build


Thanks,

Stephan Erb

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-02-01 Thread Stephan Erb 


> On Feb. 1, 2016, 11:04 nachm., Bill Farner wrote:
> > My apologies for the delay, there is now a merge conflict in `NEWS`.  Can 
> > you address?

Yeah, I can rebase but will take me another 24h


- Stephan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review117281
---


On Jan. 27, 2016, 11:52 nachm., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35990/
> ---
> 
> (Updated Jan. 27, 2016, 11:52 nachm.)
> 
> 
> Review request for Aurora, Bill Farner, Zhitao Li, and Zameer Manji.
> 
> 
> Bugs: AURORA-1052
> https://issues.apache.org/jira/browse/AURORA-1052
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Map Aurora task metadata to Mesos task labels
> 
> 
> Diffs
> -
> 
>   NEWS 29702d581bced316b313c5caa350de975a8bf428 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> fcad0e735b676e8da9b2b1d4d0d5e734a717b2d8 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> cc2a4155008672056410086b05b6cc875485f669 
> 
> Diff: https://reviews.apache.org/r/35990/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-02-01 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review117281
---



My apologies for the delay, there is now a merge conflict in `NEWS`.  Can you 
address?

- Bill Farner


On Jan. 27, 2016, 2:52 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35990/
> ---
> 
> (Updated Jan. 27, 2016, 2:52 p.m.)
> 
> 
> Review request for Aurora, Bill Farner, Zhitao Li, and Zameer Manji.
> 
> 
> Bugs: AURORA-1052
> https://issues.apache.org/jira/browse/AURORA-1052
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Map Aurora task metadata to Mesos task labels
> 
> 
> Diffs
> -
> 
>   NEWS 29702d581bced316b313c5caa350de975a8bf428 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> fcad0e735b676e8da9b2b1d4d0d5e734a717b2d8 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> cc2a4155008672056410086b05b6cc875485f669 
> 
> Diff: https://reviews.apache.org/r/35990/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-02-01 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review117280
---


Ship it!




Ship It!

- Bill Farner


On Jan. 27, 2016, 2:52 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35990/
> ---
> 
> (Updated Jan. 27, 2016, 2:52 p.m.)
> 
> 
> Review request for Aurora, Bill Farner, Zhitao Li, and Zameer Manji.
> 
> 
> Bugs: AURORA-1052
> https://issues.apache.org/jira/browse/AURORA-1052
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Map Aurora task metadata to Mesos task labels
> 
> 
> Diffs
> -
> 
>   NEWS 29702d581bced316b313c5caa350de975a8bf428 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> fcad0e735b676e8da9b2b1d4d0d5e734a717b2d8 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> cc2a4155008672056410086b05b6cc875485f669 
> 
> Diff: https://reviews.apache.org/r/35990/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-01-27 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review116650
---


Ship it!




Master (e240fdc) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 27, 2016, 10:52 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35990/
> ---
> 
> (Updated Jan. 27, 2016, 10:52 p.m.)
> 
> 
> Review request for Aurora, Bill Farner, Zhitao Li, and Zameer Manji.
> 
> 
> Bugs: AURORA-1052
> https://issues.apache.org/jira/browse/AURORA-1052
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Map Aurora task metadata to Mesos task labels
> 
> 
> Diffs
> -
> 
>   NEWS 29702d581bced316b313c5caa350de975a8bf428 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> fcad0e735b676e8da9b2b1d4d0d5e734a717b2d8 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> cc2a4155008672056410086b05b6cc875485f669 
> 
> Diff: https://reviews.apache.org/r/35990/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-01-27 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review116647
---


Ship it!




Ship It!

- Zhitao Li


On Jan. 27, 2016, 10:52 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35990/
> ---
> 
> (Updated Jan. 27, 2016, 10:52 p.m.)
> 
> 
> Review request for Aurora, Bill Farner, Zhitao Li, and Zameer Manji.
> 
> 
> Bugs: AURORA-1052
> https://issues.apache.org/jira/browse/AURORA-1052
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Map Aurora task metadata to Mesos task labels
> 
> 
> Diffs
> -
> 
>   NEWS 29702d581bced316b313c5caa350de975a8bf428 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> fcad0e735b676e8da9b2b1d4d0d5e734a717b2d8 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> cc2a4155008672056410086b05b6cc875485f669 
> 
> Diff: https://reviews.apache.org/r/35990/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-01-27 Thread Stephan Erb 


> On Jan. 27, 2016, 11:31 p.m., Zhitao Li wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line 
> > 77
> > 
> >
> > Hmm, I think this is missing a trailing dot.

Uups, good catch.


- Stephan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review116639
---


On Jan. 27, 2016, 11:52 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35990/
> ---
> 
> (Updated Jan. 27, 2016, 11:52 p.m.)
> 
> 
> Review request for Aurora, Bill Farner, Zhitao Li, and Zameer Manji.
> 
> 
> Bugs: AURORA-1052
> https://issues.apache.org/jira/browse/AURORA-1052
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Map Aurora task metadata to Mesos task labels
> 
> 
> Diffs
> -
> 
>   NEWS 29702d581bced316b313c5caa350de975a8bf428 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> fcad0e735b676e8da9b2b1d4d0d5e734a717b2d8 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> cc2a4155008672056410086b05b6cc875485f669 
> 
> Diff: https://reviews.apache.org/r/35990/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-01-27 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/
---

(Updated Jan. 27, 2016, 11:52 p.m.)


Review request for Aurora, Bill Farner, Zhitao Li, and Zameer Manji.


Changes
---

Review changes.


Bugs: AURORA-1052
https://issues.apache.org/jira/browse/AURORA-1052


Repository: aurora


Description
---

Map Aurora task metadata to Mesos task labels


Diffs (updated)
-

  NEWS 29702d581bced316b313c5caa350de975a8bf428 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
fcad0e735b676e8da9b2b1d4d0d5e734a717b2d8 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
cc2a4155008672056410086b05b6cc875485f669 

Diff: https://reviews.apache.org/r/35990/diff/


Testing
---

./gradlew -Pq build


Thanks,

Stephan Erb

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-01-27 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review116643
---


Ship it!




Master (c417f9d) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 27, 2016, 10:17 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35990/
> ---
> 
> (Updated Jan. 27, 2016, 10:17 p.m.)
> 
> 
> Review request for Aurora, Bill Farner, Zhitao Li, and Zameer Manji.
> 
> 
> Bugs: AURORA-1052
> https://issues.apache.org/jira/browse/AURORA-1052
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Map Aurora task metadata to Mesos task labels
> 
> 
> Diffs
> -
> 
>   NEWS 29702d581bced316b313c5caa350de975a8bf428 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> fcad0e735b676e8da9b2b1d4d0d5e734a717b2d8 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> cc2a4155008672056410086b05b6cc875485f669 
> 
> Diff: https://reviews.apache.org/r/35990/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-01-27 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review116639
---




src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java (line 77)


Hmm, I think this is missing a trailing dot.


- Zhitao Li


On Jan. 27, 2016, 10:17 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35990/
> ---
> 
> (Updated Jan. 27, 2016, 10:17 p.m.)
> 
> 
> Review request for Aurora, Bill Farner, Zhitao Li, and Zameer Manji.
> 
> 
> Bugs: AURORA-1052
> https://issues.apache.org/jira/browse/AURORA-1052
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Map Aurora task metadata to Mesos task labels
> 
> 
> Diffs
> -
> 
>   NEWS 29702d581bced316b313c5caa350de975a8bf428 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> fcad0e735b676e8da9b2b1d4d0d5e734a717b2d8 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> cc2a4155008672056410086b05b6cc875485f669 
> 
> Diff: https://reviews.apache.org/r/35990/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-01-27 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review116637
---


Ship it!





NEWS (line 45)


Maybe mention the constant label prefix?


- Zhitao Li


On Jan. 27, 2016, 10:17 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35990/
> ---
> 
> (Updated Jan. 27, 2016, 10:17 p.m.)
> 
> 
> Review request for Aurora, Bill Farner, Zhitao Li, and Zameer Manji.
> 
> 
> Bugs: AURORA-1052
> https://issues.apache.org/jira/browse/AURORA-1052
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Map Aurora task metadata to Mesos task labels
> 
> 
> Diffs
> -
> 
>   NEWS 29702d581bced316b313c5caa350de975a8bf428 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> fcad0e735b676e8da9b2b1d4d0d5e734a717b2d8 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> cc2a4155008672056410086b05b6cc875485f669 
> 
> Diff: https://reviews.apache.org/r/35990/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-01-27 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/
---

(Updated Jan. 27, 2016, 11:17 p.m.)


Review request for Aurora, Bill Farner, Zhitao Li, and Zameer Manji.


Bugs: AURORA-1052
https://issues.apache.org/jira/browse/AURORA-1052


Repository: aurora


Description
---

Map Aurora task metadata to Mesos task labels


Diffs (updated)
-

  NEWS 29702d581bced316b313c5caa350de975a8bf428 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
fcad0e735b676e8da9b2b1d4d0d5e734a717b2d8 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
cc2a4155008672056410086b05b6cc875485f669 

Diff: https://reviews.apache.org/r/35990/diff/


Testing
---

./gradlew -Pq build


Thanks,

Stephan Erb

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-07-05 Thread Stephan Erb 


> On July 1, 2015, 1:59 p.m., Stephan Erb wrote:
> > For sake of transparency: Turns out not everyone thinks this is a great 
> > idea. For details, see: 
> > https://github.com/prometheus/mesos_exporter/issues/7
> 
> Bill Farner wrote:
> Would it be reasonable to impose namespacing of labels, and expect the 
> downstream consumer to use globbing if they want to consume data that spans 
> namespaces?

Yeah, I guess namespacing should solve the issue. Unless of course people start 
to use way to many labels, but I guess Mesos/Aurora will run into problems long 
before the monitoring solution does.


- Stephan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review90041
---


On June 30, 2015, 9:36 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35990/
> ---
> 
> (Updated June 30, 2015, 9:36 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1052
> https://issues.apache.org/jira/browse/AURORA-1052
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Map Aurora task metadata to Mesos task labels
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> e934f570e4a728470408970485abe0809487d312 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 
> 
> Diff: https://reviews.apache.org/r/35990/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-07-01 Thread Bill Farner 


> On July 1, 2015, 11:59 a.m., Stephan Erb wrote:
> > For sake of transparency: Turns out not everyone thinks this is a great 
> > idea. For details, see: 
> > https://github.com/prometheus/mesos_exporter/issues/7

Would it be reasonable to impose namespacing of labels, and expect the 
downstream consumer to use globbing if they want to consume data that spans 
namespaces?


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review90041
---


On June 30, 2015, 7:36 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35990/
> ---
> 
> (Updated June 30, 2015, 7:36 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1052
> https://issues.apache.org/jira/browse/AURORA-1052
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Map Aurora task metadata to Mesos task labels
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> e934f570e4a728470408970485abe0809487d312 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 
> 
> Diff: https://reviews.apache.org/r/35990/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-07-01 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review90041
---


For sake of transparency: Turns out not everyone thinks this is a great idea. 
For details, see: https://github.com/prometheus/mesos_exporter/issues/7

- Stephan Erb


On June 30, 2015, 9:36 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35990/
> ---
> 
> (Updated June 30, 2015, 9:36 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1052
> https://issues.apache.org/jira/browse/AURORA-1052
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Map Aurora task metadata to Mesos task labels
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> e934f570e4a728470408970485abe0809487d312 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 
> 
> Diff: https://reviews.apache.org/r/35990/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-06-30 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review89961
---

Ship it!


LGTM.

- Zameer Manji


On June 30, 2015, 12:36 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35990/
> ---
> 
> (Updated June 30, 2015, 12:36 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1052
> https://issues.apache.org/jira/browse/AURORA-1052
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Map Aurora task metadata to Mesos task labels
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> e934f570e4a728470408970485abe0809487d312 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 
> 
> Diff: https://reviews.apache.org/r/35990/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-06-30 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review89954
---

Ship it!


Master (616ef10) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 30, 2015, 7:36 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35990/
> ---
> 
> (Updated June 30, 2015, 7:36 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1052
> https://issues.apache.org/jira/browse/AURORA-1052
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Map Aurora task metadata to Mesos task labels
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> e934f570e4a728470408970485abe0809487d312 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 
> 
> Diff: https://reviews.apache.org/r/35990/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-06-30 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/
---

(Updated June 30, 2015, 9:36 p.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
---

Introduce prefix 'aurora_metadata_'.


Bugs: AURORA-1052
https://issues.apache.org/jira/browse/AURORA-1052


Repository: aurora


Description
---

Map Aurora task metadata to Mesos task labels


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
e934f570e4a728470408970485abe0809487d312 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 

Diff: https://reviews.apache.org/r/35990/diff/


Testing
---

./gradlew -Pq build


Thanks,

Stephan Erb

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-06-30 Thread Zameer Manji 


> On June 29, 2015, 8:55 a.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line 
> > 244
> > 
> >
> > I have been thinking about using mesos task labels to record the aurora 
> > job key. If we blindly copy the metadata over to the task labels, this 
> > might prevent us from doing that task in a backwards compatible manner.
> > 
> > Perhaps the label keys should be prefixed?
> 
> Stephan Erb wrote:
> Using the components of a jobkey as labels is an excellent idea.
> 
> Latest Mesos allows label injection using hooks at the master and slave 
> level. I guess we should opt for an aurora specific prefix. How about 
> `aurora_metadata_` as a prefix?

Prefixing the keys with 'aurora_metadata_' sounds good to me.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review89750
---


On June 30, 2015, 1:04 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35990/
> ---
> 
> (Updated June 30, 2015, 1:04 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1052
> https://issues.apache.org/jira/browse/AURORA-1052
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Map Aurora task metadata to Mesos task labels
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> e934f570e4a728470408970485abe0809487d312 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 
> 
> Diff: https://reviews.apache.org/r/35990/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-06-30 Thread Stephan Erb 


> On June 29, 2015, 5:55 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line 
> > 244
> > 
> >
> > I have been thinking about using mesos task labels to record the aurora 
> > job key. If we blindly copy the metadata over to the task labels, this 
> > might prevent us from doing that task in a backwards compatible manner.
> > 
> > Perhaps the label keys should be prefixed?

Using the components of a jobkey as labels is an excellent idea.

Latest Mesos allows label injection using hooks at the master and slave level. 
I guess we should opt for an aurora specific prefix. How about 
`aurora_metadata_` as a prefix?


- Stephan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review89750
---


On June 28, 2015, 10:44 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35990/
> ---
> 
> (Updated June 28, 2015, 10:44 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1052
> https://issues.apache.org/jira/browse/AURORA-1052
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Map Aurora task metadata to Mesos task labels
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> e934f570e4a728470408970485abe0809487d312 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 
> 
> Diff: https://reviews.apache.org/r/35990/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-06-29 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review89750
---



src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java (line 244)


I have been thinking about using mesos task labels to record the aurora job 
key. If we blindly copy the metadata over to the task labels, this might 
prevent us from doing that task in a backwards compatible manner.

Perhaps the label keys should be prefixed?


- Zameer Manji


On June 28, 2015, 1:44 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35990/
> ---
> 
> (Updated June 28, 2015, 1:44 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1052
> https://issues.apache.org/jira/browse/AURORA-1052
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Map Aurora task metadata to Mesos task labels
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> e934f570e4a728470408970485abe0809487d312 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 
> 
> Diff: https://reviews.apache.org/r/35990/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-06-28 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review89685
---

Ship it!


Master (2ef6a05) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 28, 2015, 8:44 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35990/
> ---
> 
> (Updated June 28, 2015, 8:44 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1052
> https://issues.apache.org/jira/browse/AURORA-1052
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Map Aurora task metadata to Mesos task labels
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> e934f570e4a728470408970485abe0809487d312 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 
> 
> Diff: https://reviews.apache.org/r/35990/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-06-28 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/
---

Review request for Aurora and Bill Farner.


Bugs: AURORA-1052
https://issues.apache.org/jira/browse/AURORA-1052


Repository: aurora


Description
---

Map Aurora task metadata to Mesos task labels


Diffs
-

  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
e934f570e4a728470408970485abe0809487d312 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 

Diff: https://reviews.apache.org/r/35990/diff/


Testing
---

./gradlew -Pq build


Thanks,

Stephan Erb