Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

2015-07-27 Thread Kevin Sweeney
On July 24, 2015, 10:57 a.m., Brian Wickman wrote: src/main/python/apache/thermos/observer/BUILD, line 74 https://reviews.apache.org/r/36700/diff/2/?file=1020365#file1020365line74 This puts an aurora dependency on thermos and I imagine causes a cycle in the build graph (pants may

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

2015-07-24 Thread Kevin Sweeney
Me too, but I'm okay with killing the sdist targets as an intermediate step and reintroducing them with a non-pants build On Friday, July 24, 2015, Brian Wickman wick...@apache.org wrote: On July 24, 2015, 5:57 p.m., Brian Wickman wrote: src/main/python/apache/thermos/observer/BUILD, line

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

2015-07-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36700/#review92944 --- src/main/python/apache/thermos/observer/BUILD (line 74)

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

2015-07-24 Thread Brian Wickman
On July 24, 2015, 5:57 p.m., Brian Wickman wrote: src/main/python/apache/thermos/observer/BUILD, line 74 https://reviews.apache.org/r/36700/diff/2/?file=1020365#file1020365line74 This puts an aurora dependency on thermos and I imagine causes a cycle in the build graph (pants may

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

2015-07-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36700/#review92845 --- Master (24088ef) is green with this patch.

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

2015-07-23 Thread Bill Farner
On July 22, 2015, 7:56 p.m., Kevin Sweeney wrote: build-support/packaging/debian/rules, line 37 https://reviews.apache.org/r/36700/diff/1/?file=1018921#file1018921line37 Can you delete the code these targets reference as well, as presumably there are now source files without

Review Request 36700: Remove binary build targets that are not currently for general consumption.

2015-07-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36700/ --- Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: AURORA-1381

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

2015-07-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36700/#review92633 --- Master (b64f7b6) is green with this patch.

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

2015-07-22 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36700/#review92639 --- build-support/packaging/debian/rules (line 37)