Re: Review Request 36703: Remove unnecessary uses of Guava Joiner.

2015-07-22 Thread Joshua Cohen
> On July 22, 2015, 7:36 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/app/VolumeParser.java, line 45 > > > > > > Yeah, big -1 to me on changes like this. The previous code was clear > > and

Re: Review Request 36703: Remove unnecessary uses of Guava Joiner.

2015-07-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36703/#review92637 --- Master (6e2bf57) is green with this patch. ./build-support/jenkins

Re: Review Request 36703: Remove unnecessary uses of Guava Joiner.

2015-07-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36703/#review92635 --- src/main/java/org/apache/aurora/scheduler/app/VolumeParser.java (li

Review Request 36703: Remove unnecessary uses of Guava Joiner.

2015-07-22 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36703/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora D