Re: Review Request 37206: Fixing slave/task reservation check.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37206/#review94560 --- Ship it! Ship It! - Zameer Manji On Aug. 6, 2015, 9:12 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37206/ > --- > > (Updated Aug. 6, 2015, 9:12 p.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Bugs: AURORA-1431 > https://issues.apache.org/jira/browse/AURORA-1431 > > > Repository: aurora > > > Description > --- > > Fixing this required exposing a map from BiCache. Reversed to the original > slave->task mapping as it makes easier to consume cache map. > > Also, added timed stats to ensure we cover all parts of the scheduling loop. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java > 54ffd8e3e76527e39c55ac735c3d1e71b317cbf4 > src/main/java/org/apache/aurora/scheduler/preemptor/BiCache.java > 2551057d718d306db698f4b87cfd93bee2753e51 > src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java > b9dccc6ba0dc6e62c8c874606622bba883d0736d > src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java > 0f0bfcab62a53869dc5190f063b2ef30da45ae55 > src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java > 0e32990e3c8776d505b58b3e0ff54fa190897ecc > src/test/java/org/apache/aurora/scheduler/preemptor/BiCacheTest.java > 731209196e3d1cc566b4ae460b9532dc350d0a21 > > src/test/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerImplTest.java > 350ec6f3c6aa0526b484758a64165392c87842c4 > src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java > c9c6f5d47300996abab3b0b9045022fe2dbb18ee > > Diff: https://reviews.apache.org/r/37206/diff/ > > > Testing > --- > > > Thanks, > > Maxim Khutornenko > >
Re: Review Request 37206: Fixing slave/task reservation check.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37206/#review94557 --- Ship it! Ship It! - Joshua Cohen On Aug. 7, 2015, 4:12 a.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37206/ > --- > > (Updated Aug. 7, 2015, 4:12 a.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Bugs: AURORA-1431 > https://issues.apache.org/jira/browse/AURORA-1431 > > > Repository: aurora > > > Description > --- > > Fixing this required exposing a map from BiCache. Reversed to the original > slave->task mapping as it makes easier to consume cache map. > > Also, added timed stats to ensure we cover all parts of the scheduling loop. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java > 54ffd8e3e76527e39c55ac735c3d1e71b317cbf4 > src/main/java/org/apache/aurora/scheduler/preemptor/BiCache.java > 2551057d718d306db698f4b87cfd93bee2753e51 > src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java > b9dccc6ba0dc6e62c8c874606622bba883d0736d > src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java > 0f0bfcab62a53869dc5190f063b2ef30da45ae55 > src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java > 0e32990e3c8776d505b58b3e0ff54fa190897ecc > src/test/java/org/apache/aurora/scheduler/preemptor/BiCacheTest.java > 731209196e3d1cc566b4ae460b9532dc350d0a21 > > src/test/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerImplTest.java > 350ec6f3c6aa0526b484758a64165392c87842c4 > src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java > c9c6f5d47300996abab3b0b9045022fe2dbb18ee > > Diff: https://reviews.apache.org/r/37206/diff/ > > > Testing > --- > > > Thanks, > > Maxim Khutornenko > >
Re: Review Request 37206: Fixing slave/task reservation check.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37206/#review94487 --- Ship it! Master (8adc9bd) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Aug. 7, 2015, 4:12 a.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37206/ > --- > > (Updated Aug. 7, 2015, 4:12 a.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Bugs: AURORA-1431 > https://issues.apache.org/jira/browse/AURORA-1431 > > > Repository: aurora > > > Description > --- > > Fixing this required exposing a map from BiCache. Reversed to the original > slave->task mapping as it makes easier to consume cache map. > > Also, added timed stats to ensure we cover all parts of the scheduling loop. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java > 54ffd8e3e76527e39c55ac735c3d1e71b317cbf4 > src/main/java/org/apache/aurora/scheduler/preemptor/BiCache.java > 2551057d718d306db698f4b87cfd93bee2753e51 > src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java > b9dccc6ba0dc6e62c8c874606622bba883d0736d > src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java > 0f0bfcab62a53869dc5190f063b2ef30da45ae55 > src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java > 0e32990e3c8776d505b58b3e0ff54fa190897ecc > src/test/java/org/apache/aurora/scheduler/preemptor/BiCacheTest.java > 731209196e3d1cc566b4ae460b9532dc350d0a21 > > src/test/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerImplTest.java > 350ec6f3c6aa0526b484758a64165392c87842c4 > src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java > c9c6f5d47300996abab3b0b9045022fe2dbb18ee > > Diff: https://reviews.apache.org/r/37206/diff/ > > > Testing > --- > > > Thanks, > > Maxim Khutornenko > >
Review Request 37206: Fixing slave/task reservation check.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37206/ --- Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1431 https://issues.apache.org/jira/browse/AURORA-1431 Repository: aurora Description --- Fixing this required exposing a map from BiCache. Reversed to the original slave->task mapping as it makes easier to consume cache map. Also, added timed stats to ensure we cover all parts of the scheduling loop. Diffs - src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 54ffd8e3e76527e39c55ac735c3d1e71b317cbf4 src/main/java/org/apache/aurora/scheduler/preemptor/BiCache.java 2551057d718d306db698f4b87cfd93bee2753e51 src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java b9dccc6ba0dc6e62c8c874606622bba883d0736d src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java 0f0bfcab62a53869dc5190f063b2ef30da45ae55 src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 0e32990e3c8776d505b58b3e0ff54fa190897ecc src/test/java/org/apache/aurora/scheduler/preemptor/BiCacheTest.java 731209196e3d1cc566b4ae460b9532dc350d0a21 src/test/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerImplTest.java 350ec6f3c6aa0526b484758a64165392c87842c4 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java c9c6f5d47300996abab3b0b9045022fe2dbb18ee Diff: https://reviews.apache.org/r/37206/diff/ Testing --- Thanks, Maxim Khutornenko
