Re: Review Request 37366: Resources: finalizing Resources.java refactoring.

2015-08-14 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37366/ --- (Updated Aug. 14, 2015, 8:05 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 37366: Resources: finalizing Resources.java refactoring.

2015-08-14 Thread Maxim Khutornenko
On Aug. 14, 2015, 4:11 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/Resources.java, line 187 https://reviews.apache.org/r/37366/diff/1/?file=1037844#file1037844line187 nit: any reason this declaration was moved after it's usage? Just trying to make it

Re: Review Request 37366: Resources: finalizing Resources.java refactoring.

2015-08-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37366/#review95342 --- Ship it! Ship It! - Zameer Manji On Aug. 13, 2015, 2:46 p.m.,

Re: Review Request 37366: Resources: finalizing Resources.java refactoring.

2015-08-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37366/#review94987 --- This patch does not apply cleanly on master (cbc42c4), do you need