Re: Review Request 37483: Suppressing Unregistered executor status message.

2015-08-14 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37483/#review95443
---

Ship it!


Master (76d5a49) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Aug. 14, 2015, 4:34 p.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37483/
 ---
 
 (Updated Aug. 14, 2015, 4:34 p.m.)
 
 
 Review request for Aurora and Zameer Manji.
 
 
 Bugs: AURORA-1193
 https://issues.apache.org/jira/browse/AURORA-1193
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Following the proposal in the ticket suppressing only Unregistered executor 
 message.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 
 24a7a2ce0ae2ee4fc8f7e87325997480f2457312 
   src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 
 83dcb4b6aedf6932bde54da4eda131d829e94143 
 
 Diff: https://reviews.apache.org/r/37483/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Maxim Khutornenko
 




Re: Review Request 37483: Suppressing Unregistered executor status message.

2015-08-14 Thread Maxim Khutornenko


 On Aug. 14, 2015, 4:13 p.m., Aurora ReviewBot wrote:
  Master (76d5a49) is red with this patch.
./build-support/jenkins/build.sh
  
  [ant:checkstyle] 
  /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:108:
   'return' have incorrect indentation level 6, expected level should be 8.
  [ant:checkstyle] 
  /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:109:
   'block rcurly' have incorrect indentation level 4, expected level should 
  be 6.
  [ant:checkstyle] 
  /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:131:
   'block' child have incorrect indentation level 10, expected level should 
  be 12.
  [ant:checkstyle] 
  /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:131:
   'method call' child have incorrect indentation level 10, expected level 
  should be 12.
  [ant:checkstyle] 
  /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:132:
   'block' child have incorrect indentation level 10, expected level should 
  be 12.
  [ant:checkstyle] 
  /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:133:
   'block rcurly' have incorrect indentation level 8, expected level should 
  be 10.
  [ant:checkstyle] 
  /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:171:
   'block' child have incorrect indentation level 6, expected level should be 
  8.
  [ant:checkstyle] 
  /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:171:
   'latch' have incorrect indentation level 6, expected level should be 8.
  [ant:checkstyle] 
  /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:171:
   'method call' child have incorrect indentation level 6, expected level 
  should be 8.
  [ant:checkstyle] 
  /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:172:
   'block' child have incorrect indentation level 6, expected level should be 
  8.
  [ant:checkstyle] 
  /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:172:
   'return' have incorrect indentation level 6, expected level should be 8.
  [ant:checkstyle] 
  /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:173:
   'block rcurly' have incorrect indentation level 4, expected level should 
  be 6.
  [ant:checkstyle] 
  /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:205:
   'block' child have incorrect indentation level 6, expected level should be 
  8.
  [ant:checkstyle] 
  /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:205:
   'latch' have incorrect indentation level 6, expected level should be 8.
  [ant:checkstyle] 
  /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:205:
   'method call' child have incorrect indentation level 6, expected level 
  should be 8.
  [ant:checkstyle] 
  /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:206:
   'block' child have incorrect indentation level 6, expected level should be 
  8.
  [ant:checkstyle] 
  /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:206:
   'return' have incorrect indentation level 6, expected level should be 8.
  [ant:checkstyle] 
  /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:207:
   'block rcurly' have incorrect indentation level 4, expected level should 
  be 6.
  [ant:checkstyle] 
  /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:240:
   'block' child have incorrect indentation level 10, expected level should 
  be 12.
  [ant:checkstyle] 
  /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:241:
   'block rcurly' have incorrect indentation level 8, expected level should 
  be 10.
  [ant:checkstyle] 
  /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:247:
   'block' child have incorrect indentation level 6, expected level should be 
  

Re: Review Request 37483: Suppressing Unregistered executor status message.

2015-08-14 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37483/
---

(Updated Aug. 14, 2015, 4:34 p.m.)


Review request for Aurora and Zameer Manji.


Changes
---

Converting back from lambdas to make checkstyle happy.


Bugs: AURORA-1193
https://issues.apache.org/jira/browse/AURORA-1193


Repository: aurora


Description
---

Following the proposal in the ticket suppressing only Unregistered executor 
message.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 
24a7a2ce0ae2ee4fc8f7e87325997480f2457312 
  src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 
83dcb4b6aedf6932bde54da4eda131d829e94143 

Diff: https://reviews.apache.org/r/37483/diff/


Testing
---


Thanks,

Maxim Khutornenko



Review Request 37483: Suppressing Unregistered executor status message.

2015-08-14 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37483/
---

Review request for Aurora and Zameer Manji.


Bugs: AURORA-1193
https://issues.apache.org/jira/browse/AURORA-1193


Repository: aurora


Description
---

Following the proposal in the ticket suppressing only Unregistered executor 
message.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 
24a7a2ce0ae2ee4fc8f7e87325997480f2457312 
  src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 
83dcb4b6aedf6932bde54da4eda131d829e94143 

Diff: https://reviews.apache.org/r/37483/diff/


Testing
---


Thanks,

Maxim Khutornenko