Re: Review Request 37624: Updating preemptor to account for revocable offers/tasks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37624/#review95990 --- Ship it! LGTM, just rebase and wait for an all clear from reviewbot. - Zameer Manji On Aug. 19, 2015, 4:49 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37624/ --- (Updated Aug. 19, 2015, 4:49 p.m.) Review request for Aurora and Zameer Manji. Bugs: AURORA-1418 https://issues.apache.org/jira/browse/AURORA-1418 Repository: aurora Description --- Preemption filter now ignores revocable offers but still considers revocable task non-compressible resources. Will not apply, diffed against https://reviews.apache.org/r/37593. Diffs - src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java 8162323816aedc711a3af84cd499250b78718ab3 src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java a0e71e1c74f67b8836e7da5418012f342977f661 src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 66f20c6a63b331353c467cde5521f21e4df49e2d Diff: https://reviews.apache.org/r/37624/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 37624: Updating preemptor to account for revocable offers/tasks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37624/ --- (Updated Aug. 20, 2015, 8:10 p.m.) Review request for Aurora and Zameer Manji. Changes --- Rebased. Bugs: AURORA-1418 https://issues.apache.org/jira/browse/AURORA-1418 Repository: aurora Description (updated) --- Preemption filter now ignores revocable offers but still considers revocable task non-compressible resources. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java 8162323816aedc711a3af84cd499250b78718ab3 src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java a0e71e1c74f67b8836e7da5418012f342977f661 src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 66f20c6a63b331353c467cde5521f21e4df49e2d Diff: https://reviews.apache.org/r/37624/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Review Request 37624: Updating preemptor to account for revocable offers/tasks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37624/ --- Review request for Aurora and Zameer Manji. Bugs: AURORA-1418 https://issues.apache.org/jira/browse/AURORA-1418 Repository: aurora Description --- Preemption filter now ignores revocable offers but still considers revocable task non-compressible resources. Will not apply, diffed against https://reviews.apache.org/r/37593. Diffs - src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java 8162323816aedc711a3af84cd499250b78718ab3 src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java a0e71e1c74f67b8836e7da5418012f342977f661 src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 66f20c6a63b331353c467cde5521f21e4df49e2d Diff: https://reviews.apache.org/r/37624/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 37624: Updating preemptor to account for revocable offers/tasks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37624/#review95900 --- Master (f5025f3) is red with this patch. ./build-support/jenkins/build.sh make[3]: Entering directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1/tutorial' make[4]: Entering directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1/tutorial' ../compiler/cpp/thrift --gen html -r ../tutorial/tutorial.thrift make[4]: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1/tutorial' make[3]: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1/tutorial' make[3]: Entering directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1' make[3]: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1' make[2]: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1' make[1]: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1' make: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift' :api:classesThriftNote: Some input files use unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. :api:checkPython :api:generateThriftEntitiesJava :api:classesThriftEntities :api:compileJava UP-TO-DATE :api:generateThriftResources :api:processResources UP-TO-DATE :api:classes :api:jar :compileJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2 /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java:103: error: NON_REVOCABLE has private access in Resources return Resources.from(offer.getOffer()).filter(Resources.NON_REVOCABLE).slot(); ^ 1 error FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':compileJava'. Compilation failed; see the compiler error output for details. * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 1 mins 57.857 secs I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Aug. 19, 2015, 11:49 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37624/ --- (Updated Aug. 19, 2015, 11:49 p.m.) Review request for Aurora and Zameer Manji. Bugs: AURORA-1418 https://issues.apache.org/jira/browse/AURORA-1418 Repository: aurora Description --- Preemption filter now ignores revocable offers but still considers revocable task non-compressible resources. Will not apply, diffed against https://reviews.apache.org/r/37593. Diffs - src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java 8162323816aedc711a3af84cd499250b78718ab3 src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java a0e71e1c74f67b8836e7da5418012f342977f661 src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 66f20c6a63b331353c467cde5521f21e4df49e2d Diff: https://reviews.apache.org/r/37624/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
