Review Request 37743: Replace realpath to get build working on jenkins.

2015-08-24 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37743/
---

Review request for Aurora and Maxim Khutornenko.


Repository: aurora-packaging


Description
---

Using this to replace the use of `realpath`, which is non-default and not 
available on our jenkins machines.

See relevant discussion here: 
http://stackoverflow.com/questions/3915040/bash-fish-command-to-print-absolute-path-to-a-file


Diffs
-

  build-artifact.sh 263851c2e485caee2e0733c9cf537d9a951733a8 

Diff: https://reviews.apache.org/r/37743/diff/


Testing
---


Thanks,

Bill Farner



Re: Review Request 37743: Replace realpath to get build working on jenkins.

2015-08-24 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37743/#review96283
---

Ship it!


Ship It!

- Maxim Khutornenko


On Aug. 25, 2015, 2:27 a.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37743/
 ---
 
 (Updated Aug. 25, 2015, 2:27 a.m.)
 
 
 Review request for Aurora and Maxim Khutornenko.
 
 
 Repository: aurora-packaging
 
 
 Description
 ---
 
 Using this to replace the use of `realpath`, which is non-default and not 
 available on our jenkins machines.
 
 See relevant discussion here: 
 http://stackoverflow.com/questions/3915040/bash-fish-command-to-print-absolute-path-to-a-file
 
 
 Diffs
 -
 
   build-artifact.sh 263851c2e485caee2e0733c9cf537d9a951733a8 
 
 Diff: https://reviews.apache.org/r/37743/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 37743: Replace realpath to get build working on jenkins.

2015-08-24 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37743/#review96289
---

Ship it!


on Linux you can use `readlink -f` for this as well

- Kevin Sweeney


On Aug. 24, 2015, 7:27 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37743/
 ---
 
 (Updated Aug. 24, 2015, 7:27 p.m.)
 
 
 Review request for Aurora and Maxim Khutornenko.
 
 
 Repository: aurora-packaging
 
 
 Description
 ---
 
 Using this to replace the use of `realpath`, which is non-default and not 
 available on our jenkins machines.
 
 See relevant discussion here: 
 http://stackoverflow.com/questions/3915040/bash-fish-command-to-print-absolute-path-to-a-file
 
 
 Diffs
 -
 
   build-artifact.sh 263851c2e485caee2e0733c9cf537d9a951733a8 
 
 Diff: https://reviews.apache.org/r/37743/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Bill Farner