Re: Review Request 37825: Adding minimal implementation of the external tier config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/ --- (Updated Aug. 31, 2015, 10:17 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 37825: Adding minimal implementation of the external tier config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/#review97027 --- Ship it!

Re: Review Request 37825: Adding minimal implementation of the external tier config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/ --- (Updated Aug. 29, 2015, 6:34 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 37825: Adding minimal implementation of the external tier config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/#review96963 --- Ship it! Master (356eeac) is green with this patch.

Re: Review Request 37825: Adding minimal implementation of the external tier config.

On Aug. 27, 2015, 5:23 p.m., Bill Farner wrote: src/test/resources/org/apache/aurora/scheduler/tiers-example.json, line 2 https://reviews.apache.org/r/37825/diff/1/?file=103#file103line2 The added layer here seems slightly weird, but i can see why it's useful - you can

Re: Review Request 37825: Adding minimal implementation of the external tier config.

On Aug. 27, 2015, 10:23 a.m., Bill Farner wrote: src/test/resources/org/apache/aurora/scheduler/tiers-example.json, line 2 https://reviews.apache.org/r/37825/diff/1/?file=103#file103line2 The added layer here seems slightly weird, but i can see why it's useful - you can

Re: Review Request 37825: Adding minimal implementation of the external tier config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/#review96703 --- src/main/java/org/apache/aurora/scheduler/SchedulerModule.java

Re: Review Request 37825: Adding minimal implementation of the external tier config.

On Aug. 27, 2015, 10:23 a.m., Bill Farner wrote: src/test/resources/org/apache/aurora/scheduler/tiers-example.json, line 2 https://reviews.apache.org/r/37825/diff/1/?file=103#file103line2 The added layer here seems slightly weird, but i can see why it's useful - you can

Re: Review Request 37825: Adding minimal implementation of the external tier config.

On Aug. 27, 2015, 10:23 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/TierManager.java, line 63 https://reviews.apache.org/r/37825/diff/1/?file=101#file101line63 Consider moving the parsing up a layer, in the module. That way we can report earlier if

Re: Review Request 37825: Adding minimal implementation of the external tier config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/#review96714 --- src/main/java/org/apache/aurora/scheduler/SchedulerModule.java

Re: Review Request 37825: Adding minimal implementation of the external tier config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/#review96730 --- Ship it! Master (06ddaad) is green with this patch.

Re: Review Request 37825: Adding minimal implementation of the external tier config.

On Aug. 27, 2015, 10:23 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/SchedulerModule.java, line 70 https://reviews.apache.org/r/37825/diff/1/?file=100#file100line70 +@CanRead That will cause loading to fail when the argument is null. - Kevin

Re: Review Request 37825: Adding minimal implementation of the external tier config.

On Aug. 27, 2015, 5:23 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/TierManager.java, line 63 https://reviews.apache.org/r/37825/diff/1/?file=101#file101line63 Consider moving the parsing up a layer, in the module. That way we can report earlier if

Re: Review Request 37825: Adding minimal implementation of the external tier config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/ --- (Updated Aug. 27, 2015, 9:17 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 37825: Adding minimal implementation of the external tier config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/#review96771 --- Ship it! Master (06ddaad) is green with this patch.

Re: Review Request 37825: Adding minimal implementation of the external tier config.

On Aug. 27, 2015, 5:54 p.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/SchedulerModule.java, line 117 https://reviews.apache.org/r/37825/diff/1/?file=100#file100line117 I think this function should also parse the data into MapString, TierInfo. The

Re: Review Request 37825: Adding minimal implementation of the external tier config.

On Aug. 27, 2015, 10:54 a.m., Zameer Manji wrote: src/test/java/org/apache/aurora/scheduler/TierManagerTest.java, line 26 https://reviews.apache.org/r/37825/diff/1/?file=102#file102line26 Please add a test for the config for having keys that are not expected. I would

Re: Review Request 37825: Adding minimal implementation of the external tier config.

On Aug. 27, 2015, 5:54 p.m., Zameer Manji wrote: src/test/java/org/apache/aurora/scheduler/TierManagerTest.java, line 26 https://reviews.apache.org/r/37825/diff/1/?file=102#file102line26 Please add a test for the config for having keys that are not expected. I would

Review Request 37825: Adding minimal implementation of the external tier config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1437