Re: Review Request 37936: Upgrade to Guava 18

2015-08-30 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37936/#review97047
---


Master (4899e2d) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Aug. 31, 2015, 12:29 a.m., Zameer Manji wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37936/
 ---
 
 (Updated Aug. 31, 2015, 12:29 a.m.)
 
 
 Review request for Aurora and Bill Farner.
 
 
 Bugs: AURORA-586
 https://issues.apache.org/jira/browse/AURORA-586
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Upgrades the Gauva dep to 18. Full release notes can be found here:
 * https://code.google.com/p/guava-libraries/wiki/Release17
 * https://code.google.com/p/guava-libraries/wiki/Release18
 
 Relevant changes are the introduction of `MoreObjects`, removal of 
 `InputSupplier` and `OutputSupplier` interfaces and replacing 
 `MoreExecutors.sameThreadExecutor()` with 
 `MoreExecutors.newDirectExecutorService()`.
 
 
 Diffs
 -
 
   build.gradle 7b9a0822b43a7f3e44cdc096234eece3ddf2a116 
   
 commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java
  e8e64478c71e0de18c263a8924e75e009c8aee2f 
   
 commons/src/main/java/org/apache/aurora/common/net/http/handlers/AssetHandler.java
  a514f142e14412d2638dfcacf301835857677fc3 
   
 commons/src/test/java/org/apache/aurora/common/net/http/handlers/AssetHandlerTest.java
  d82816bea6bc9171df989d80ce1d764726cf4097 
   src/main/java/org/apache/aurora/scheduler/HostOffer.java 
 5056b60c32ab1c8f1b8d682be4827c489da2a104 
   src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 
 11d4a0870505e45422f87f0c06ed8cd06b505a3b 
   src/main/java/org/apache/aurora/scheduler/TierInfo.java 
 61bf30a7f11d2d4b9e49c58a6ed9ecd779d7e5ba 
   src/main/java/org/apache/aurora/scheduler/base/Query.java 
 458530fb216fd37048d3e398c07b147a1a71cf57 
   src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 
 46e89cd51750b92a1e4afcdb03cba0ff22a24109 
   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
 298ac74a0909beb7f8e6da4990c8936ff499b9d7 
   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
 260e11e910e97c1057351c206f0f763c04d4502a 
   src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionProposal.java 
 d598b02b68c5d67610004cbd5eeefab2e9658b69 
   src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java 
 8f3161acdab0e2d25403ee224cd6468327ee956f 
   src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 
 3e258127f452070214d5e9df9da25f5b38d0d886 
   src/main/java/org/apache/aurora/scheduler/spi/Permissions.java 
 b9dff4471fe6bc6b793f7fb15de3a5c2e2d39209 
   src/main/java/org/apache/aurora/scheduler/state/TransitionResult.java 
 6928c663d9f3f46ab81816d3d0ef4e7d0485e368 
   src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java 
 0a1a2925385374dd070b024e7bf2887969b3da37 
   src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java 
 5b1e2b90601720cd0d9934940513bbecc48b4863 
   src/main/java/org/apache/aurora/scheduler/updater/SideEffect.java 
 3f4924266e863587fcc8c44df9cb73b6e1e29259 
 
 Diff: https://reviews.apache.org/r/37936/diff/
 
 
 Testing
 ---
 
 ./gradlew clean build -Pq
 
 
 Thanks,
 
 Zameer Manji
 




Review Request 37936: Upgrade to Guava 18

2015-08-30 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37936/
---

Review request for Aurora and Bill Farner.


Bugs: AURORA-586
https://issues.apache.org/jira/browse/AURORA-586


Repository: aurora


Description
---

Upgrades the Gauva dep to 18. Full release notes can be found here:
* https://code.google.com/p/guava-libraries/wiki/Release17
* https://code.google.com/p/guava-libraries/wiki/Release18

Relevant changes are the introduction of `MoreObjects`, removal of 
`InputSupplier` and `OutputSupplier` interfaces and replacing 
`MoreExecutors.sameThreadExecutor()` with 
`MoreExecutors.newDirectExecutorService()`.


Diffs
-

  build.gradle 7b9a0822b43a7f3e44cdc096234eece3ddf2a116 
  
commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java 
e8e64478c71e0de18c263a8924e75e009c8aee2f 
  
commons/src/main/java/org/apache/aurora/common/net/http/handlers/AssetHandler.java
 a514f142e14412d2638dfcacf301835857677fc3 
  
commons/src/test/java/org/apache/aurora/common/net/http/handlers/AssetHandlerTest.java
 d82816bea6bc9171df989d80ce1d764726cf4097 
  src/main/java/org/apache/aurora/scheduler/HostOffer.java 
5056b60c32ab1c8f1b8d682be4827c489da2a104 
  src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 
11d4a0870505e45422f87f0c06ed8cd06b505a3b 
  src/main/java/org/apache/aurora/scheduler/TierInfo.java 
61bf30a7f11d2d4b9e49c58a6ed9ecd779d7e5ba 
  src/main/java/org/apache/aurora/scheduler/base/Query.java 
458530fb216fd37048d3e398c07b147a1a71cf57 
  src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 
46e89cd51750b92a1e4afcdb03cba0ff22a24109 
  src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
298ac74a0909beb7f8e6da4990c8936ff499b9d7 
  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
260e11e910e97c1057351c206f0f763c04d4502a 
  src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionProposal.java 
d598b02b68c5d67610004cbd5eeefab2e9658b69 
  src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java 
8f3161acdab0e2d25403ee224cd6468327ee956f 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 
3e258127f452070214d5e9df9da25f5b38d0d886 
  src/main/java/org/apache/aurora/scheduler/spi/Permissions.java 
b9dff4471fe6bc6b793f7fb15de3a5c2e2d39209 
  src/main/java/org/apache/aurora/scheduler/state/TransitionResult.java 
6928c663d9f3f46ab81816d3d0ef4e7d0485e368 
  src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java 
0a1a2925385374dd070b024e7bf2887969b3da37 
  src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java 
5b1e2b90601720cd0d9934940513bbecc48b4863 
  src/main/java/org/apache/aurora/scheduler/updater/SideEffect.java 
3f4924266e863587fcc8c44df9cb73b6e1e29259 

Diff: https://reviews.apache.org/r/37936/diff/


Testing
---

./gradlew clean build -Pq


Thanks,

Zameer Manji