Re: Review Request 37988: Remove unused commons classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37988/#review97249 --- Ship it! Ship It! - Bill Farner On Aug. 31, 2015, 8:33 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37988/ > --- > > (Updated Aug. 31, 2015, 8:33 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > --- > > This removes more commons classes. > > > Diffs > - > > commons/src/main/java/org/apache/aurora/common/base/MoreSuppliers.java > c120d1d7dfa4f88c01ff83a9dc5a6f7edf0e0ff4 > > commons/src/main/java/org/apache/aurora/common/testing/easymock/IterableEquals.java > bcd0a15cddfc7bae04fb7206ab203e6c29a7f58b > > commons/src/main/java/org/apache/aurora/common/thrift/testing/TestThriftTypes.java > 16994167e8db4b89fb4ba39885a0821dd84a6754 > > commons/src/main/java/org/apache/aurora/common/util/concurrent/ExceptionHandlingExecutorService.java > df11d6d3b0a05adc27700028d18213fb8411c0d1 > > commons/src/main/java/org/apache/aurora/common/util/concurrent/ExceptionHandlingScheduledExecutorService.java > fa0bd7d1eb3b5cb62284e0c1eae3485cbb20feb5 > > commons/src/main/java/org/apache/aurora/common/util/concurrent/ForwardingExecutorService.java > b8a0fd9d3cbe019ed66be66ded75fbcb4c167fd1 > > commons/src/main/java/org/apache/aurora/common/util/concurrent/MoreExecutors.java > 630b9aab2a3ca56a2e30e9a2867cbaf3d1dbcd48 > > commons/src/main/java/org/apache/aurora/common/util/concurrent/TaskConverter.java > 5971e37063f6e5a6db1fbce1120900bbffb3313f > commons/src/test/java/org/apache/aurora/common/base/MoreSuppliersTest.java > 7c67dee33475c76b9401763fd57bacc1884c6d10 > > commons/src/test/java/org/apache/aurora/common/testing/easymock/IterableEqualsTest.java > 01966167c2671788ab957a627a544750c8ec34d6 > > commons/src/test/java/org/apache/aurora/common/util/concurrent/ExceptionHandlingExecutorServiceTest.java > 722f1ccb5fdc322b74cbc0eba24cd0d6d61cc8e0 > > commons/src/test/java/org/apache/aurora/common/util/concurrent/ExceptionHandlingScheduledExecutorServiceTest.java > 3b2c96bf9b1771429e5ffcc87f192e89c52b5216 > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > 0a7163bb766764ec5a37d347f1ee9c2ad2842059 > > Diff: https://reviews.apache.org/r/37988/diff/ > > > Testing > --- > > > Thanks, > > Zameer Manji > >
Re: Review Request 37988: Remove unused commons classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37988/#review97239 --- Master (c8e65d3) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Sept. 1, 2015, 3:33 a.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37988/ > --- > > (Updated Sept. 1, 2015, 3:33 a.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > --- > > This removes more commons classes. > > > Diffs > - > > commons/src/main/java/org/apache/aurora/common/base/MoreSuppliers.java > c120d1d7dfa4f88c01ff83a9dc5a6f7edf0e0ff4 > > commons/src/main/java/org/apache/aurora/common/testing/easymock/IterableEquals.java > bcd0a15cddfc7bae04fb7206ab203e6c29a7f58b > > commons/src/main/java/org/apache/aurora/common/thrift/testing/TestThriftTypes.java > 16994167e8db4b89fb4ba39885a0821dd84a6754 > > commons/src/main/java/org/apache/aurora/common/util/concurrent/ExceptionHandlingExecutorService.java > df11d6d3b0a05adc27700028d18213fb8411c0d1 > > commons/src/main/java/org/apache/aurora/common/util/concurrent/ExceptionHandlingScheduledExecutorService.java > fa0bd7d1eb3b5cb62284e0c1eae3485cbb20feb5 > > commons/src/main/java/org/apache/aurora/common/util/concurrent/ForwardingExecutorService.java > b8a0fd9d3cbe019ed66be66ded75fbcb4c167fd1 > > commons/src/main/java/org/apache/aurora/common/util/concurrent/MoreExecutors.java > 630b9aab2a3ca56a2e30e9a2867cbaf3d1dbcd48 > > commons/src/main/java/org/apache/aurora/common/util/concurrent/TaskConverter.java > 5971e37063f6e5a6db1fbce1120900bbffb3313f > commons/src/test/java/org/apache/aurora/common/base/MoreSuppliersTest.java > 7c67dee33475c76b9401763fd57bacc1884c6d10 > > commons/src/test/java/org/apache/aurora/common/testing/easymock/IterableEqualsTest.java > 01966167c2671788ab957a627a544750c8ec34d6 > > commons/src/test/java/org/apache/aurora/common/util/concurrent/ExceptionHandlingExecutorServiceTest.java > 722f1ccb5fdc322b74cbc0eba24cd0d6d61cc8e0 > > commons/src/test/java/org/apache/aurora/common/util/concurrent/ExceptionHandlingScheduledExecutorServiceTest.java > 3b2c96bf9b1771429e5ffcc87f192e89c52b5216 > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > 0a7163bb766764ec5a37d347f1ee9c2ad2842059 > > Diff: https://reviews.apache.org/r/37988/diff/ > > > Testing > --- > > > Thanks, > > Zameer Manji > >
Review Request 37988: Remove unused commons classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37988/ --- Review request for Aurora and Bill Farner. Repository: aurora Description --- This removes more commons classes. Diffs - commons/src/main/java/org/apache/aurora/common/base/MoreSuppliers.java c120d1d7dfa4f88c01ff83a9dc5a6f7edf0e0ff4 commons/src/main/java/org/apache/aurora/common/testing/easymock/IterableEquals.java bcd0a15cddfc7bae04fb7206ab203e6c29a7f58b commons/src/main/java/org/apache/aurora/common/thrift/testing/TestThriftTypes.java 16994167e8db4b89fb4ba39885a0821dd84a6754 commons/src/main/java/org/apache/aurora/common/util/concurrent/ExceptionHandlingExecutorService.java df11d6d3b0a05adc27700028d18213fb8411c0d1 commons/src/main/java/org/apache/aurora/common/util/concurrent/ExceptionHandlingScheduledExecutorService.java fa0bd7d1eb3b5cb62284e0c1eae3485cbb20feb5 commons/src/main/java/org/apache/aurora/common/util/concurrent/ForwardingExecutorService.java b8a0fd9d3cbe019ed66be66ded75fbcb4c167fd1 commons/src/main/java/org/apache/aurora/common/util/concurrent/MoreExecutors.java 630b9aab2a3ca56a2e30e9a2867cbaf3d1dbcd48 commons/src/main/java/org/apache/aurora/common/util/concurrent/TaskConverter.java 5971e37063f6e5a6db1fbce1120900bbffb3313f commons/src/test/java/org/apache/aurora/common/base/MoreSuppliersTest.java 7c67dee33475c76b9401763fd57bacc1884c6d10 commons/src/test/java/org/apache/aurora/common/testing/easymock/IterableEqualsTest.java 01966167c2671788ab957a627a544750c8ec34d6 commons/src/test/java/org/apache/aurora/common/util/concurrent/ExceptionHandlingExecutorServiceTest.java 722f1ccb5fdc322b74cbc0eba24cd0d6d61cc8e0 commons/src/test/java/org/apache/aurora/common/util/concurrent/ExceptionHandlingScheduledExecutorServiceTest.java 3b2c96bf9b1771429e5ffcc87f192e89c52b5216 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 0a7163bb766764ec5a37d347f1ee9c2ad2842059 Diff: https://reviews.apache.org/r/37988/diff/ Testing --- Thanks, Zameer Manji
