Re: Review Request 38080: Remove openjdk runtime requirement.

2015-09-02 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38080/#review97573
---

Ship it!


Ship It!

- Bill Farner


On Sept. 2, 2015, 4:36 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38080/
> ---
> 
> (Updated Sept. 2, 2015, 4:36 p.m.)
> 
> 
> Review request for Aurora, Steve Salevan and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Remove openjdk runtime requirement.
> 
> This addresses one of my +0s.
> 
> 
> Diffs
> -
> 
>   specs/rpm/aurora.spec a559b42d73a4211891d8c7569ea7ab2a3a6993ae 
> 
> Diff: https://reviews.apache.org/r/38080/diff/
> 
> 
> Testing
> ---
> 
> Using a clean vagrant environment installed aurora, then installed the oracle 
> jdk, then uninstalled java-1.8.0-openjdk-headless (that aurora brought in 
> transitively). RPM didn't complain and when I restarted the scheduler it was 
> running under the new JVM.
> 
> ```
> [vagrant@localhost ~]$ curl -s http://localhost:8081/vars | grep 
> 'jvm_prop_java_vendor '
> jvm_prop_java_vendor Oracle Corporation
> [vagrant@localhost ~]$ 
> ```
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>



Re: Review Request 38080: Remove openjdk runtime requirement.

2015-09-02 Thread Bill Farner


> On Sept. 2, 2015, 5:08 p.m., Bill Farner wrote:
> > Ship It!
> 
> Kevin Sweeney wrote:
> procedural question - I see there's a long-running 0.9.x branch - should 
> I merge this to master then merge this into that branch?

More or less, yes - i've been cherry-picking back onto 0.9.x.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38080/#review97573
---


On Sept. 2, 2015, 4:36 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38080/
> ---
> 
> (Updated Sept. 2, 2015, 4:36 p.m.)
> 
> 
> Review request for Aurora, Steve Salevan and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Remove openjdk runtime requirement.
> 
> This addresses one of my +0s.
> 
> 
> Diffs
> -
> 
>   specs/rpm/aurora.spec a559b42d73a4211891d8c7569ea7ab2a3a6993ae 
> 
> Diff: https://reviews.apache.org/r/38080/diff/
> 
> 
> Testing
> ---
> 
> Using a clean vagrant environment installed aurora, then installed the oracle 
> jdk, then uninstalled java-1.8.0-openjdk-headless (that aurora brought in 
> transitively). RPM didn't complain and when I restarted the scheduler it was 
> running under the new JVM.
> 
> ```
> [vagrant@localhost ~]$ curl -s http://localhost:8081/vars | grep 
> 'jvm_prop_java_vendor '
> jvm_prop_java_vendor Oracle Corporation
> [vagrant@localhost ~]$ 
> ```
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>



Review Request 38080: Remove openjdk runtime requirement.

2015-09-02 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38080/
---

Review request for Aurora, Steve Salevan and Bill Farner.


Repository: aurora-packaging


Description
---

Remove openjdk runtime requirement.

This addresses one of my +0s.


Diffs
-

  specs/rpm/aurora.spec a559b42d73a4211891d8c7569ea7ab2a3a6993ae 

Diff: https://reviews.apache.org/r/38080/diff/


Testing
---

Using a clean vagrant environment installed aurora, then installed the oracle 
jdk, then uninstalled java-1.8.0-openjdk-headless (that aurora brought in 
transitively). RPM didn't complain and when I restarted the scheduler it was 
running under the new JVM.

```
[vagrant@localhost ~]$ curl -s http://localhost:8081/vars | grep 
'jvm_prop_java_vendor '
jvm_prop_java_vendor Oracle Corporation
[vagrant@localhost ~]$ 
```


Thanks,

Kevin Sweeney



Re: Review Request 38080: Remove openjdk runtime requirement.

2015-09-02 Thread Kevin Sweeney


> On Sept. 2, 2015, 5:08 p.m., Bill Farner wrote:
> > Ship It!

procedural question - I see there's a long-running 0.9.x branch - should I 
merge this to master then merge this into that branch?


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38080/#review97573
---


On Sept. 2, 2015, 4:36 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38080/
> ---
> 
> (Updated Sept. 2, 2015, 4:36 p.m.)
> 
> 
> Review request for Aurora, Steve Salevan and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Remove openjdk runtime requirement.
> 
> This addresses one of my +0s.
> 
> 
> Diffs
> -
> 
>   specs/rpm/aurora.spec a559b42d73a4211891d8c7569ea7ab2a3a6993ae 
> 
> Diff: https://reviews.apache.org/r/38080/diff/
> 
> 
> Testing
> ---
> 
> Using a clean vagrant environment installed aurora, then installed the oracle 
> jdk, then uninstalled java-1.8.0-openjdk-headless (that aurora brought in 
> transitively). RPM didn't complain and when I restarted the scheduler it was 
> running under the new JVM.
> 
> ```
> [vagrant@localhost ~]$ curl -s http://localhost:8081/vars | grep 
> 'jvm_prop_java_vendor '
> jvm_prop_java_vendor Oracle Corporation
> [vagrant@localhost ~]$ 
> ```
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>