----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38331/#review98755 -----------------------------------------------------------
Ship it! Master (5dccf92) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Sept. 12, 2015, 8:16 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38331/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2015, 8:16 p.m.) > > > Review request for Aurora and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > I also did some long-overdue module cleanup in this effort, making it > unnecessary to pass arguments through several layers. > Another nice side-effect is that `LocalSchedulerMain` no longer extends > `SchedulerMain`, which i find to be a much cleaner arrangement. > > > Diffs > ----- > > commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java > 64968702e01dd8831431d6f031291e776480d7f6 > commons/src/main/java/org/apache/aurora/common/application/Application.java > ebe01e8be06e24bc04e25e3b58b50ecb1ce73c7e > commons/src/main/java/org/apache/aurora/common/application/Lifecycle.java > 5d22a2aea5b6f311c528180ed7610e1874f8242c > > commons/src/main/java/org/apache/aurora/common/application/modules/AppLauncherModule.java > 1c08f7e756e9a97ffa7a6db75cbec1f48150d8da > config/checkstyle/checkstyle.xml 9c291f5cc4d70e6c920cbf033a2f5fee18f33229 > config/checkstyle/suppressions.xml PRE-CREATION > config/legacy_untested_classes.txt 07fd5f1066a4d926072d91b9de170b9035fb3ea4 > src/main/java/org/apache/aurora/scheduler/app/AppModule.java > 78071ed5cceed55e1fa4ba3fe55a4a60a0ff2fdf > src/main/java/org/apache/aurora/scheduler/app/Modules.java > cad7c38ca62767093c23923ff83d7aefda6dc54f > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > 11f04da3783677208347873e5e7c92aad6b98f40 > src/main/java/org/apache/aurora/scheduler/app/ServiceDiscoveryModule.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java > f317b68638ce65ca204d0a9d93e9eb299339d2ec > > src/main/java/org/apache/aurora/scheduler/http/api/security/ModuleParser.java > 63ab9550e32e41632cc4f2aa32a63c725d93bf7e > src/main/java/org/apache/aurora/scheduler/thrift/auth/ThriftAuthModule.java > 3ccee66e655ef3a27681c7aa4b0a2ffd77fac51e > src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java > d9f7b2095aa4c5306e57ec6f421eadba82e18ede > src/test/java/org/apache/aurora/scheduler/app/ModulesTest.java > 01137e9e6862f64382de83a07af197d1b9e2f09d > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java > 49411289299bfc230e8c6e0ce6fa96e619f57524 > src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java > 738c8b644287b93372f3227832a9d92b95dc498a > src/test/java/org/apache/aurora/scheduler/http/QuitCallbackTest.java > e50bdc511c597349e791d2c6dae356fc2f0e69fc > src/test/java/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java > cb33b0371f8ac45e0fd7437a88160e7c5b5629ff > src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java > 7e1d13b00a1422993ac0cf3fe55082d6ae3204dd > src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java > 3e9ef105c550b8aa6620aad8fb37e3f2e889da42 > > Diff: https://reviews.apache.org/r/38331/diff/ > > > Testing > ------- > > unit tests > end-to-end tests > ./gradlew run > > > Thanks, > > Bill Farner > >
