Re: Review Request 39629: Remove ChainedPathDetector and root argument from the observer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39629/#review104496 --- Master (bcb4774) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Oct. 29, 2015, 10:06 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39629/ > --- > > (Updated Oct. 29, 2015, 10:06 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-1338 > https://issues.apache.org/jira/browse/AURORA-1338 > > > Repository: aurora > > > Description > --- > > Remove ChainedPathDetector and root argument from the observer. > > > Diffs > - > > NEWS 40fe13985a7f8d69252edac37187f1993a05c47c > examples/vagrant/upstart/aurora-thermos-observer.conf > d7d649dc8aaacd98772183fa1429ef8fc84fa20a > src/main/python/apache/aurora/tools/thermos_observer.py > 82de0a14b3de2bf3d1b7282fe7dc9fc185d7 > > Diff: https://reviews.apache.org/r/39629/diff/ > > > Testing > --- > > e2e tests passed > > > Thanks, > > Zameer Manji > >
Re: Review Request 39629: Remove ChainedPathDetector and root argument from the observer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39629/ --- (Updated Oct. 29, 2015, 3:06 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Changes --- Fix python style. Bugs: AURORA-1338 https://issues.apache.org/jira/browse/AURORA-1338 Repository: aurora Description --- Remove ChainedPathDetector and root argument from the observer. Diffs (updated) - NEWS 40fe13985a7f8d69252edac37187f1993a05c47c examples/vagrant/upstart/aurora-thermos-observer.conf d7d649dc8aaacd98772183fa1429ef8fc84fa20a src/main/python/apache/aurora/tools/thermos_observer.py 82de0a14b3de2bf3d1b7282fe7dc9fc185d7 Diff: https://reviews.apache.org/r/39629/diff/ Testing --- e2e tests passed Thanks, Zameer Manji
Re: Review Request 39629: Remove ChainedPathDetector and root argument from the observer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39629/#review104479 --- Master (bcb4774) is red with this patch. ./build-support/jenkins/build.sh Using cached twitter.common.process-0.3.0.tar.gz Collecting twitter.common.log==0.3.0 (from twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) Using cached twitter.common.log-0.3.0.tar.gz Collecting twitter.common.util==0.3.0 (from twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) Using cached twitter.common.util-0.3.0.tar.gz Collecting twitter.common.collections==0.3.0 (from twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) Using cached twitter.common.collections-0.3.0.tar.gz Collecting smmap>=0.8.5 (from gitdb>=0.5.1->GitPython==0.3.2.RC1->twitter.checkstyle==0.1.0) Using cached smmap-0.9.0.tar.gz Collecting twitter.common.string==0.3.0 (from twitter.common.process==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) Using cached twitter.common.string-0.3.0.tar.gz Collecting twitter.common.options==0.3.0 (from twitter.common.log==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) Using cached twitter.common.options-0.3.0.tar.gz Collecting twitter.common.dirutil==0.3.0 (from twitter.common.log==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) Using cached twitter.common.dirutil-0.3.0.tar.gz Collecting twitter.common.contextutil==0.3.0 (from twitter.common.util==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) Using cached twitter.common.contextutil-0.3.0.tar.gz Collecting twitter.common.lang==0.3.0 (from twitter.common.collections==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) Using cached twitter.common.lang-0.3.0.tar.gz Installing collected packages: pyflakes, pep8, smmap, gitdb, GitPython, twitter.common.lang, twitter.common.string, twitter.common.process, twitter.common.options, twitter.common.dirutil, twitter.common.log, twitter.common.contextutil, twitter.common.util, twitter.common.collections, twitter.common.app, twitter.checkstyle Running setup.py install for pyflakes Running setup.py install for pep8 Running setup.py install for smmap Running setup.py install for gitdb Running setup.py install for GitPython Running setup.py install for twitter.common.lang Running setup.py install for twitter.common.string Running setup.py install for twitter.common.process Running setup.py install for twitter.common.options Running setup.py install for twitter.common.dirutil Running setup.py install for twitter.common.log Running setup.py install for twitter.common.contextutil Running setup.py install for twitter.common.util Running setup.py install for twitter.common.collections Running setup.py install for twitter.common.app Running setup.py install for twitter.checkstyle Successfully installed GitPython-0.3.2rc1 gitdb-0.6.4 pep8-1.4.5 pyflakes-0.7.2 smmap-0.9.0 twitter.checkstyle-0.1.0 twitter.common.app-0.3.0 twitter.common.collections-0.3.0 twitter.common.contextutil-0.3.0 twitter.common.dirutil-0.3.0 twitter.common.lang-0.3.0 twitter.common.log-0.3.0 twitter.common.options-0.3.0 twitter.common.process-0.3.0 twitter.common.string-0.3.0 twitter.common.util-0.3.0 F401:ERROR src/main/python/apache/aurora/tools/thermos_observer.py:025 'DEFAULT_CHECKPOINT_ROOT' imported but unused |from apache.thermos.common.constants import DEFAULT_CHECKPOINT_ROOT I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Oct. 27, 2015, 11:38 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39629/ > --- > > (Updated Oct. 27, 2015, 11:38 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-1338 > https://issues.apache.org/jira/browse/AURORA-1338 > > > Repository: aurora > > > Description > --- > > Remove ChainedPathDetector and root argument from the observer. > > > Diffs > - > > NEWS 40fe13985a7f8d69252edac37187f1993a05c47c > examples/vagrant/upstart/aurora-thermos-observer.conf > d7d649dc8aaacd98772183fa1429ef8fc84fa20a > src/main/python/apache/aurora/tools/thermos_observer.py > 82de0a14b3de2bf3d1b7282fe7dc9fc185d7 > > Diff: https://reviews.apache.org/r/39629/diff/ > > > Testing > --- > > e2e tests passed > > > Thanks, > > Zameer Manji > >
Re: Review Request 39629: Remove ChainedPathDetector and root argument from the observer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39629/#review104475 --- @ReviewBot retry - Zameer Manji On Oct. 27, 2015, 4:38 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39629/ > --- > > (Updated Oct. 27, 2015, 4:38 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-1338 > https://issues.apache.org/jira/browse/AURORA-1338 > > > Repository: aurora > > > Description > --- > > Remove ChainedPathDetector and root argument from the observer. > > > Diffs > - > > NEWS 40fe13985a7f8d69252edac37187f1993a05c47c > examples/vagrant/upstart/aurora-thermos-observer.conf > d7d649dc8aaacd98772183fa1429ef8fc84fa20a > src/main/python/apache/aurora/tools/thermos_observer.py > 82de0a14b3de2bf3d1b7282fe7dc9fc185d7 > > Diff: https://reviews.apache.org/r/39629/diff/ > > > Testing > --- > > e2e tests passed > > > Thanks, > > Zameer Manji > >
Re: Review Request 39629: Remove ChainedPathDetector and root argument from the observer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39629/#review104242 --- Master (c20346c) is red with this patch. ./build-support/jenkins/build.sh :processJmhResources UP-TO-DATE :jmhClasses :checkstyleJmh :jsHint :checkstyleMain :compileTestJavaNote: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. :processTestResources :testClasses :checkstyleTest :findbugsJmh :findbugsMain :findbugsTest :licenseJmh UP-TO-DATE :licenseMain UP-TO-DATE :licenseTest UP-TO-DATE :license UP-TO-DATE :pmdMain :test :jacocoTestReport Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html :analyzeReport Instruction coverage is 0.8878761574074074, but must be greater than 0.89 Branch coverage is 0.8137074517019319, but must be greater than 0.835 :analyzeReport FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':analyzeReport'. > Test coverage missing for > org/apache/aurora/GuavaUtils$LifecycleShutdownListener * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 6 mins 22.075 secs I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Oct. 27, 2015, 11:38 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39629/ > --- > > (Updated Oct. 27, 2015, 11:38 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-1338 > https://issues.apache.org/jira/browse/AURORA-1338 > > > Repository: aurora > > > Description > --- > > Remove ChainedPathDetector and root argument from the observer. > > > Diffs > - > > NEWS 40fe13985a7f8d69252edac37187f1993a05c47c > examples/vagrant/upstart/aurora-thermos-observer.conf > d7d649dc8aaacd98772183fa1429ef8fc84fa20a > src/main/python/apache/aurora/tools/thermos_observer.py > 82de0a14b3de2bf3d1b7282fe7dc9fc185d7 > > Diff: https://reviews.apache.org/r/39629/diff/ > > > Testing > --- > > e2e tests passed > > > Thanks, > > Zameer Manji > >
Re: Review Request 39629: Remove ChainedPathDetector and root argument from the observer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39629/#review104235 --- @ReviewBot retry - Zameer Manji On Oct. 27, 2015, 4:38 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39629/ > --- > > (Updated Oct. 27, 2015, 4:38 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-1338 > https://issues.apache.org/jira/browse/AURORA-1338 > > > Repository: aurora > > > Description > --- > > Remove ChainedPathDetector and root argument from the observer. > > > Diffs > - > > NEWS 40fe13985a7f8d69252edac37187f1993a05c47c > examples/vagrant/upstart/aurora-thermos-observer.conf > d7d649dc8aaacd98772183fa1429ef8fc84fa20a > src/main/python/apache/aurora/tools/thermos_observer.py > 82de0a14b3de2bf3d1b7282fe7dc9fc185d7 > > Diff: https://reviews.apache.org/r/39629/diff/ > > > Testing > --- > > e2e tests passed > > > Thanks, > > Zameer Manji > >
Re: Review Request 39629: Remove ChainedPathDetector and root argument from the observer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39629/#review104234 --- Master (c20346c) is red with this patch. ./build-support/jenkins/build.sh :processJmhResources UP-TO-DATE :jmhClasses :checkstyleJmh :jsHint :checkstyleMain :compileTestJavaNote: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. :processTestResources :testClasses :checkstyleTest :findbugsJmh :findbugsMain :findbugsTest :licenseJmh UP-TO-DATE :licenseMain UP-TO-DATE :licenseTest UP-TO-DATE :license UP-TO-DATE :pmdMain :test :jacocoTestReport Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html :analyzeReport Instruction coverage is 0.8878761574074074, but must be greater than 0.89 Branch coverage is 0.8137074517019319, but must be greater than 0.835 :analyzeReport FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':analyzeReport'. > Test coverage missing for > org/apache/aurora/GuavaUtils$LifecycleShutdownListener * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 5 mins 0.285 secs I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Oct. 27, 2015, 11:38 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39629/ > --- > > (Updated Oct. 27, 2015, 11:38 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-1338 > https://issues.apache.org/jira/browse/AURORA-1338 > > > Repository: aurora > > > Description > --- > > Remove ChainedPathDetector and root argument from the observer. > > > Diffs > - > > NEWS 40fe13985a7f8d69252edac37187f1993a05c47c > examples/vagrant/upstart/aurora-thermos-observer.conf > d7d649dc8aaacd98772183fa1429ef8fc84fa20a > src/main/python/apache/aurora/tools/thermos_observer.py > 82de0a14b3de2bf3d1b7282fe7dc9fc185d7 > > Diff: https://reviews.apache.org/r/39629/diff/ > > > Testing > --- > > e2e tests passed > > > Thanks, > > Zameer Manji > >
Re: Review Request 39629: Remove ChainedPathDetector and root argument from the observer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39629/ --- (Updated Oct. 27, 2015, 4:38 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Changes --- Rebase on master. Bugs: AURORA-1338 https://issues.apache.org/jira/browse/AURORA-1338 Repository: aurora Description --- Remove ChainedPathDetector and root argument from the observer. Diffs (updated) - NEWS 40fe13985a7f8d69252edac37187f1993a05c47c examples/vagrant/upstart/aurora-thermos-observer.conf d7d649dc8aaacd98772183fa1429ef8fc84fa20a src/main/python/apache/aurora/tools/thermos_observer.py 82de0a14b3de2bf3d1b7282fe7dc9fc185d7 Diff: https://reviews.apache.org/r/39629/diff/ Testing --- e2e tests passed Thanks, Zameer Manji
Re: Review Request 39629: Remove ChainedPathDetector and root argument from the observer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39629/#review104057 --- Ship it! Ship It! - Maxim Khutornenko On Oct. 25, 2015, 4:33 a.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39629/ > --- > > (Updated Oct. 25, 2015, 4:33 a.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-1338 > https://issues.apache.org/jira/browse/AURORA-1338 > > > Repository: aurora > > > Description > --- > > Remove ChainedPathDetector and root argument from the observer. > > > Diffs > - > > NEWS 7622f9db706c1764876f4174855343414dc59366 > examples/vagrant/upstart/aurora-thermos-observer.conf > d7d649dc8aaacd98772183fa1429ef8fc84fa20a > src/main/python/apache/aurora/tools/thermos_observer.py > 82de0a14b3de2bf3d1b7282fe7dc9fc185d7 > > Diff: https://reviews.apache.org/r/39629/diff/ > > > Testing > --- > > e2e tests passed > > > Thanks, > > Zameer Manji > >
Re: Review Request 39629: Remove ChainedPathDetector and root argument from the observer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39629/#review103969 --- Ship it! Ship It! - Bill Farner On Oct. 24, 2015, 9:33 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39629/ > --- > > (Updated Oct. 24, 2015, 9:33 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-1338 > https://issues.apache.org/jira/browse/AURORA-1338 > > > Repository: aurora > > > Description > --- > > Remove ChainedPathDetector and root argument from the observer. > > > Diffs > - > > NEWS 7622f9db706c1764876f4174855343414dc59366 > examples/vagrant/upstart/aurora-thermos-observer.conf > d7d649dc8aaacd98772183fa1429ef8fc84fa20a > src/main/python/apache/aurora/tools/thermos_observer.py > 82de0a14b3de2bf3d1b7282fe7dc9fc185d7 > > Diff: https://reviews.apache.org/r/39629/diff/ > > > Testing > --- > > e2e tests passed > > > Thanks, > > Zameer Manji > >
Re: Review Request 39629: Remove ChainedPathDetector and root argument from the observer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39629/#review103936 --- This patch does not apply cleanly on master (84b9d4a), do you need to rebase? I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Oct. 25, 2015, 4:33 a.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39629/ > --- > > (Updated Oct. 25, 2015, 4:33 a.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-1338 > https://issues.apache.org/jira/browse/AURORA-1338 > > > Repository: aurora > > > Description > --- > > Remove ChainedPathDetector and root argument from the observer. > > > Diffs > - > > NEWS 7622f9db706c1764876f4174855343414dc59366 > examples/vagrant/upstart/aurora-thermos-observer.conf > d7d649dc8aaacd98772183fa1429ef8fc84fa20a > src/main/python/apache/aurora/tools/thermos_observer.py > 82de0a14b3de2bf3d1b7282fe7dc9fc185d7 > > Diff: https://reviews.apache.org/r/39629/diff/ > > > Testing > --- > > e2e tests passed > > > Thanks, > > Zameer Manji > >
Review Request 39629: Remove ChainedPathDetector and root argument from the observer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39629/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-1338 https://issues.apache.org/jira/browse/AURORA-1338 Repository: aurora Description --- Remove ChainedPathDetector and root argument from the observer. Diffs - NEWS 7622f9db706c1764876f4174855343414dc59366 examples/vagrant/upstart/aurora-thermos-observer.conf d7d649dc8aaacd98772183fa1429ef8fc84fa20a src/main/python/apache/aurora/tools/thermos_observer.py 82de0a14b3de2bf3d1b7282fe7dc9fc185d7 Diff: https://reviews.apache.org/r/39629/diff/ Testing --- e2e tests passed Thanks, Zameer Manji