Re: Review Request 39631: Add listener to trigger scheduler shutdown on service failure.

2015-10-26 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39631/
---

(Updated Oct. 26, 2015, 2:02 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
---

Added newlines.


Bugs: AURORA-1511
https://issues.apache.org/jira/browse/AURORA-1511


Repository: aurora


Description
---

Add listener to trigger scheduler shutdown on service failure.


Diffs (updated)
-

  config/legacy_untested_classes.txt 0f1e6be56b74734a48b59729957baf65b94079df 
  src/main/java/org/apache/aurora/GuavaUtils.java 
e3e90e3e43744463a2f00552f0041d0d1945bd57 
  src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
7b110b9698440b7e09b777afe430944845530eee 

Diff: https://reviews.apache.org/r/39631/diff/


Testing
---

./gradlew build -Pq


Thanks,

Zameer Manji

Re: Review Request 39631: Add listener to trigger scheduler shutdown on service failure.

2015-10-26 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39631/#review104056
---

Ship it!



src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java (line 74)


Add newline here and below.


- Maxim Khutornenko


On Oct. 25, 2015, 8:44 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39631/
> ---
> 
> (Updated Oct. 25, 2015, 8:44 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-1511
> https://issues.apache.org/jira/browse/AURORA-1511
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add listener to trigger scheduler shutdown on service failure.
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt 0f1e6be56b74734a48b59729957baf65b94079df 
>   src/main/java/org/apache/aurora/GuavaUtils.java 
> e3e90e3e43744463a2f00552f0041d0d1945bd57 
>   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
> 7b110b9698440b7e09b777afe430944845530eee 
> 
> Diff: https://reviews.apache.org/r/39631/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 39631: Add listener to trigger scheduler shutdown on service failure.

2015-10-25 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39631/#review103967
---


Master (7c25ef9) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 25, 2015, 8:44 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39631/
> ---
> 
> (Updated Oct. 25, 2015, 8:44 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-1511
> https://issues.apache.org/jira/browse/AURORA-1511
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add listener to trigger scheduler shutdown on service failure.
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt 0f1e6be56b74734a48b59729957baf65b94079df 
>   src/main/java/org/apache/aurora/GuavaUtils.java 
> e3e90e3e43744463a2f00552f0041d0d1945bd57 
>   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
> 7b110b9698440b7e09b777afe430944845530eee 
> 
> Diff: https://reviews.apache.org/r/39631/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 39631: Add listener to trigger scheduler shutdown on service failure.

2015-10-25 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39631/
---

(Updated Oct. 25, 2015, 1:44 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
---

Blacklist listener from coverage checks.


Bugs: AURORA-1511
https://issues.apache.org/jira/browse/AURORA-1511


Repository: aurora


Description
---

Add listener to trigger scheduler shutdown on service failure.


Diffs (updated)
-

  config/legacy_untested_classes.txt 0f1e6be56b74734a48b59729957baf65b94079df 
  src/main/java/org/apache/aurora/GuavaUtils.java 
e3e90e3e43744463a2f00552f0041d0d1945bd57 
  src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
7b110b9698440b7e09b777afe430944845530eee 

Diff: https://reviews.apache.org/r/39631/diff/


Testing
---

./gradlew build -Pq


Thanks,

Zameer Manji

Re: Review Request 39631: Add listener to trigger scheduler shutdown on service failure.

2015-10-25 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39631/#review103962
---

Ship it!


LGTM once build is green.

- Bill Farner


On Oct. 24, 2015, 11:43 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39631/
> ---
> 
> (Updated Oct. 24, 2015, 11:43 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-1511
> https://issues.apache.org/jira/browse/AURORA-1511
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add listener to trigger scheduler shutdown on service failure.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/GuavaUtils.java 
> e3e90e3e43744463a2f00552f0041d0d1945bd57 
>   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
> 7b110b9698440b7e09b777afe430944845530eee 
> 
> Diff: https://reviews.apache.org/r/39631/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 39631: Add listener to trigger scheduler shutdown on service failure.

2015-10-24 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39631/#review103943
---


Master (84b9d4a) is red with this patch.
  ./build-support/jenkins/build.sh


:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain
:compileTestJavaNote: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:processTestResources
:testClasses
:checkstyleTest
:findbugsJmh
:findbugsMain
:findbugsTest
:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdMain
:test
:jacocoTestReport
Coverage report generated: 
file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:analyzeReport
Instruction coverage is 0.8880757462995121, but must be greater than 0.89
Branch coverage is 0.8132474701011959, but must be greater than 0.835
:analyzeReport FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':analyzeReport'.
> Test coverage missing for 
> org/apache/aurora/GuavaUtils$LifecycleShutdownListener

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 5 mins 1.461 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 25, 2015, 6:43 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39631/
> ---
> 
> (Updated Oct. 25, 2015, 6:43 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-1511
> https://issues.apache.org/jira/browse/AURORA-1511
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add listener to trigger scheduler shutdown on service failure.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/GuavaUtils.java 
> e3e90e3e43744463a2f00552f0041d0d1945bd57 
>   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
> 7b110b9698440b7e09b777afe430944845530eee 
> 
> Diff: https://reviews.apache.org/r/39631/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Review Request 39631: Add listener to trigger scheduler shutdown on service failure.

2015-10-24 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39631/
---

Review request for Aurora, Maxim Khutornenko and Bill Farner.


Bugs: AURORA-1511
https://issues.apache.org/jira/browse/AURORA-1511


Repository: aurora


Description
---

Add listener to trigger scheduler shutdown on service failure.


Diffs
-

  src/main/java/org/apache/aurora/GuavaUtils.java 
e3e90e3e43744463a2f00552f0041d0d1945bd57 
  src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
7b110b9698440b7e09b777afe430944845530eee 

Diff: https://reviews.apache.org/r/39631/diff/


Testing
---

./gradlew build -Pq


Thanks,

Zameer Manji