Re: Review Request 40220: Modernize the pex venv script.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40220/ --- (Updated Nov. 16, 2015, 1:12 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Repository: aurora Description (updated) --- This converts from grabbing the old Twitter python pex to grabbing modern pex to match the version specified in 3rdparty to help keep the pex venv up to date with the codebase dependencies. Diffs - build-support/pex 54e31f11f152cada3809ebd7b2cdec1d2ba12ac9 Diff: https://reviews.apache.org/r/40220/diff/ Testing --- Locally ran this 2x and observed both the proper version (1.1.0) and proper use of the cached venv in the second run: `git clean -fdx build-support && ./build-support/pex --version` Thanks, John Sirois
Re: Review Request 40220: Modernize the pex venv script.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40220/#review106419 --- Ship it! Ship It! - Joshua Cohen On Nov. 12, 2015, 8:35 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40220/ > --- > > (Updated Nov. 12, 2015, 8:35 a.m.) > > > Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. > > > Repository: aurora > > > Description > --- > > This converts from grabbing the old Twitter python pex to grabbing > modern pex to match the version specified in 3rdparty to help keep the > pex venv up to date with the codebase dependencies. > > build-support/pex | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > > Diffs > - > > build-support/pex 54e31f11f152cada3809ebd7b2cdec1d2ba12ac9 > > Diff: https://reviews.apache.org/r/40220/diff/ > > > Testing > --- > > Locally ran this 2x and observed both the proper version (1.1.0) and > proper use of the cached venv in the second run: > `git clean -fdx build-support && ./build-support/pex --version` > > > Thanks, > > John Sirois > >
Re: Review Request 40220: Modernize the pex venv script.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40220/#review106267 --- Ship it! Ship It! - Bill Farner On Nov. 12, 2015, 12:35 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40220/ > --- > > (Updated Nov. 12, 2015, 12:35 a.m.) > > > Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. > > > Repository: aurora > > > Description > --- > > This converts from grabbing the old Twitter python pex to grabbing > modern pex to match the version specified in 3rdparty to help keep the > pex venv up to date with the codebase dependencies. > > build-support/pex | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > > Diffs > - > > build-support/pex 54e31f11f152cada3809ebd7b2cdec1d2ba12ac9 > > Diff: https://reviews.apache.org/r/40220/diff/ > > > Testing > --- > > Locally ran this 2x and observed both the proper version (1.1.0) and > proper use of the cached venv in the second run: > `git clean -fdx build-support && ./build-support/pex --version` > > > Thanks, > > John Sirois > >
Re: Review Request 40220: Modernize the pex venv script.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40220/#review106211 --- Ship it! Master (48aedae) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 12, 2015, 8:35 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40220/ > --- > > (Updated Nov. 12, 2015, 8:35 a.m.) > > > Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. > > > Repository: aurora > > > Description > --- > > This converts from grabbing the old Twitter python pex to grabbing > modern pex to match the version specified in 3rdparty to help keep the > pex venv up to date with the codebase dependencies. > > build-support/pex | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > > Diffs > - > > build-support/pex 54e31f11f152cada3809ebd7b2cdec1d2ba12ac9 > > Diff: https://reviews.apache.org/r/40220/diff/ > > > Testing > --- > > Locally ran this 2x and observed both the proper version (1.1.0) and > proper use of the cached venv in the second run: > `git clean -fdx build-support && ./build-support/pex --version` > > > Thanks, > > John Sirois > >
Re: Review Request 40220: Modernize the pex venv script.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40220/#review106210 --- Sorry about that - diff 2 is what you want to look at: https://reviews.apache.org/r/40220/diff/2#index_header - John Sirois On Nov. 12, 2015, 1:35 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40220/ > --- > > (Updated Nov. 12, 2015, 1:35 a.m.) > > > Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. > > > Repository: aurora > > > Description > --- > > This converts from grabbing the old Twitter python pex to grabbing > modern pex to match the version specified in 3rdparty to help keep the > pex venv up to date with the codebase dependencies. > > build-support/pex | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > > Diffs > - > > build-support/pex 54e31f11f152cada3809ebd7b2cdec1d2ba12ac9 > > Diff: https://reviews.apache.org/r/40220/diff/ > > > Testing > --- > > Locally ran this 2x and observed both the proper version (1.1.0) and > proper use of the cached venv in the second run: > `git clean -fdx build-support && ./build-support/pex --version` > > > Thanks, > > John Sirois > >
Re: Review Request 40220: Modernize the pex venv script.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40220/ --- (Updated Nov. 12, 2015, 1:35 a.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Changes --- Modernize the pex venv script. This converts from grabbing the old `twitter.common.python` pex to grabbing modern pex to match the version specified in 3rdparty to help keep the pex venv up to date with the codebase dependencies. build-support/pex | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) Repository: aurora Description --- This converts from grabbing the old Twitter python pex to grabbing modern pex to match the version specified in 3rdparty to help keep the pex venv up to date with the codebase dependencies. build-support/pex | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Diffs (updated) - build-support/pex 54e31f11f152cada3809ebd7b2cdec1d2ba12ac9 Diff: https://reviews.apache.org/r/40220/diff/ Testing --- Locally ran this 2x and observed both the proper version (1.1.0) and proper use of the cached venv in the second run: `git clean -fdx build-support && ./build-support/pex --version` Thanks, John Sirois
Re: Review Request 40220: Modernize the pex venv script.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40220/#review106209 --- This patch does not apply cleanly on master (48aedae), do you need to rebase? I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 12, 2015, 8:25 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40220/ > --- > > (Updated Nov. 12, 2015, 8:25 a.m.) > > > Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. > > > Repository: aurora > > > Description > --- > > This converts from grabbing the old Twitter python pex to grabbing > modern pex to match the version specified in 3rdparty to help keep the > pex venv up to date with the codebase dependencies. > > build-support/pex | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > > Diffs > - > > build-support/pex 54e31f11f152cada3809ebd7b2cdec1d2ba12ac9 > > Diff: https://reviews.apache.org/r/40220/diff/ > > > Testing > --- > > Locally ran this 2x and observed both the proper version (1.1.0) and > proper use of the cached venv in the second run: > `git clean -fdx build-support && ./build-support/pex --version` > > > Thanks, > > John Sirois > >
Review Request 40220: Modernize the pex venv script.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40220/ --- Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Repository: aurora Description --- This converts from grabbing the old Twitter python pex to grabbing modern pex to match the version specified in 3rdparty to help keep the pex venv up to date with the codebase dependencies. build-support/pex | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Diffs - build-support/pex 54e31f11f152cada3809ebd7b2cdec1d2ba12ac9 Diff: https://reviews.apache.org/r/40220/diff/ Testing --- Locally ran this 2x and observed both the proper version (1.1.0) and proper use of the cached venv in the second run: `git clean -fdx build-support && ./build-support/pex --version` Thanks, John Sirois