Re: Review Request 41368: Remove the client-side updater.

2015-12-16 Thread Bill Farner


> On Dec. 15, 2015, 8:45 p.m., Maxim Khutornenko wrote:
> > Please, cleanup docs as well. There are quite a few "aurora job update" 
> > mentions.

Thanks for catching that.  Done.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41368/#review110616
---


On Dec. 14, 2015, 2:36 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41368/
> ---
> 
> (Updated Dec. 14, 2015, 2:36 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-785
> https://issues.apache.org/jira/browse/AURORA-785
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> ```
>  NEWS   |   4 +
>  docs/hooks.md  |   2 -
>  .../python/apache/aurora/client/api/__init__.py|  24 -
>  .../python/apache/aurora/client/api/updater.py | 720 -
>  src/main/python/apache/aurora/client/base.py   |  19 -
>  src/main/python/apache/aurora/client/cli/jobs.py   | 115 ---
>  .../apache/aurora/client/hooks/hooked_api.py   |  14 -
>  src/test/python/apache/aurora/client/api/BUILD |  12 -
>  .../apache/aurora/client/api/test_updater.py   | 899 
> -
>  src/test/python/apache/aurora/client/cli/BUILD |  13 -
>  .../apache/aurora/client/cli/test_cancel_update.py |  62 --
>  .../python/apache/aurora/client/cli/test_update.py | 528 
>  .../apache/aurora/client/hooks/test_hooked_api.py  |   5 +-
>  .../aurora/client/hooks/test_non_hooked_api.py |  15 +-
>  src/test/python/apache/aurora/client/test_base.py  |   8 -
>  .../sh/org/apache/aurora/e2e/test_end_to_end.sh|   8 -
>  16 files changed, 11 insertions(+), 2437 deletions(-)
> ```
> 
> 
> Diffs
> -
> 
>   NEWS 99531a3ffd98acb08b9bee9c44a1553fba4b56a6 
>   docs/hooks.md 63dbdb91d014b65f129cd6b28bdb4c563f00ead3 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 1514394829cfd8d76d6db5cdfd7c6593f1193b29 
>   src/main/python/apache/aurora/client/api/updater.py 
> acbce21e991981a2e85c1a00a68e57d88c5509bb 
>   src/main/python/apache/aurora/client/base.py 
> 91c276b09500d4eb81368f0b4bd482f0177b5e53 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 46948497f59c9c4d91fdefd8038cff138b9aeb0f 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> 7fc0b7103e8968af8a9288b698829f31c00e6b32 
>   src/test/python/apache/aurora/client/api/BUILD 
> 2756912af8b0716417efa992201bf72ca736a653 
>   src/test/python/apache/aurora/client/api/test_updater.py 
> 5f54d22401a5eec0027b156ebaf50114221da8bd 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 1b14e8c299360f236412c8d9b5e2e143f755f4e0 
>   src/test/python/apache/aurora/client/cli/test_cancel_update.py 
> d4fc049ebef5745b7a749a74005be962c63ae2ea 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 787396e8da298fab736d4aa8d2b436a68ebee27b 
>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py 
> 4d8ebabb3a1dcf26dd491b3bb73c0057d6a8ac97 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 
> 78dffa5bbf065dcae61ae672c928f658b7400522 
>   src/test/python/apache/aurora/client/test_base.py 
> 8c880081620a8360bb2b7f0d854c7708c14cae7a 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> d7c61e26428c05d6b2f212e2bb092af38ef6aeec 
> 
> Diff: https://reviews.apache.org/r/41368/diff/
> 
> 
> Testing
> ---
> 
> Test suite + end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>



Re: Review Request 41368: Remove the client-side updater.

2015-12-16 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41368/
---

(Updated Dec. 16, 2015, 12:20 p.m.)


Review request for Aurora, Maxim Khutornenko and Zameer Manji.


Bugs: AURORA-785
https://issues.apache.org/jira/browse/AURORA-785


Repository: aurora


Description (updated)
---

```
 NEWS   |   4 +
 docs/client-commands.md|  32 -
 docs/configuration-tutorial.md |   2 +-
 docs/hooks.md  |   2 -
 docs/tutorial.md   |   2 +-
 docs/user-guide.md |   2 +-
 .../python/apache/aurora/client/api/__init__.py|  24 -
 .../python/apache/aurora/client/api/updater.py | 720 -
 src/main/python/apache/aurora/client/base.py   |  19 -
 src/main/python/apache/aurora/client/cli/jobs.py   | 115 ---
 .../apache/aurora/client/hooks/hooked_api.py   |  14 -
 src/test/python/apache/aurora/client/api/BUILD |  12 -
 .../apache/aurora/client/api/test_updater.py   | 899 -
 src/test/python/apache/aurora/client/cli/BUILD |  13 -
 .../apache/aurora/client/cli/test_cancel_update.py |  62 --
 .../python/apache/aurora/client/cli/test_update.py | 528 
 .../apache/aurora/client/hooks/test_hooked_api.py  |   5 +-
 .../aurora/client/hooks/test_non_hooked_api.py |  15 +-
 src/test/python/apache/aurora/client/test_base.py  |   8 -
 .../sh/org/apache/aurora/e2e/test_end_to_end.sh|   8 -
 20 files changed, 14 insertions(+), 2472 deletions(-)
```


Diffs (updated)
-

  NEWS 99531a3ffd98acb08b9bee9c44a1553fba4b56a6 
  docs/client-commands.md 9977b492d25f0630ff39661097553113bbea6158 
  docs/configuration-tutorial.md e6658177361897433c7f38a75c4246dcb922d88c 
  docs/hooks.md 63dbdb91d014b65f129cd6b28bdb4c563f00ead3 
  docs/tutorial.md 812a5ccc6aa9acb06e139f2525cef10da5a2b1ad 
  docs/user-guide.md e608500499f46ea61d4a8607e4d1b2451f88996c 
  src/main/python/apache/aurora/client/api/__init__.py 
1514394829cfd8d76d6db5cdfd7c6593f1193b29 
  src/main/python/apache/aurora/client/api/updater.py 
acbce21e991981a2e85c1a00a68e57d88c5509bb 
  src/main/python/apache/aurora/client/base.py 
91c276b09500d4eb81368f0b4bd482f0177b5e53 
  src/main/python/apache/aurora/client/cli/jobs.py 
46948497f59c9c4d91fdefd8038cff138b9aeb0f 
  src/main/python/apache/aurora/client/hooks/hooked_api.py 
7fc0b7103e8968af8a9288b698829f31c00e6b32 
  src/test/python/apache/aurora/client/api/BUILD 
2756912af8b0716417efa992201bf72ca736a653 
  src/test/python/apache/aurora/client/api/test_updater.py 
5f54d22401a5eec0027b156ebaf50114221da8bd 
  src/test/python/apache/aurora/client/cli/BUILD 
1b14e8c299360f236412c8d9b5e2e143f755f4e0 
  src/test/python/apache/aurora/client/cli/test_cancel_update.py 
d4fc049ebef5745b7a749a74005be962c63ae2ea 
  src/test/python/apache/aurora/client/cli/test_update.py 
787396e8da298fab736d4aa8d2b436a68ebee27b 
  src/test/python/apache/aurora/client/hooks/test_hooked_api.py 
4d8ebabb3a1dcf26dd491b3bb73c0057d6a8ac97 
  src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 
78dffa5bbf065dcae61ae672c928f658b7400522 
  src/test/python/apache/aurora/client/test_base.py 
8c880081620a8360bb2b7f0d854c7708c14cae7a 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
d7c61e26428c05d6b2f212e2bb092af38ef6aeec 

Diff: https://reviews.apache.org/r/41368/diff/


Testing
---

Test suite + end-to-end tests


Thanks,

Bill Farner



Re: Review Request 41368: Remove the client-side updater.

2015-12-16 Thread John Sirois

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41368/#review110695
---

Ship it!


Master (fb8155d) is green with this patch.
  true

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- John Sirois


On Dec. 14, 2015, 10:36 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41368/
> ---
> 
> (Updated Dec. 14, 2015, 10:36 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-785
> https://issues.apache.org/jira/browse/AURORA-785
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> ```
>  NEWS   |   4 +
>  docs/hooks.md  |   2 -
>  .../python/apache/aurora/client/api/__init__.py|  24 -
>  .../python/apache/aurora/client/api/updater.py | 720 -
>  src/main/python/apache/aurora/client/base.py   |  19 -
>  src/main/python/apache/aurora/client/cli/jobs.py   | 115 ---
>  .../apache/aurora/client/hooks/hooked_api.py   |  14 -
>  src/test/python/apache/aurora/client/api/BUILD |  12 -
>  .../apache/aurora/client/api/test_updater.py   | 899 
> -
>  src/test/python/apache/aurora/client/cli/BUILD |  13 -
>  .../apache/aurora/client/cli/test_cancel_update.py |  62 --
>  .../python/apache/aurora/client/cli/test_update.py | 528 
>  .../apache/aurora/client/hooks/test_hooked_api.py  |   5 +-
>  .../aurora/client/hooks/test_non_hooked_api.py |  15 +-
>  src/test/python/apache/aurora/client/test_base.py  |   8 -
>  .../sh/org/apache/aurora/e2e/test_end_to_end.sh|   8 -
>  16 files changed, 11 insertions(+), 2437 deletions(-)
> ```
> 
> 
> Diffs
> -
> 
>   NEWS 99531a3ffd98acb08b9bee9c44a1553fba4b56a6 
>   docs/hooks.md 63dbdb91d014b65f129cd6b28bdb4c563f00ead3 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 1514394829cfd8d76d6db5cdfd7c6593f1193b29 
>   src/main/python/apache/aurora/client/api/updater.py 
> acbce21e991981a2e85c1a00a68e57d88c5509bb 
>   src/main/python/apache/aurora/client/base.py 
> 91c276b09500d4eb81368f0b4bd482f0177b5e53 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 46948497f59c9c4d91fdefd8038cff138b9aeb0f 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> 7fc0b7103e8968af8a9288b698829f31c00e6b32 
>   src/test/python/apache/aurora/client/api/BUILD 
> 2756912af8b0716417efa992201bf72ca736a653 
>   src/test/python/apache/aurora/client/api/test_updater.py 
> 5f54d22401a5eec0027b156ebaf50114221da8bd 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 1b14e8c299360f236412c8d9b5e2e143f755f4e0 
>   src/test/python/apache/aurora/client/cli/test_cancel_update.py 
> d4fc049ebef5745b7a749a74005be962c63ae2ea 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 787396e8da298fab736d4aa8d2b436a68ebee27b 
>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py 
> 4d8ebabb3a1dcf26dd491b3bb73c0057d6a8ac97 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 
> 78dffa5bbf065dcae61ae672c928f658b7400522 
>   src/test/python/apache/aurora/client/test_base.py 
> 8c880081620a8360bb2b7f0d854c7708c14cae7a 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> d7c61e26428c05d6b2f212e2bb092af38ef6aeec 
> 
> Diff: https://reviews.apache.org/r/41368/diff/
> 
> 
> Testing
> ---
> 
> Test suite + end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>



Re: Review Request 41368: Remove the client-side updater.

2015-12-16 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41368/#review110719
---

Ship it!


Awesome!

- Zameer Manji


On Dec. 14, 2015, 2:36 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41368/
> ---
> 
> (Updated Dec. 14, 2015, 2:36 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-785
> https://issues.apache.org/jira/browse/AURORA-785
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> ```
>  NEWS   |   4 +
>  docs/hooks.md  |   2 -
>  .../python/apache/aurora/client/api/__init__.py|  24 -
>  .../python/apache/aurora/client/api/updater.py | 720 -
>  src/main/python/apache/aurora/client/base.py   |  19 -
>  src/main/python/apache/aurora/client/cli/jobs.py   | 115 ---
>  .../apache/aurora/client/hooks/hooked_api.py   |  14 -
>  src/test/python/apache/aurora/client/api/BUILD |  12 -
>  .../apache/aurora/client/api/test_updater.py   | 899 
> -
>  src/test/python/apache/aurora/client/cli/BUILD |  13 -
>  .../apache/aurora/client/cli/test_cancel_update.py |  62 --
>  .../python/apache/aurora/client/cli/test_update.py | 528 
>  .../apache/aurora/client/hooks/test_hooked_api.py  |   5 +-
>  .../aurora/client/hooks/test_non_hooked_api.py |  15 +-
>  src/test/python/apache/aurora/client/test_base.py  |   8 -
>  .../sh/org/apache/aurora/e2e/test_end_to_end.sh|   8 -
>  16 files changed, 11 insertions(+), 2437 deletions(-)
> ```
> 
> 
> Diffs
> -
> 
>   NEWS 99531a3ffd98acb08b9bee9c44a1553fba4b56a6 
>   docs/hooks.md 63dbdb91d014b65f129cd6b28bdb4c563f00ead3 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 1514394829cfd8d76d6db5cdfd7c6593f1193b29 
>   src/main/python/apache/aurora/client/api/updater.py 
> acbce21e991981a2e85c1a00a68e57d88c5509bb 
>   src/main/python/apache/aurora/client/base.py 
> 91c276b09500d4eb81368f0b4bd482f0177b5e53 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 46948497f59c9c4d91fdefd8038cff138b9aeb0f 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> 7fc0b7103e8968af8a9288b698829f31c00e6b32 
>   src/test/python/apache/aurora/client/api/BUILD 
> 2756912af8b0716417efa992201bf72ca736a653 
>   src/test/python/apache/aurora/client/api/test_updater.py 
> 5f54d22401a5eec0027b156ebaf50114221da8bd 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 1b14e8c299360f236412c8d9b5e2e143f755f4e0 
>   src/test/python/apache/aurora/client/cli/test_cancel_update.py 
> d4fc049ebef5745b7a749a74005be962c63ae2ea 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 787396e8da298fab736d4aa8d2b436a68ebee27b 
>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py 
> 4d8ebabb3a1dcf26dd491b3bb73c0057d6a8ac97 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 
> 78dffa5bbf065dcae61ae672c928f658b7400522 
>   src/test/python/apache/aurora/client/test_base.py 
> 8c880081620a8360bb2b7f0d854c7708c14cae7a 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> d7c61e26428c05d6b2f212e2bb092af38ef6aeec 
> 
> Diff: https://reviews.apache.org/r/41368/diff/
> 
> 
> Testing
> ---
> 
> Test suite + end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>



Re: Review Request 41368: Remove the client-side updater.

2015-12-16 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41368/#review110717
---

Ship it!


Master (fb8155d) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Dec. 14, 2015, 10:36 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41368/
> ---
> 
> (Updated Dec. 14, 2015, 10:36 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-785
> https://issues.apache.org/jira/browse/AURORA-785
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> ```
>  NEWS   |   4 +
>  docs/hooks.md  |   2 -
>  .../python/apache/aurora/client/api/__init__.py|  24 -
>  .../python/apache/aurora/client/api/updater.py | 720 -
>  src/main/python/apache/aurora/client/base.py   |  19 -
>  src/main/python/apache/aurora/client/cli/jobs.py   | 115 ---
>  .../apache/aurora/client/hooks/hooked_api.py   |  14 -
>  src/test/python/apache/aurora/client/api/BUILD |  12 -
>  .../apache/aurora/client/api/test_updater.py   | 899 
> -
>  src/test/python/apache/aurora/client/cli/BUILD |  13 -
>  .../apache/aurora/client/cli/test_cancel_update.py |  62 --
>  .../python/apache/aurora/client/cli/test_update.py | 528 
>  .../apache/aurora/client/hooks/test_hooked_api.py  |   5 +-
>  .../aurora/client/hooks/test_non_hooked_api.py |  15 +-
>  src/test/python/apache/aurora/client/test_base.py  |   8 -
>  .../sh/org/apache/aurora/e2e/test_end_to_end.sh|   8 -
>  16 files changed, 11 insertions(+), 2437 deletions(-)
> ```
> 
> 
> Diffs
> -
> 
>   NEWS 99531a3ffd98acb08b9bee9c44a1553fba4b56a6 
>   docs/hooks.md 63dbdb91d014b65f129cd6b28bdb4c563f00ead3 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 1514394829cfd8d76d6db5cdfd7c6593f1193b29 
>   src/main/python/apache/aurora/client/api/updater.py 
> acbce21e991981a2e85c1a00a68e57d88c5509bb 
>   src/main/python/apache/aurora/client/base.py 
> 91c276b09500d4eb81368f0b4bd482f0177b5e53 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 46948497f59c9c4d91fdefd8038cff138b9aeb0f 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> 7fc0b7103e8968af8a9288b698829f31c00e6b32 
>   src/test/python/apache/aurora/client/api/BUILD 
> 2756912af8b0716417efa992201bf72ca736a653 
>   src/test/python/apache/aurora/client/api/test_updater.py 
> 5f54d22401a5eec0027b156ebaf50114221da8bd 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 1b14e8c299360f236412c8d9b5e2e143f755f4e0 
>   src/test/python/apache/aurora/client/cli/test_cancel_update.py 
> d4fc049ebef5745b7a749a74005be962c63ae2ea 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 787396e8da298fab736d4aa8d2b436a68ebee27b 
>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py 
> 4d8ebabb3a1dcf26dd491b3bb73c0057d6a8ac97 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 
> 78dffa5bbf065dcae61ae672c928f658b7400522 
>   src/test/python/apache/aurora/client/test_base.py 
> 8c880081620a8360bb2b7f0d854c7708c14cae7a 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> d7c61e26428c05d6b2f212e2bb092af38ef6aeec 
> 
> Diff: https://reviews.apache.org/r/41368/diff/
> 
> 
> Testing
> ---
> 
> Test suite + end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>



Re: Review Request 41368: Remove the client-side updater.

2015-12-15 Thread Stephan Erb

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41368/#review110447
---


The comment here https://issues.apache.org/jira/browse/AURORA-330 indicates 
that the old updater supported non-service updates, whereas the new one 
doesn't. We should at least communicate that more clearly.

- Stephan Erb


On Dec. 14, 2015, 11:36 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41368/
> ---
> 
> (Updated Dec. 14, 2015, 11:36 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-785
> https://issues.apache.org/jira/browse/AURORA-785
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> ```
>  NEWS   |   4 +
>  docs/hooks.md  |   2 -
>  .../python/apache/aurora/client/api/__init__.py|  24 -
>  .../python/apache/aurora/client/api/updater.py | 720 -
>  src/main/python/apache/aurora/client/base.py   |  19 -
>  src/main/python/apache/aurora/client/cli/jobs.py   | 115 ---
>  .../apache/aurora/client/hooks/hooked_api.py   |  14 -
>  src/test/python/apache/aurora/client/api/BUILD |  12 -
>  .../apache/aurora/client/api/test_updater.py   | 899 
> -
>  src/test/python/apache/aurora/client/cli/BUILD |  13 -
>  .../apache/aurora/client/cli/test_cancel_update.py |  62 --
>  .../python/apache/aurora/client/cli/test_update.py | 528 
>  .../apache/aurora/client/hooks/test_hooked_api.py  |   5 +-
>  .../aurora/client/hooks/test_non_hooked_api.py |  15 +-
>  src/test/python/apache/aurora/client/test_base.py  |   8 -
>  .../sh/org/apache/aurora/e2e/test_end_to_end.sh|   8 -
>  16 files changed, 11 insertions(+), 2437 deletions(-)
> ```
> 
> 
> Diffs
> -
> 
>   NEWS 99531a3ffd98acb08b9bee9c44a1553fba4b56a6 
>   docs/hooks.md 63dbdb91d014b65f129cd6b28bdb4c563f00ead3 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 1514394829cfd8d76d6db5cdfd7c6593f1193b29 
>   src/main/python/apache/aurora/client/api/updater.py 
> acbce21e991981a2e85c1a00a68e57d88c5509bb 
>   src/main/python/apache/aurora/client/base.py 
> 91c276b09500d4eb81368f0b4bd482f0177b5e53 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 46948497f59c9c4d91fdefd8038cff138b9aeb0f 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> 7fc0b7103e8968af8a9288b698829f31c00e6b32 
>   src/test/python/apache/aurora/client/api/BUILD 
> 2756912af8b0716417efa992201bf72ca736a653 
>   src/test/python/apache/aurora/client/api/test_updater.py 
> 5f54d22401a5eec0027b156ebaf50114221da8bd 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 1b14e8c299360f236412c8d9b5e2e143f755f4e0 
>   src/test/python/apache/aurora/client/cli/test_cancel_update.py 
> d4fc049ebef5745b7a749a74005be962c63ae2ea 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 787396e8da298fab736d4aa8d2b436a68ebee27b 
>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py 
> 4d8ebabb3a1dcf26dd491b3bb73c0057d6a8ac97 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 
> 78dffa5bbf065dcae61ae672c928f658b7400522 
>   src/test/python/apache/aurora/client/test_base.py 
> 8c880081620a8360bb2b7f0d854c7708c14cae7a 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> d7c61e26428c05d6b2f212e2bb092af38ef6aeec 
> 
> Diff: https://reviews.apache.org/r/41368/diff/
> 
> 
> Testing
> ---
> 
> Test suite + end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>



Re: Review Request 41368: Remove the client-side updater.

2015-12-15 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41368/#review110577
---


ping?

- Bill Farner


On Dec. 14, 2015, 2:36 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41368/
> ---
> 
> (Updated Dec. 14, 2015, 2:36 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-785
> https://issues.apache.org/jira/browse/AURORA-785
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> ```
>  NEWS   |   4 +
>  docs/hooks.md  |   2 -
>  .../python/apache/aurora/client/api/__init__.py|  24 -
>  .../python/apache/aurora/client/api/updater.py | 720 -
>  src/main/python/apache/aurora/client/base.py   |  19 -
>  src/main/python/apache/aurora/client/cli/jobs.py   | 115 ---
>  .../apache/aurora/client/hooks/hooked_api.py   |  14 -
>  src/test/python/apache/aurora/client/api/BUILD |  12 -
>  .../apache/aurora/client/api/test_updater.py   | 899 
> -
>  src/test/python/apache/aurora/client/cli/BUILD |  13 -
>  .../apache/aurora/client/cli/test_cancel_update.py |  62 --
>  .../python/apache/aurora/client/cli/test_update.py | 528 
>  .../apache/aurora/client/hooks/test_hooked_api.py  |   5 +-
>  .../aurora/client/hooks/test_non_hooked_api.py |  15 +-
>  src/test/python/apache/aurora/client/test_base.py  |   8 -
>  .../sh/org/apache/aurora/e2e/test_end_to_end.sh|   8 -
>  16 files changed, 11 insertions(+), 2437 deletions(-)
> ```
> 
> 
> Diffs
> -
> 
>   NEWS 99531a3ffd98acb08b9bee9c44a1553fba4b56a6 
>   docs/hooks.md 63dbdb91d014b65f129cd6b28bdb4c563f00ead3 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 1514394829cfd8d76d6db5cdfd7c6593f1193b29 
>   src/main/python/apache/aurora/client/api/updater.py 
> acbce21e991981a2e85c1a00a68e57d88c5509bb 
>   src/main/python/apache/aurora/client/base.py 
> 91c276b09500d4eb81368f0b4bd482f0177b5e53 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 46948497f59c9c4d91fdefd8038cff138b9aeb0f 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> 7fc0b7103e8968af8a9288b698829f31c00e6b32 
>   src/test/python/apache/aurora/client/api/BUILD 
> 2756912af8b0716417efa992201bf72ca736a653 
>   src/test/python/apache/aurora/client/api/test_updater.py 
> 5f54d22401a5eec0027b156ebaf50114221da8bd 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 1b14e8c299360f236412c8d9b5e2e143f755f4e0 
>   src/test/python/apache/aurora/client/cli/test_cancel_update.py 
> d4fc049ebef5745b7a749a74005be962c63ae2ea 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 787396e8da298fab736d4aa8d2b436a68ebee27b 
>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py 
> 4d8ebabb3a1dcf26dd491b3bb73c0057d6a8ac97 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 
> 78dffa5bbf065dcae61ae672c928f658b7400522 
>   src/test/python/apache/aurora/client/test_base.py 
> 8c880081620a8360bb2b7f0d854c7708c14cae7a 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> d7c61e26428c05d6b2f212e2bb092af38ef6aeec 
> 
> Diff: https://reviews.apache.org/r/41368/diff/
> 
> 
> Testing
> ---
> 
> Test suite + end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>



Re: Review Request 41368: Remove the client-side updater.

2015-12-15 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41368/#review110615
---

Ship it!


Sigh..

- Maxim Khutornenko


On Dec. 14, 2015, 10:36 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41368/
> ---
> 
> (Updated Dec. 14, 2015, 10:36 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-785
> https://issues.apache.org/jira/browse/AURORA-785
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> ```
>  NEWS   |   4 +
>  docs/hooks.md  |   2 -
>  .../python/apache/aurora/client/api/__init__.py|  24 -
>  .../python/apache/aurora/client/api/updater.py | 720 -
>  src/main/python/apache/aurora/client/base.py   |  19 -
>  src/main/python/apache/aurora/client/cli/jobs.py   | 115 ---
>  .../apache/aurora/client/hooks/hooked_api.py   |  14 -
>  src/test/python/apache/aurora/client/api/BUILD |  12 -
>  .../apache/aurora/client/api/test_updater.py   | 899 
> -
>  src/test/python/apache/aurora/client/cli/BUILD |  13 -
>  .../apache/aurora/client/cli/test_cancel_update.py |  62 --
>  .../python/apache/aurora/client/cli/test_update.py | 528 
>  .../apache/aurora/client/hooks/test_hooked_api.py  |   5 +-
>  .../aurora/client/hooks/test_non_hooked_api.py |  15 +-
>  src/test/python/apache/aurora/client/test_base.py  |   8 -
>  .../sh/org/apache/aurora/e2e/test_end_to_end.sh|   8 -
>  16 files changed, 11 insertions(+), 2437 deletions(-)
> ```
> 
> 
> Diffs
> -
> 
>   NEWS 99531a3ffd98acb08b9bee9c44a1553fba4b56a6 
>   docs/hooks.md 63dbdb91d014b65f129cd6b28bdb4c563f00ead3 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 1514394829cfd8d76d6db5cdfd7c6593f1193b29 
>   src/main/python/apache/aurora/client/api/updater.py 
> acbce21e991981a2e85c1a00a68e57d88c5509bb 
>   src/main/python/apache/aurora/client/base.py 
> 91c276b09500d4eb81368f0b4bd482f0177b5e53 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 46948497f59c9c4d91fdefd8038cff138b9aeb0f 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> 7fc0b7103e8968af8a9288b698829f31c00e6b32 
>   src/test/python/apache/aurora/client/api/BUILD 
> 2756912af8b0716417efa992201bf72ca736a653 
>   src/test/python/apache/aurora/client/api/test_updater.py 
> 5f54d22401a5eec0027b156ebaf50114221da8bd 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 1b14e8c299360f236412c8d9b5e2e143f755f4e0 
>   src/test/python/apache/aurora/client/cli/test_cancel_update.py 
> d4fc049ebef5745b7a749a74005be962c63ae2ea 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 787396e8da298fab736d4aa8d2b436a68ebee27b 
>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py 
> 4d8ebabb3a1dcf26dd491b3bb73c0057d6a8ac97 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 
> 78dffa5bbf065dcae61ae672c928f658b7400522 
>   src/test/python/apache/aurora/client/test_base.py 
> 8c880081620a8360bb2b7f0d854c7708c14cae7a 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> d7c61e26428c05d6b2f212e2bb092af38ef6aeec 
> 
> Diff: https://reviews.apache.org/r/41368/diff/
> 
> 
> Testing
> ---
> 
> Test suite + end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>



Re: Review Request 41368: Remove the client-side updater.

2015-12-15 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41368/#review110616
---


Please, cleanup docs as well. There are quite a few "aurora job update" 
mentions.

- Maxim Khutornenko


On Dec. 14, 2015, 10:36 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41368/
> ---
> 
> (Updated Dec. 14, 2015, 10:36 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-785
> https://issues.apache.org/jira/browse/AURORA-785
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> ```
>  NEWS   |   4 +
>  docs/hooks.md  |   2 -
>  .../python/apache/aurora/client/api/__init__.py|  24 -
>  .../python/apache/aurora/client/api/updater.py | 720 -
>  src/main/python/apache/aurora/client/base.py   |  19 -
>  src/main/python/apache/aurora/client/cli/jobs.py   | 115 ---
>  .../apache/aurora/client/hooks/hooked_api.py   |  14 -
>  src/test/python/apache/aurora/client/api/BUILD |  12 -
>  .../apache/aurora/client/api/test_updater.py   | 899 
> -
>  src/test/python/apache/aurora/client/cli/BUILD |  13 -
>  .../apache/aurora/client/cli/test_cancel_update.py |  62 --
>  .../python/apache/aurora/client/cli/test_update.py | 528 
>  .../apache/aurora/client/hooks/test_hooked_api.py  |   5 +-
>  .../aurora/client/hooks/test_non_hooked_api.py |  15 +-
>  src/test/python/apache/aurora/client/test_base.py  |   8 -
>  .../sh/org/apache/aurora/e2e/test_end_to_end.sh|   8 -
>  16 files changed, 11 insertions(+), 2437 deletions(-)
> ```
> 
> 
> Diffs
> -
> 
>   NEWS 99531a3ffd98acb08b9bee9c44a1553fba4b56a6 
>   docs/hooks.md 63dbdb91d014b65f129cd6b28bdb4c563f00ead3 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 1514394829cfd8d76d6db5cdfd7c6593f1193b29 
>   src/main/python/apache/aurora/client/api/updater.py 
> acbce21e991981a2e85c1a00a68e57d88c5509bb 
>   src/main/python/apache/aurora/client/base.py 
> 91c276b09500d4eb81368f0b4bd482f0177b5e53 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 46948497f59c9c4d91fdefd8038cff138b9aeb0f 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> 7fc0b7103e8968af8a9288b698829f31c00e6b32 
>   src/test/python/apache/aurora/client/api/BUILD 
> 2756912af8b0716417efa992201bf72ca736a653 
>   src/test/python/apache/aurora/client/api/test_updater.py 
> 5f54d22401a5eec0027b156ebaf50114221da8bd 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 1b14e8c299360f236412c8d9b5e2e143f755f4e0 
>   src/test/python/apache/aurora/client/cli/test_cancel_update.py 
> d4fc049ebef5745b7a749a74005be962c63ae2ea 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 787396e8da298fab736d4aa8d2b436a68ebee27b 
>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py 
> 4d8ebabb3a1dcf26dd491b3bb73c0057d6a8ac97 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 
> 78dffa5bbf065dcae61ae672c928f658b7400522 
>   src/test/python/apache/aurora/client/test_base.py 
> 8c880081620a8360bb2b7f0d854c7708c14cae7a 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> d7c61e26428c05d6b2f212e2bb092af38ef6aeec 
> 
> Diff: https://reviews.apache.org/r/41368/diff/
> 
> 
> Testing
> ---
> 
> Test suite + end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>