Re: Review Request 41525: Add flag to set FrameworkInfo.principal

2015-12-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41525/#review111005 --- Ship it! Master (c912c34) is green with this patch.

Re: Review Request 41525: Add flag to set FrameworkInfo.principal

2015-12-17 Thread R.B. Boyer
> On Dec. 17, 2015, 2:53 p.m., Bill Farner wrote: > > Thanks, overall this looks great! > > > > Can you also add a line in the NEWS file to call out the new flag? Doesn't > > need formal documentation, just a brief blurb is fine. Under 0.11.0 or in an unspecified area above that? - R.B.

Re: Review Request 41525: Add flag to set FrameworkInfo.principal

2015-12-17 Thread R.B. Boyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41525/ --- (Updated Dec. 17, 2015, 3:24 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 41525: Add flag to set FrameworkInfo.principal

2015-12-17 Thread Bill Farner
> On Dec. 17, 2015, 12:53 p.m., Bill Farner wrote: > > Thanks, overall this looks great! > > > > Can you also add a line in the NEWS file to call out the new flag? Doesn't > > need formal documentation, just a brief blurb is fine. > > R.B. Boyer wrote: > Under 0.11.0 or in an unspecified

Re: Review Request 41525: Add flag to set FrameworkInfo.principal

2015-12-17 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41525/#review111063 --- Ship it! lgtm pending the changes Bill requested. - Joshua Cohen

Re: Review Request 41525: Add flag to set FrameworkInfo.principal

2015-12-17 Thread R.B. Boyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41525/ --- (Updated Dec. 17, 2015, 3:26 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 41525: Add flag to set FrameworkInfo.principal

2015-12-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41525/#review111066 ---