Re: Review Request 41777: Use slf4j throughout the scheduler.

2016-01-03 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41777/#review112479
---

Ship it!


- Zameer Manji


On Dec. 29, 2015, 4:06 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41777/
> ---
> 
> (Updated Dec. 29, 2015, 4:06 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> slf4j allows us to isolate the decision and configuration of our logging 
> backend.
> 
> Apologies for the monster patch.  Most of this is pretty mechanical (and was 
> automated), however.
> 
> 
> Diffs
> -
> 
>   
> commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java
>  3ff3474dc3c8536758a0a0b3e05587daa7cde3eb 
>   commons/src/main/java/org/apache/aurora/common/application/Lifecycle.java 
> a71a51d2fa9465926df5b1232f450767df150847 
>   
> commons/src/main/java/org/apache/aurora/common/application/ShutdownRegistry.java
>  b440e7e6a2b26533d0ce52bf0ffb21735ef6352f 
>   commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java 
> c98ed8750cf8306593587f28bf8f3e76a01b6254 
>   commons/src/main/java/org/apache/aurora/common/args/Args.java 
> db8e1694a81a5791d13f8d5c6cfa5f489209e82f 
>   commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java 
> ddffdf9c8d41166fee49866a3b7fbc2efd6bbe54 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/ListParser.java 
> 676f88be9a8f9d3f743ee9e62f133470cb84df6b 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/SetParser.java 
> 75031f49c7a509f55edc0f7d624dfcc7a0bd2930 
>   commons/src/main/java/org/apache/aurora/common/collections/Iterables2.java 
> 7ae80ce7193717fd82dc59a346d07cba0d10e4cb 
>   commons/src/main/java/org/apache/aurora/common/inject/TimedInterceptor.java 
> 684e7bb885fcd142e926b4e68c25323e465624fb 
>   
> commons/src/main/java/org/apache/aurora/common/net/InetSocketAddressHelper.java
>  b3719d8f71679f7165631fd6cd4f18a93d5f871a 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/AbortHandler.java
>  42e668d09e52bdeb50a05ee7000b7f51e3160104 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParams.java
>  c09be674d65010dfbc73fe09d8051558d236001c 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/LogConfig.java
>  c3fd80863e66f50023647c25e47e4406e89a7fa9 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/QuitHandler.java
>  40872e2778b9f3cb05e58be22a1ad4e31b3e1b3e 
>   commons/src/main/java/org/apache/aurora/common/stats/JvmStats.java 
> d1b072d14556be00bf2b6e06019b696c7c3235e3 
>   commons/src/main/java/org/apache/aurora/common/stats/Percentile.java 
> d8046b635b1ac5d816457430fb75ea17a6f46fde 
>   commons/src/main/java/org/apache/aurora/common/stats/Rate.java 
> dbb90c45fed4ba2c7b97c6e14646345f6fc430f7 
>   commons/src/main/java/org/apache/aurora/common/stats/RequestStats.java 
> 5467810e3ac546b007ae8436ffe8c8dce9231eef 
>   commons/src/main/java/org/apache/aurora/common/stats/SlidingStats.java 
> 334167275bdbd4f494b8e89c3b2575c21946a29e 
>   commons/src/main/java/org/apache/aurora/common/stats/Stats.java 
> d4b6a3133c5ece40a398d8cfe605627d2344f0a8 
>   commons/src/main/java/org/apache/aurora/common/stats/TimeSeries.java 
> 45f604c76ea255de3c805a6a48406bcd3e587838 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  6b237fbf7d308150c8dd12f7e25e2bd6aca900ab 
>   commons/src/main/java/org/apache/aurora/common/util/BackoffHelper.java 
> b251e9b84aa33c7c1e1366aaf8872a367864e408 
>   commons/src/main/java/org/apache/aurora/common/util/BuildInfo.java 
> 4f9c3847bc64c80e64bd3c04ea8df3ae44716947 
>   commons/src/main/java/org/apache/aurora/common/util/StateMachine.java 
> dbaaadde9aa821e2293656bd48afc47816e900a2 
>   
> commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java
>  fd74b9f37c6cc24c7ea1cb239ba6354661d931e2 
>   
> commons/src/main/java/org/apache/aurora/common/util/templating/StringTemplateHelper.java
>  2756af49c7702ac1343712476e138fd4367aa756 
>   commons/src/main/java/org/apache/aurora/common/util/testing/FakeClock.java 
> 2ed8b15686e0bfc6310c0427e3501e9f6d5d8af7 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/Candidate.java 
> f679d92e6ede869e5b374c80b261ba7e83858152 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java 
> bb0a48d3d8e55fd95b07bc7a0999aa6a3d2fe691 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/Group.java 
> d3681700e7f993da711f3b1ac87dc0335075cf71 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java 
>

Re: Review Request 41777: Use slf4j throughout the scheduler.

2015-12-29 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41777/#review112270
---

Ship it!


Master (80ae5e8) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Dec. 30, 2015, 12:06 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41777/
> ---
> 
> (Updated Dec. 30, 2015, 12:06 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> slf4j allows us to isolate the decision and configuration of our logging 
> backend.
> 
> Apologies for the monster patch.  Most of this is pretty mechanical (and was 
> automated), however.
> 
> 
> Diffs
> -
> 
>   
> commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java
>  3ff3474dc3c8536758a0a0b3e05587daa7cde3eb 
>   commons/src/main/java/org/apache/aurora/common/application/Lifecycle.java 
> a71a51d2fa9465926df5b1232f450767df150847 
>   
> commons/src/main/java/org/apache/aurora/common/application/ShutdownRegistry.java
>  b440e7e6a2b26533d0ce52bf0ffb21735ef6352f 
>   commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java 
> c98ed8750cf8306593587f28bf8f3e76a01b6254 
>   commons/src/main/java/org/apache/aurora/common/args/Args.java 
> db8e1694a81a5791d13f8d5c6cfa5f489209e82f 
>   commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java 
> ddffdf9c8d41166fee49866a3b7fbc2efd6bbe54 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/ListParser.java 
> 676f88be9a8f9d3f743ee9e62f133470cb84df6b 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/SetParser.java 
> 75031f49c7a509f55edc0f7d624dfcc7a0bd2930 
>   commons/src/main/java/org/apache/aurora/common/collections/Iterables2.java 
> 7ae80ce7193717fd82dc59a346d07cba0d10e4cb 
>   commons/src/main/java/org/apache/aurora/common/inject/TimedInterceptor.java 
> 684e7bb885fcd142e926b4e68c25323e465624fb 
>   
> commons/src/main/java/org/apache/aurora/common/net/InetSocketAddressHelper.java
>  b3719d8f71679f7165631fd6cd4f18a93d5f871a 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/AbortHandler.java
>  42e668d09e52bdeb50a05ee7000b7f51e3160104 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParams.java
>  c09be674d65010dfbc73fe09d8051558d236001c 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/LogConfig.java
>  c3fd80863e66f50023647c25e47e4406e89a7fa9 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/QuitHandler.java
>  40872e2778b9f3cb05e58be22a1ad4e31b3e1b3e 
>   commons/src/main/java/org/apache/aurora/common/stats/JvmStats.java 
> d1b072d14556be00bf2b6e06019b696c7c3235e3 
>   commons/src/main/java/org/apache/aurora/common/stats/Percentile.java 
> d8046b635b1ac5d816457430fb75ea17a6f46fde 
>   commons/src/main/java/org/apache/aurora/common/stats/Rate.java 
> dbb90c45fed4ba2c7b97c6e14646345f6fc430f7 
>   commons/src/main/java/org/apache/aurora/common/stats/RequestStats.java 
> 5467810e3ac546b007ae8436ffe8c8dce9231eef 
>   commons/src/main/java/org/apache/aurora/common/stats/SlidingStats.java 
> 334167275bdbd4f494b8e89c3b2575c21946a29e 
>   commons/src/main/java/org/apache/aurora/common/stats/Stats.java 
> d4b6a3133c5ece40a398d8cfe605627d2344f0a8 
>   commons/src/main/java/org/apache/aurora/common/stats/TimeSeries.java 
> 45f604c76ea255de3c805a6a48406bcd3e587838 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  6b237fbf7d308150c8dd12f7e25e2bd6aca900ab 
>   commons/src/main/java/org/apache/aurora/common/util/BackoffHelper.java 
> b251e9b84aa33c7c1e1366aaf8872a367864e408 
>   commons/src/main/java/org/apache/aurora/common/util/BuildInfo.java 
> 4f9c3847bc64c80e64bd3c04ea8df3ae44716947 
>   commons/src/main/java/org/apache/aurora/common/util/StateMachine.java 
> dbaaadde9aa821e2293656bd48afc47816e900a2 
>   
> commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java
>  fd74b9f37c6cc24c7ea1cb239ba6354661d931e2 
>   
> commons/src/main/java/org/apache/aurora/common/util/templating/StringTemplateHelper.java
>  2756af49c7702ac1343712476e138fd4367aa756 
>   commons/src/main/java/org/apache/aurora/common/util/testing/FakeClock.java 
> 2ed8b15686e0bfc6310c0427e3501e9f6d5d8af7 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/Candidate.java 
> f679d92e6ede869e5b374c80b261ba7e83858152 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java 
> bb0a48d3d8e55fd95b07bc7a0999aa6a3d2fe691 
>

Re: Review Request 41777: Use slf4j throughout the scheduler.

2015-12-29 Thread John Sirois 


> On Dec. 29, 2015, 3:15 p.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java, line 
> > 100
> > 
> >
> > This now always logs all the fast queries - I don't think you want this!
> 
> Bill Farner wrote:
> Effectively the same as before, right?  We are now just always making a 
> call to `LOG.info` or `LOG.debug` whereas we ahd a guard before.  However, 
> the calls are effectively guarded behind the scenes based on the log level 
> setting.

I guess thats correct since the time is now always calculated (before if was 
lazy) and there is no message formatting - dropped.


> On Dec. 29, 2015, 3:15 p.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java, 
> > line 143
> > 
> >
> > This now always logs all the fast queries!
> 
> Bill Farner wrote:
> Ditto re: comment above.

Ack - dropped.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41777/#review112218
---


On Dec. 29, 2015, 2:08 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41777/
> ---
> 
> (Updated Dec. 29, 2015, 2:08 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> slf4j allows us to isolate the decision and configuration of our logging 
> backend.
> 
> Apologies for the monster patch.  Most of this is pretty mechanical (and was 
> automated), however.
> 
> 
> Diffs
> -
> 
>   
> commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java
>  3ff3474dc3c8536758a0a0b3e05587daa7cde3eb 
>   commons/src/main/java/org/apache/aurora/common/application/Lifecycle.java 
> a71a51d2fa9465926df5b1232f450767df150847 
>   
> commons/src/main/java/org/apache/aurora/common/application/ShutdownRegistry.java
>  b440e7e6a2b26533d0ce52bf0ffb21735ef6352f 
>   commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java 
> c98ed8750cf8306593587f28bf8f3e76a01b6254 
>   commons/src/main/java/org/apache/aurora/common/args/Args.java 
> db8e1694a81a5791d13f8d5c6cfa5f489209e82f 
>   commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java 
> ddffdf9c8d41166fee49866a3b7fbc2efd6bbe54 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/ListParser.java 
> 676f88be9a8f9d3f743ee9e62f133470cb84df6b 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/SetParser.java 
> 75031f49c7a509f55edc0f7d624dfcc7a0bd2930 
>   commons/src/main/java/org/apache/aurora/common/collections/Iterables2.java 
> 7ae80ce7193717fd82dc59a346d07cba0d10e4cb 
>   commons/src/main/java/org/apache/aurora/common/inject/TimedInterceptor.java 
> 684e7bb885fcd142e926b4e68c25323e465624fb 
>   
> commons/src/main/java/org/apache/aurora/common/net/InetSocketAddressHelper.java
>  b3719d8f71679f7165631fd6cd4f18a93d5f871a 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/AbortHandler.java
>  42e668d09e52bdeb50a05ee7000b7f51e3160104 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParams.java
>  c09be674d65010dfbc73fe09d8051558d236001c 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/LogConfig.java
>  c3fd80863e66f50023647c25e47e4406e89a7fa9 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/QuitHandler.java
>  40872e2778b9f3cb05e58be22a1ad4e31b3e1b3e 
>   commons/src/main/java/org/apache/aurora/common/stats/JvmStats.java 
> d1b072d14556be00bf2b6e06019b696c7c3235e3 
>   commons/src/main/java/org/apache/aurora/common/stats/Percentile.java 
> d8046b635b1ac5d816457430fb75ea17a6f46fde 
>   commons/src/main/java/org/apache/aurora/common/stats/Rate.java 
> dbb90c45fed4ba2c7b97c6e14646345f6fc430f7 
>   commons/src/main/java/org/apache/aurora/common/stats/RequestStats.java 
> 5467810e3ac546b007ae8436ffe8c8dce9231eef 
>   commons/src/main/java/org/apache/aurora/common/stats/SlidingStats.java 
> 334167275bdbd4f494b8e89c3b2575c21946a29e 
>   commons/src/main/java/org/apache/aurora/common/stats/Stats.java 
> d4b6a3133c5ece40a398d8cfe605627d2344f0a8 
>   commons/src/main/java/org/apache/aurora/common/stats/TimeSeries.java 
> 45f604c76ea255de3c805a6a48406bcd3e587838 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  6b237fbf7d308150c8dd12f7e25e2bd6aca900ab 
>   commons/src/main/java/org/apache/aurora/common/util/BackoffHelper.java 
> b251e9b84aa33c7c1e1366aaf8872a367864e408 
>

Re: Review Request 41777: Use slf4j throughout the scheduler.

2015-12-29 Thread Bill Farner 


> On Dec. 29, 2015, 2:15 p.m., John Sirois wrote:
> > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java,
> >  line 363
> > 
> >
> > This branch is a perf-change since the message is now always built, but 
> > this seems inconsequential / just fine.

ACK - our serverset tends to be singleton (and thus small/cheap toString), so i 
made the same judgement call.


> On Dec. 29, 2015, 2:15 p.m., John Sirois wrote:
> > commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java,
> >  line 60
> > 
> >
> > Unused - can kill.

Done.


> On Dec. 29, 2015, 2:15 p.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java, line 127
> > 
> >
> > You have kept the status quo - but the status quo is weird! The check 
> > is for debug and the log is at info.  As you see fit, but if the semantics 
> > are actually what is wanted a comment is in order; otherwise, take 
> > advantage of the built-in lazy Logger message formatting here.

Definitely a bug, changed to `LOG.debug`.


> On Dec. 29, 2015, 2:15 p.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java, line 262
> > 
> >
> > Kill the guard and convert to lazy-format.

Done.


> On Dec. 29, 2015, 2:15 p.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java, 
> > line 108
> > 
> >
> > The only use of inject jul Logger I can remember ever coming across 
> > outside guice docs.

Hah yeah, a _very_ brief experiment :-)


> On Dec. 29, 2015, 2:15 p.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java, 
> > line 190
> > 
> >
> > Kill guard, use free lazy formatting.

Done.


> On Dec. 29, 2015, 2:15 p.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java, 
> > line 209
> > 
> >
> > s/infoLevel/debugLevel/

Thanks, fixed.


> On Dec. 29, 2015, 2:15 p.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line 
> > 121
> > 
> >
> > Leverage lazy format and kill guard.

Ah, right.  I did not do this since i can't prevent `Iterables.transform`, but 
forgot that's lazy too.


> On Dec. 29, 2015, 2:15 p.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java, line 
> > 95
> > 
> >
> > Extra work now for those with >=WARN, but I imagine negligible.

Yeah, that's the bet.


> On Dec. 29, 2015, 2:15 p.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java, line 
> > 100
> > 
> >
> > This now always logs all the fast queries - I don't think you want this!

Effectively the same as before, right?  We are now just always making a call to 
`LOG.info` or `LOG.debug` whereas we ahd a guard before.  However, the calls 
are effectively guarded behind the scenes based on the log level setting.


> On Dec. 29, 2015, 2:15 p.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java,
> >  line 208
> > 
> >
> > Kill guard, use {} lazy formatting.

Done.


> On Dec. 29, 2015, 2:15 p.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java, 
> > line 138
> > 
> >
> > Extra work now for those with >=WARN, but I imagine negligible.

ACK


> On Dec. 29, 2015, 2:15 p.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java, 
> > line 143
> > 
> >
> > This now always logs all the fast queries!

Ditto re: comment above.


> On Dec. 29, 2015, 2:15 p.m., John Sirois wrote:
> > src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java,
> >  line 205
> > 
> >
> > Hrm, well this adds more work to removing debug guards, but I do think 
> > its worth it to remove prod clutter.

+1


- Bill

Re: Review Request 41777: Use slf4j throughout the scheduler.

2015-12-29 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41777/#review112233
---

Ship it!


Master (80ae5e8) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Dec. 29, 2015, 9:08 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41777/
> ---
> 
> (Updated Dec. 29, 2015, 9:08 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> slf4j allows us to isolate the decision and configuration of our logging 
> backend.
> 
> Apologies for the monster patch.  Most of this is pretty mechanical (and was 
> automated), however.
> 
> 
> Diffs
> -
> 
>   
> commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java
>  3ff3474dc3c8536758a0a0b3e05587daa7cde3eb 
>   commons/src/main/java/org/apache/aurora/common/application/Lifecycle.java 
> a71a51d2fa9465926df5b1232f450767df150847 
>   
> commons/src/main/java/org/apache/aurora/common/application/ShutdownRegistry.java
>  b440e7e6a2b26533d0ce52bf0ffb21735ef6352f 
>   commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java 
> c98ed8750cf8306593587f28bf8f3e76a01b6254 
>   commons/src/main/java/org/apache/aurora/common/args/Args.java 
> db8e1694a81a5791d13f8d5c6cfa5f489209e82f 
>   commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java 
> ddffdf9c8d41166fee49866a3b7fbc2efd6bbe54 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/ListParser.java 
> 676f88be9a8f9d3f743ee9e62f133470cb84df6b 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/SetParser.java 
> 75031f49c7a509f55edc0f7d624dfcc7a0bd2930 
>   commons/src/main/java/org/apache/aurora/common/collections/Iterables2.java 
> 7ae80ce7193717fd82dc59a346d07cba0d10e4cb 
>   commons/src/main/java/org/apache/aurora/common/inject/TimedInterceptor.java 
> 684e7bb885fcd142e926b4e68c25323e465624fb 
>   
> commons/src/main/java/org/apache/aurora/common/net/InetSocketAddressHelper.java
>  b3719d8f71679f7165631fd6cd4f18a93d5f871a 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/AbortHandler.java
>  42e668d09e52bdeb50a05ee7000b7f51e3160104 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParams.java
>  c09be674d65010dfbc73fe09d8051558d236001c 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/LogConfig.java
>  c3fd80863e66f50023647c25e47e4406e89a7fa9 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/QuitHandler.java
>  40872e2778b9f3cb05e58be22a1ad4e31b3e1b3e 
>   commons/src/main/java/org/apache/aurora/common/stats/JvmStats.java 
> d1b072d14556be00bf2b6e06019b696c7c3235e3 
>   commons/src/main/java/org/apache/aurora/common/stats/Percentile.java 
> d8046b635b1ac5d816457430fb75ea17a6f46fde 
>   commons/src/main/java/org/apache/aurora/common/stats/Rate.java 
> dbb90c45fed4ba2c7b97c6e14646345f6fc430f7 
>   commons/src/main/java/org/apache/aurora/common/stats/RequestStats.java 
> 5467810e3ac546b007ae8436ffe8c8dce9231eef 
>   commons/src/main/java/org/apache/aurora/common/stats/SlidingStats.java 
> 334167275bdbd4f494b8e89c3b2575c21946a29e 
>   commons/src/main/java/org/apache/aurora/common/stats/Stats.java 
> d4b6a3133c5ece40a398d8cfe605627d2344f0a8 
>   commons/src/main/java/org/apache/aurora/common/stats/TimeSeries.java 
> 45f604c76ea255de3c805a6a48406bcd3e587838 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  6b237fbf7d308150c8dd12f7e25e2bd6aca900ab 
>   commons/src/main/java/org/apache/aurora/common/util/BackoffHelper.java 
> b251e9b84aa33c7c1e1366aaf8872a367864e408 
>   commons/src/main/java/org/apache/aurora/common/util/BuildInfo.java 
> 4f9c3847bc64c80e64bd3c04ea8df3ae44716947 
>   commons/src/main/java/org/apache/aurora/common/util/StateMachine.java 
> dbaaadde9aa821e2293656bd48afc47816e900a2 
>   
> commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java
>  fd74b9f37c6cc24c7ea1cb239ba6354661d931e2 
>   
> commons/src/main/java/org/apache/aurora/common/util/templating/StringTemplateHelper.java
>  2756af49c7702ac1343712476e138fd4367aa756 
>   commons/src/main/java/org/apache/aurora/common/util/testing/FakeClock.java 
> 2ed8b15686e0bfc6310c0427e3501e9f6d5d8af7 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/Candidate.java 
> f679d92e6ede869e5b374c80b261ba7e83858152 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java 
> bb0a48d3d8e55fd95b07bc7a0999aa6a3d2fe691 
>

Re: Review Request 41777: Use slf4j throughout the scheduler.

2015-12-29 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41777/#review112263
---

Ship it!



src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java (line 125)


You can use {}'s and drop the guard now.


- John Sirois


On Dec. 29, 2015, 4:52 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41777/
> ---
> 
> (Updated Dec. 29, 2015, 4:52 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> slf4j allows us to isolate the decision and configuration of our logging 
> backend.
> 
> Apologies for the monster patch.  Most of this is pretty mechanical (and was 
> automated), however.
> 
> 
> Diffs
> -
> 
>   
> commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java
>  3ff3474dc3c8536758a0a0b3e05587daa7cde3eb 
>   commons/src/main/java/org/apache/aurora/common/application/Lifecycle.java 
> a71a51d2fa9465926df5b1232f450767df150847 
>   
> commons/src/main/java/org/apache/aurora/common/application/ShutdownRegistry.java
>  b440e7e6a2b26533d0ce52bf0ffb21735ef6352f 
>   commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java 
> c98ed8750cf8306593587f28bf8f3e76a01b6254 
>   commons/src/main/java/org/apache/aurora/common/args/Args.java 
> db8e1694a81a5791d13f8d5c6cfa5f489209e82f 
>   commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java 
> ddffdf9c8d41166fee49866a3b7fbc2efd6bbe54 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/ListParser.java 
> 676f88be9a8f9d3f743ee9e62f133470cb84df6b 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/SetParser.java 
> 75031f49c7a509f55edc0f7d624dfcc7a0bd2930 
>   commons/src/main/java/org/apache/aurora/common/collections/Iterables2.java 
> 7ae80ce7193717fd82dc59a346d07cba0d10e4cb 
>   commons/src/main/java/org/apache/aurora/common/inject/TimedInterceptor.java 
> 684e7bb885fcd142e926b4e68c25323e465624fb 
>   
> commons/src/main/java/org/apache/aurora/common/net/InetSocketAddressHelper.java
>  b3719d8f71679f7165631fd6cd4f18a93d5f871a 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/AbortHandler.java
>  42e668d09e52bdeb50a05ee7000b7f51e3160104 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParams.java
>  c09be674d65010dfbc73fe09d8051558d236001c 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/LogConfig.java
>  c3fd80863e66f50023647c25e47e4406e89a7fa9 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/QuitHandler.java
>  40872e2778b9f3cb05e58be22a1ad4e31b3e1b3e 
>   commons/src/main/java/org/apache/aurora/common/stats/JvmStats.java 
> d1b072d14556be00bf2b6e06019b696c7c3235e3 
>   commons/src/main/java/org/apache/aurora/common/stats/Percentile.java 
> d8046b635b1ac5d816457430fb75ea17a6f46fde 
>   commons/src/main/java/org/apache/aurora/common/stats/Rate.java 
> dbb90c45fed4ba2c7b97c6e14646345f6fc430f7 
>   commons/src/main/java/org/apache/aurora/common/stats/RequestStats.java 
> 5467810e3ac546b007ae8436ffe8c8dce9231eef 
>   commons/src/main/java/org/apache/aurora/common/stats/SlidingStats.java 
> 334167275bdbd4f494b8e89c3b2575c21946a29e 
>   commons/src/main/java/org/apache/aurora/common/stats/Stats.java 
> d4b6a3133c5ece40a398d8cfe605627d2344f0a8 
>   commons/src/main/java/org/apache/aurora/common/stats/TimeSeries.java 
> 45f604c76ea255de3c805a6a48406bcd3e587838 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  6b237fbf7d308150c8dd12f7e25e2bd6aca900ab 
>   commons/src/main/java/org/apache/aurora/common/util/BackoffHelper.java 
> b251e9b84aa33c7c1e1366aaf8872a367864e408 
>   commons/src/main/java/org/apache/aurora/common/util/BuildInfo.java 
> 4f9c3847bc64c80e64bd3c04ea8df3ae44716947 
>   commons/src/main/java/org/apache/aurora/common/util/StateMachine.java 
> dbaaadde9aa821e2293656bd48afc47816e900a2 
>   
> commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java
>  fd74b9f37c6cc24c7ea1cb239ba6354661d931e2 
>   
> commons/src/main/java/org/apache/aurora/common/util/templating/StringTemplateHelper.java
>  2756af49c7702ac1343712476e138fd4367aa756 
>   commons/src/main/java/org/apache/aurora/common/util/testing/FakeClock.java 
> 2ed8b15686e0bfc6310c0427e3501e9f6d5d8af7 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/Candidate.java 
> f679d92e6ede869e5b374c80b261ba7e83858152 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java 
> bb0a48d3d8e55fd95b07bc7a0999aa6a3d2fe691 
>

Re: Review Request 41777: Use slf4j throughout the scheduler.

2015-12-29 Thread Bill Farner 


> On Dec. 29, 2015, 3:59 p.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java, line 125
> > 
> >
> > You can use {}'s and drop the guard now.

Doh, thought i did that.  Thanks, fixed.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41777/#review112263
---


On Dec. 29, 2015, 3:52 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41777/
> ---
> 
> (Updated Dec. 29, 2015, 3:52 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> slf4j allows us to isolate the decision and configuration of our logging 
> backend.
> 
> Apologies for the monster patch.  Most of this is pretty mechanical (and was 
> automated), however.
> 
> 
> Diffs
> -
> 
>   
> commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java
>  3ff3474dc3c8536758a0a0b3e05587daa7cde3eb 
>   commons/src/main/java/org/apache/aurora/common/application/Lifecycle.java 
> a71a51d2fa9465926df5b1232f450767df150847 
>   
> commons/src/main/java/org/apache/aurora/common/application/ShutdownRegistry.java
>  b440e7e6a2b26533d0ce52bf0ffb21735ef6352f 
>   commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java 
> c98ed8750cf8306593587f28bf8f3e76a01b6254 
>   commons/src/main/java/org/apache/aurora/common/args/Args.java 
> db8e1694a81a5791d13f8d5c6cfa5f489209e82f 
>   commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java 
> ddffdf9c8d41166fee49866a3b7fbc2efd6bbe54 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/ListParser.java 
> 676f88be9a8f9d3f743ee9e62f133470cb84df6b 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/SetParser.java 
> 75031f49c7a509f55edc0f7d624dfcc7a0bd2930 
>   commons/src/main/java/org/apache/aurora/common/collections/Iterables2.java 
> 7ae80ce7193717fd82dc59a346d07cba0d10e4cb 
>   commons/src/main/java/org/apache/aurora/common/inject/TimedInterceptor.java 
> 684e7bb885fcd142e926b4e68c25323e465624fb 
>   
> commons/src/main/java/org/apache/aurora/common/net/InetSocketAddressHelper.java
>  b3719d8f71679f7165631fd6cd4f18a93d5f871a 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/AbortHandler.java
>  42e668d09e52bdeb50a05ee7000b7f51e3160104 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParams.java
>  c09be674d65010dfbc73fe09d8051558d236001c 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/LogConfig.java
>  c3fd80863e66f50023647c25e47e4406e89a7fa9 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/QuitHandler.java
>  40872e2778b9f3cb05e58be22a1ad4e31b3e1b3e 
>   commons/src/main/java/org/apache/aurora/common/stats/JvmStats.java 
> d1b072d14556be00bf2b6e06019b696c7c3235e3 
>   commons/src/main/java/org/apache/aurora/common/stats/Percentile.java 
> d8046b635b1ac5d816457430fb75ea17a6f46fde 
>   commons/src/main/java/org/apache/aurora/common/stats/Rate.java 
> dbb90c45fed4ba2c7b97c6e14646345f6fc430f7 
>   commons/src/main/java/org/apache/aurora/common/stats/RequestStats.java 
> 5467810e3ac546b007ae8436ffe8c8dce9231eef 
>   commons/src/main/java/org/apache/aurora/common/stats/SlidingStats.java 
> 334167275bdbd4f494b8e89c3b2575c21946a29e 
>   commons/src/main/java/org/apache/aurora/common/stats/Stats.java 
> d4b6a3133c5ece40a398d8cfe605627d2344f0a8 
>   commons/src/main/java/org/apache/aurora/common/stats/TimeSeries.java 
> 45f604c76ea255de3c805a6a48406bcd3e587838 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  6b237fbf7d308150c8dd12f7e25e2bd6aca900ab 
>   commons/src/main/java/org/apache/aurora/common/util/BackoffHelper.java 
> b251e9b84aa33c7c1e1366aaf8872a367864e408 
>   commons/src/main/java/org/apache/aurora/common/util/BuildInfo.java 
> 4f9c3847bc64c80e64bd3c04ea8df3ae44716947 
>   commons/src/main/java/org/apache/aurora/common/util/StateMachine.java 
> dbaaadde9aa821e2293656bd48afc47816e900a2 
>   
> commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java
>  fd74b9f37c6cc24c7ea1cb239ba6354661d931e2 
>   
> commons/src/main/java/org/apache/aurora/common/util/templating/StringTemplateHelper.java
>  2756af49c7702ac1343712476e138fd4367aa756 
>   commons/src/main/java/org/apache/aurora/common/util/testing/FakeClock.java 
> 2ed8b15686e0bfc6310c0427e3501e9f6d5d8af7 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/Candidate.java 
> f679d92e6ede869e5b374c80b261ba7e83858152 
>

Review Request 41777: Use slf4j throughout the scheduler.

2015-12-29 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41777/
---

Review request for Aurora, John Sirois and Zameer Manji.


Repository: aurora


Description
---

slf4j allows us to isolate the decision and configuration of our logging 
backend.

Apologies for the monster patch.  Most of this is pretty mechanical (and was 
automated), however.


Diffs
-

  
commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java 
3ff3474dc3c8536758a0a0b3e05587daa7cde3eb 
  commons/src/main/java/org/apache/aurora/common/application/Lifecycle.java 
a71a51d2fa9465926df5b1232f450767df150847 
  
commons/src/main/java/org/apache/aurora/common/application/ShutdownRegistry.java
 b440e7e6a2b26533d0ce52bf0ffb21735ef6352f 
  commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java 
c98ed8750cf8306593587f28bf8f3e76a01b6254 
  commons/src/main/java/org/apache/aurora/common/args/Args.java 
db8e1694a81a5791d13f8d5c6cfa5f489209e82f 
  commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java 
ddffdf9c8d41166fee49866a3b7fbc2efd6bbe54 
  commons/src/main/java/org/apache/aurora/common/args/parsers/ListParser.java 
676f88be9a8f9d3f743ee9e62f133470cb84df6b 
  commons/src/main/java/org/apache/aurora/common/args/parsers/SetParser.java 
75031f49c7a509f55edc0f7d624dfcc7a0bd2930 
  commons/src/main/java/org/apache/aurora/common/collections/Iterables2.java 
7ae80ce7193717fd82dc59a346d07cba0d10e4cb 
  commons/src/main/java/org/apache/aurora/common/inject/TimedInterceptor.java 
684e7bb885fcd142e926b4e68c25323e465624fb 
  
commons/src/main/java/org/apache/aurora/common/net/InetSocketAddressHelper.java 
b3719d8f71679f7165631fd6cd4f18a93d5f871a 
  
commons/src/main/java/org/apache/aurora/common/net/http/handlers/AbortHandler.java
 42e668d09e52bdeb50a05ee7000b7f51e3160104 
  
commons/src/main/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParams.java
 c09be674d65010dfbc73fe09d8051558d236001c 
  
commons/src/main/java/org/apache/aurora/common/net/http/handlers/LogConfig.java 
c3fd80863e66f50023647c25e47e4406e89a7fa9 
  
commons/src/main/java/org/apache/aurora/common/net/http/handlers/QuitHandler.java
 40872e2778b9f3cb05e58be22a1ad4e31b3e1b3e 
  commons/src/main/java/org/apache/aurora/common/stats/JvmStats.java 
d1b072d14556be00bf2b6e06019b696c7c3235e3 
  commons/src/main/java/org/apache/aurora/common/stats/Percentile.java 
d8046b635b1ac5d816457430fb75ea17a6f46fde 
  commons/src/main/java/org/apache/aurora/common/stats/Rate.java 
dbb90c45fed4ba2c7b97c6e14646345f6fc430f7 
  commons/src/main/java/org/apache/aurora/common/stats/RequestStats.java 
5467810e3ac546b007ae8436ffe8c8dce9231eef 
  commons/src/main/java/org/apache/aurora/common/stats/SlidingStats.java 
334167275bdbd4f494b8e89c3b2575c21946a29e 
  commons/src/main/java/org/apache/aurora/common/stats/Stats.java 
d4b6a3133c5ece40a398d8cfe605627d2344f0a8 
  commons/src/main/java/org/apache/aurora/common/stats/TimeSeries.java 
45f604c76ea255de3c805a6a48406bcd3e587838 
  
commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
 6b237fbf7d308150c8dd12f7e25e2bd6aca900ab 
  commons/src/main/java/org/apache/aurora/common/util/BackoffHelper.java 
b251e9b84aa33c7c1e1366aaf8872a367864e408 
  commons/src/main/java/org/apache/aurora/common/util/BuildInfo.java 
4f9c3847bc64c80e64bd3c04ea8df3ae44716947 
  commons/src/main/java/org/apache/aurora/common/util/StateMachine.java 
dbaaadde9aa821e2293656bd48afc47816e900a2 
  
commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java 
fd74b9f37c6cc24c7ea1cb239ba6354661d931e2 
  
commons/src/main/java/org/apache/aurora/common/util/templating/StringTemplateHelper.java
 2756af49c7702ac1343712476e138fd4367aa756 
  commons/src/main/java/org/apache/aurora/common/util/testing/FakeClock.java 
2ed8b15686e0bfc6310c0427e3501e9f6d5d8af7 
  commons/src/main/java/org/apache/aurora/common/zookeeper/Candidate.java 
f679d92e6ede869e5b374c80b261ba7e83858152 
  commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java 
bb0a48d3d8e55fd95b07bc7a0999aa6a3d2fe691 
  commons/src/main/java/org/apache/aurora/common/zookeeper/Group.java 
d3681700e7f993da711f3b1ac87dc0335075cf71 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java 
cfeac921fcc70917a6b252e6637ee8e12f1fc3c1 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java 
6a0a314ffc27e73024ac8ac7c9e3a7ba83567c3a 
  
commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonService.java 
231aa911693134213b60e477ad12fbebe3c69da6 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 
e399d38a8600f43439a819d0a225477a62eb2285 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java 
a8dcfa1132178fa15774426b8430ff8e13a7a730