Re: Review Request 41778: Proposal: simplify test BUILD files to one target per directory.

2015-12-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41778/#review112223 --- I'm generally ok with this this. The main benefit of smaller

Re: Review Request 41778: Proposal: simplify test BUILD files to one target per directory.

2015-12-29 Thread Bill Farner
> On Dec. 29, 2015, 1:46 p.m., Bill Farner wrote: > > src/test/python/apache/aurora/client/api/BUILD, line 81 > > > > > > Thinking out loud - i'm guessing this doesn't do what i want and roll > > up the tests within

Re: Review Request 41778: Proposal: simplify test BUILD files to one target per directory.

2015-12-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41778/#review112226 --- Thanks for the quick feedback. Sounds like there's enough

Re: Review Request 41778: Proposal: simplify test BUILD files to one target per directory.

2015-12-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41778/#review112220 --- src/test/python/apache/aurora/client/api/BUILD (line 24)

Re: Review Request 41778: Proposal: simplify test BUILD files to one target per directory.

2015-12-29 Thread John Sirois
> On Dec. 29, 2015, 2:46 p.m., Bill Farner wrote: > > src/test/python/apache/aurora/client/api/BUILD, line 81 > > > > > > Thinking out loud - i'm guessing this doesn't do what i want and roll > > up the tests within

Review Request 41778: Proposal: simplify test BUILD files to one target per directory.

2015-12-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41778/ --- Review request for Aurora, John Sirois and Zameer Manji. Repository: aurora

Re: Review Request 41778: Proposal: simplify test BUILD files to one target per directory.

2015-12-29 Thread Bill Farner
> On Dec. 29, 2015, 1:46 p.m., Bill Farner wrote: > > src/test/python/apache/aurora/client/api/BUILD, line 81 > > > > > > Thinking out loud - i'm guessing this doesn't do what i want and roll > > up the tests within

Re: Review Request 41778: Proposal: simplify test BUILD files to one target per directory.

2015-12-29 Thread John Sirois
> On Dec. 29, 2015, 2:54 p.m., Joshua Cohen wrote: > > I'm generally ok with this this. The main benefit of smaller target groups > > is faster test runs, but tbh, I've probably spent more time looking up > > which smaller target has the tests I want to run than I've saved ;). And - fwiw, the