Re: Review Request 41809: Allow custom announce path

2016-01-06 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41809/#review113115 ---

Re: Review Request 41809: Allow custom announce path

2016-01-06 Thread Kunal Thakar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41809/ --- (Updated Jan. 6, 2016, 9:07 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 41809: Allow custom announce path

2016-01-06 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41809/#review113181 --- Ship it! Ship It! - Bill Farner On Jan. 6, 2016, 12:47 p.m.,

Re: Review Request 41809: Allow custom announce path

2016-01-06 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41809/#review113135 --- Ship it! Ship It! - Joshua Cohen On Jan. 6, 2016, 8:47 p.m.,

Re: Review Request 41809: Allow custom announce path

2016-01-06 Thread Kunal Thakar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41809/ --- (Updated Jan. 6, 2016, 8:47 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 41809: Allow custom announce path

2016-01-05 Thread Kunal Thakar
> On Jan. 4, 2016, 11:13 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/config/schema/base.py, line 102 > > > > > > This comment does somewhat imply that I can use a path containing > > variables. Also

Re: Review Request 41809: Allow custom announce path

2016-01-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41809/#review112921 --- Master (b9d9ee3) is red with this patch.

Re: Review Request 41809: Allow custom announce path

2016-01-05 Thread Kunal Thakar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41809/ --- (Updated Jan. 5, 2016, 9:33 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 41809: Allow custom announce path

2016-01-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41809/#review112937 --- Ship it! Master (b9d9ee3) is green with this patch.

Re: Review Request 41809: Allow custom announce path

2016-01-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41809/#review112653 --- Ship it! Master (8706a78) is green with this patch.

Re: Review Request 41809: Allow custom announce path

2016-01-04 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41809/#review112675 --- src/main/python/apache/aurora/config/schema/base.py (line 102)

Re: Review Request 41809: Allow custom announce path

2016-01-04 Thread Kunal Thakar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41809/ --- (Updated Jan. 4, 2016, 9:26 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 41809: Allow custom announce path

2016-01-04 Thread Kunal Thakar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41809/ --- (Updated Jan. 4, 2016, 9:28 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 41809: Allow custom announce path

2015-12-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41809/#review112352 --- Pausing review here - in-flight discussion on the linked ticket.