Re: Review Request 41844: Update and slightly extend the beginner tutorial
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41844/#review113186 --- Ship it! Sorry for the delay, committing this now! - Bill Farner On Jan. 3, 2016, 12:42 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41844/ > --- > > (Updated Jan. 3, 2016, 12:42 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > --- > > Goal is to bring the tutorial up to date. Included changes: > > * Update screenshots to match the new Aurora UI where necessary > * Fix job vs service mismatch by adapting the descirption to account for > throttling > * Some slight adaptations here and there but mostly no new content was added > * Some minior missing corrections from https://reviews.apache.org/r/41732/ > > > Diffs > - > > README.md 52d850cb90272d4311f7560a94d0bb50dac5b1a6 > docs/README.md 55dc4db1dd1222989f92e11d05f0b2a7f7591bd6 > docs/developing-aurora-scheduler.md > 40e123d6fb9e84288679e2a85e0ab741f7117600 > docs/images/CompletedTasks.png PRE-CREATION > docs/images/HelloWorldJob.png 7a8957594348ac227c8860d57c8d7b8365a67749 > docs/images/RoleJobs.png d41ee0bc1e6dfbc42d50e4a675dda0a47e1f1cd2 > docs/images/RunningJob.png PRE-CREATION > docs/images/ScheduledJobs.png 21bfcae2f636d2032c30c63f91df08d6fa1b65ad > docs/images/TaskBreakdown.png 125a4e9e07fe66c680a4c39388938ac5ed593c5e > docs/images/killedtask.png b173698ef83e52ea19b818e6d06da9211f5cc637 > docs/images/runningtask.png 7f7553cc9d06204b8ea12b01b275def586d0499f > docs/images/stderr.png b83ccfa36850c080a00faf139e13b0252ec4f21c > docs/images/stdout.png fb4e0b7b7550e98011ea5ced5738fdc01c2ff731 > docs/tools.md c14aa2e5a00f72dff11d68e2600923925af6809c > docs/tutorial.md 1bdc1ca3f3cc87efd27a517c6d54d58a03ceee71 > examples/vagrant/test_tutorial.sh 4628241d7baa507fc17414d7cdb40e76e6d609a5 > > Diff: https://reviews.apache.org/r/41844/diff/ > > > Testing > --- > > Rendered version is available at > https://github.com/StephanErb/aurora/blob/tutorial/docs/tutorial.md > > > Thanks, > > Stephan Erb > >
Re: Review Request 41844: Update and slightly extend the beginner tutorial
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41844/#review112477 --- This patch does not apply cleanly against master (5b46fd1), do you need to rebase? I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 3, 2016, 8:42 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41844/ > --- > > (Updated Jan. 3, 2016, 8:42 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > --- > > Goal is to bring the tutorial up to date. Included changes: > > * Update screenshots to match the new Aurora UI where necessary > * Fix job vs service mismatch by adapting the descirption to account for > throttling > * Some slight adaptations here and there but mostly no new content was added > * Some minior missing corrections from https://reviews.apache.org/r/41732/ > > > Diffs > - > > README.md 52d850cb90272d4311f7560a94d0bb50dac5b1a6 > docs/README.md 55dc4db1dd1222989f92e11d05f0b2a7f7591bd6 > docs/developing-aurora-scheduler.md > 40e123d6fb9e84288679e2a85e0ab741f7117600 > docs/images/CompletedTasks.png PRE-CREATION > docs/images/HelloWorldJob.png 7a8957594348ac227c8860d57c8d7b8365a67749 > docs/images/RoleJobs.png d41ee0bc1e6dfbc42d50e4a675dda0a47e1f1cd2 > docs/images/RunningJob.png PRE-CREATION > docs/images/ScheduledJobs.png 21bfcae2f636d2032c30c63f91df08d6fa1b65ad > docs/images/TaskBreakdown.png 125a4e9e07fe66c680a4c39388938ac5ed593c5e > docs/images/killedtask.png b173698ef83e52ea19b818e6d06da9211f5cc637 > docs/images/runningtask.png 7f7553cc9d06204b8ea12b01b275def586d0499f > docs/images/stderr.png b83ccfa36850c080a00faf139e13b0252ec4f21c > docs/images/stdout.png fb4e0b7b7550e98011ea5ced5738fdc01c2ff731 > docs/tools.md c14aa2e5a00f72dff11d68e2600923925af6809c > docs/tutorial.md 1bdc1ca3f3cc87efd27a517c6d54d58a03ceee71 > examples/vagrant/test_tutorial.sh 4628241d7baa507fc17414d7cdb40e76e6d609a5 > > Diff: https://reviews.apache.org/r/41844/diff/ > > > Testing > --- > > Rendered version is available at > https://github.com/StephanErb/aurora/blob/tutorial/docs/tutorial.md > > > Thanks, > > Stephan Erb > >
Re: Review Request 41844: Update and slightly extend the beginner tutorial
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41844/ --- (Updated Jan. 3, 2016, 9:42 p.m.) Review request for Aurora and Bill Farner. Changes --- Updated the patch and pushed to a new branch. This should now do the trick: `curl -sSL https://github.com/apache/aurora/compare/master...StephanErb:tutorial.patch | git am -3` Repository: aurora Description --- Goal is to bring the tutorial up to date. Included changes: * Update screenshots to match the new Aurora UI where necessary * Fix job vs service mismatch by adapting the descirption to account for throttling * Some slight adaptations here and there but mostly no new content was added * Some minior missing corrections from https://reviews.apache.org/r/41732/ Diffs (updated) - README.md 52d850cb90272d4311f7560a94d0bb50dac5b1a6 docs/README.md 55dc4db1dd1222989f92e11d05f0b2a7f7591bd6 docs/developing-aurora-scheduler.md 40e123d6fb9e84288679e2a85e0ab741f7117600 docs/images/CompletedTasks.png PRE-CREATION docs/images/HelloWorldJob.png 7a8957594348ac227c8860d57c8d7b8365a67749 docs/images/RoleJobs.png d41ee0bc1e6dfbc42d50e4a675dda0a47e1f1cd2 docs/images/RunningJob.png PRE-CREATION docs/images/ScheduledJobs.png 21bfcae2f636d2032c30c63f91df08d6fa1b65ad docs/images/TaskBreakdown.png 125a4e9e07fe66c680a4c39388938ac5ed593c5e docs/images/killedtask.png b173698ef83e52ea19b818e6d06da9211f5cc637 docs/images/runningtask.png 7f7553cc9d06204b8ea12b01b275def586d0499f docs/images/stderr.png b83ccfa36850c080a00faf139e13b0252ec4f21c docs/images/stdout.png fb4e0b7b7550e98011ea5ced5738fdc01c2ff731 docs/tools.md c14aa2e5a00f72dff11d68e2600923925af6809c docs/tutorial.md 1bdc1ca3f3cc87efd27a517c6d54d58a03ceee71 examples/vagrant/test_tutorial.sh 4628241d7baa507fc17414d7cdb40e76e6d609a5 Diff: https://reviews.apache.org/r/41844/diff/ Testing (updated) --- Rendered version is available at https://github.com/StephanErb/aurora/blob/tutorial/docs/tutorial.md Thanks, Stephan Erb
Re: Review Request 41844: Update and slightly extend the beginner tutorial
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41844/#review112464 --- This is great, thanks for the cleanup! Can you rebase your branch on GitHub? I'm failing to cleanly apply the patch: ``` $ curl -sSL https://github.com/apache/aurora/compare/master...StephanErb:docu-update.patch | git am -3 Applying: Add Aurora logo Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... No changes -- Patch already applied. Applying: Add logo to README/github frontpage Using index info to reconstruct a base tree... M README.md :15: trailing whitespace. It supports running long-running services, cron jobs, and ad-hoc jobs. warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging README.md CONFLICT (content): Merge conflict in README.md Failed to merge in the changes. Patch failed at 0002 Add logo to README/github frontpage ``` - Bill Farner On Jan. 1, 2016, 4:28 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41844/ > --- > > (Updated Jan. 1, 2016, 4:28 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > --- > > Goal is to bring the tutorial up to date. Included changes: > > * Update screenshots to match the new Aurora UI where necessary > * Fix job vs service mismatch by adapting the descirption to account for > throttling > * Some slight adaptations here and there but mostly no new content was added > * Some minior missing corrections from https://reviews.apache.org/r/41732/ > > > Diffs > - > > README.md 52d850cb90272d4311f7560a94d0bb50dac5b1a6 > docs/README.md 1312d704575a6c4b611d7acf16eda98b1814c78f > docs/developing-aurora-scheduler.md > 40e123d6fb9e84288679e2a85e0ab741f7117600 > docs/images/CompletedTasks.png PRE-CREATION > docs/images/HelloWorldJob.png 7a8957594348ac227c8860d57c8d7b8365a67749 > docs/images/RoleJobs.png d41ee0bc1e6dfbc42d50e4a675dda0a47e1f1cd2 > docs/images/RunningJob.png PRE-CREATION > docs/images/ScheduledJobs.png 21bfcae2f636d2032c30c63f91df08d6fa1b65ad > docs/images/TaskBreakdown.png 125a4e9e07fe66c680a4c39388938ac5ed593c5e > docs/images/aurora_logo.png abcfbb840ba610f752bbcd2db47fb46c984822f3 > docs/images/killedtask.png b173698ef83e52ea19b818e6d06da9211f5cc637 > docs/images/runningtask.png 7f7553cc9d06204b8ea12b01b275def586d0499f > docs/images/stderr.png b83ccfa36850c080a00faf139e13b0252ec4f21c > docs/images/stdout.png fb4e0b7b7550e98011ea5ced5738fdc01c2ff731 > docs/tools.md c14aa2e5a00f72dff11d68e2600923925af6809c > docs/tutorial.md 1bdc1ca3f3cc87efd27a517c6d54d58a03ceee71 > examples/vagrant/test_tutorial.sh 4628241d7baa507fc17414d7cdb40e76e6d609a5 > > Diff: https://reviews.apache.org/r/41844/diff/ > > > Testing > --- > > Rendered version is available at > https://github.com/StephanErb/aurora/blob/docu-update/docs/tutorial.md > > > Thanks, > > Stephan Erb > >
Re: Review Request 41844: Update and slightly extend the beginner tutorial
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41844/#review112423 --- This patch does not apply cleanly against master (4a9f2ff), do you need to rebase? I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 2, 2016, 12:28 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41844/ > --- > > (Updated Jan. 2, 2016, 12:28 a.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > --- > > Goal is to bring the tutorial up to date. Included changes: > > * Update screenshots to match the new Aurora UI where necessary > * Fix job vs service mismatch by adapting the descirption to account for > throttling > * Some slight adaptations here and there but mostly no new content was added > * Some minior missing corrections from https://reviews.apache.org/r/41732/ > > > Diffs > - > > README.md 52d850cb90272d4311f7560a94d0bb50dac5b1a6 > docs/README.md 1312d704575a6c4b611d7acf16eda98b1814c78f > docs/developing-aurora-scheduler.md > 40e123d6fb9e84288679e2a85e0ab741f7117600 > docs/images/CompletedTasks.png PRE-CREATION > docs/images/HelloWorldJob.png 7a8957594348ac227c8860d57c8d7b8365a67749 > docs/images/RoleJobs.png d41ee0bc1e6dfbc42d50e4a675dda0a47e1f1cd2 > docs/images/RunningJob.png PRE-CREATION > docs/images/ScheduledJobs.png 21bfcae2f636d2032c30c63f91df08d6fa1b65ad > docs/images/TaskBreakdown.png 125a4e9e07fe66c680a4c39388938ac5ed593c5e > docs/images/aurora_logo.png abcfbb840ba610f752bbcd2db47fb46c984822f3 > docs/images/killedtask.png b173698ef83e52ea19b818e6d06da9211f5cc637 > docs/images/runningtask.png 7f7553cc9d06204b8ea12b01b275def586d0499f > docs/images/stderr.png b83ccfa36850c080a00faf139e13b0252ec4f21c > docs/images/stdout.png fb4e0b7b7550e98011ea5ced5738fdc01c2ff731 > docs/tools.md c14aa2e5a00f72dff11d68e2600923925af6809c > docs/tutorial.md 1bdc1ca3f3cc87efd27a517c6d54d58a03ceee71 > examples/vagrant/test_tutorial.sh 4628241d7baa507fc17414d7cdb40e76e6d609a5 > > Diff: https://reviews.apache.org/r/41844/diff/ > > > Testing > --- > > Rendered version is available at > https://github.com/StephanErb/aurora/blob/docu-update/docs/tutorial.md > > > Thanks, > > Stephan Erb > >
Review Request 41844: Update and slightly extend the beginner tutorial
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41844/ --- Review request for Aurora and Bill Farner. Repository: aurora Description --- Goal is to bring the tutorial up to date. Included changes: * Update screenshots to match the new Aurora UI where necessary * Fix job vs service mismatch by adapting the descirption to account for throttling * Some slight adaptations here and there but mostly no new content was added * Some minior missing corrections from https://reviews.apache.org/r/41732/ Diffs - README.md 52d850cb90272d4311f7560a94d0bb50dac5b1a6 docs/README.md 1312d704575a6c4b611d7acf16eda98b1814c78f docs/developing-aurora-scheduler.md 40e123d6fb9e84288679e2a85e0ab741f7117600 docs/images/CompletedTasks.png PRE-CREATION docs/images/HelloWorldJob.png 7a8957594348ac227c8860d57c8d7b8365a67749 docs/images/RoleJobs.png d41ee0bc1e6dfbc42d50e4a675dda0a47e1f1cd2 docs/images/RunningJob.png PRE-CREATION docs/images/ScheduledJobs.png 21bfcae2f636d2032c30c63f91df08d6fa1b65ad docs/images/TaskBreakdown.png 125a4e9e07fe66c680a4c39388938ac5ed593c5e docs/images/aurora_logo.png abcfbb840ba610f752bbcd2db47fb46c984822f3 docs/images/killedtask.png b173698ef83e52ea19b818e6d06da9211f5cc637 docs/images/runningtask.png 7f7553cc9d06204b8ea12b01b275def586d0499f docs/images/stderr.png b83ccfa36850c080a00faf139e13b0252ec4f21c docs/images/stdout.png fb4e0b7b7550e98011ea5ced5738fdc01c2ff731 docs/tools.md c14aa2e5a00f72dff11d68e2600923925af6809c docs/tutorial.md 1bdc1ca3f3cc87efd27a517c6d54d58a03ceee71 examples/vagrant/test_tutorial.sh 4628241d7baa507fc17414d7cdb40e76e6d609a5 Diff: https://reviews.apache.org/r/41844/diff/ Testing --- Rendered version is available at https://github.com/StephanErb/aurora/blob/docu-update/docs/tutorial.md Thanks, Stephan Erb