Re: Review Request 42375: Make required mesos log args required.

2016-01-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42375/#review115034 --- Ship it! Ship It! - Bill Farner On Jan. 17, 2016, 3:42 p.m., Jo

Re: Review Request 42375: Make required mesos log args required.

2016-01-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42375/#review114840 --- Master (b563679) is green with this patch. ./build-support/jenkin

Re: Review Request 42375: Make required mesos log args required.

2016-01-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42375/ --- (Updated Jan. 15, 2016, 8:41 p.m.) Review request for Aurora, Dmitriy Shirchenk

Re: Review Request 42375: Make required mesos log args required.

2016-01-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42375/ --- (Updated Jan. 15, 2016, 8:35 p.m.) Review request for Aurora, Dmitriy Shirchenk

Re: Review Request 42375: Make required mesos log args required.

2016-01-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42375/ --- (Updated Jan. 15, 2016, 8:35 p.m.) Review request for Aurora, Dmitriy Shirchenk

Re: Review Request 42375: Make required mesos log args required.

2016-01-15 Thread Bill Farner
> On Jan. 15, 2016, 5:09 p.m., Bill Farner wrote: > > I believe this will break invocation of the application that don't use the > > replicated log, for example `./gradlew run`. > > John Sirois wrote: > Yes - thanks for pointing out `./gradlew run`. This is a bit of a nasty > situation th

Re: Review Request 42375: Make required mesos log args required.

2016-01-15 Thread John Sirois
> On Jan. 15, 2016, 6:09 p.m., Bill Farner wrote: > > I believe this will break invocation of the application that don't use the > > replicated log, for example `./gradlew run`. Yes - thanks for pointing out `./gradlew run`. This is a bit of a nasty situation that would ideally be solved with

Re: Review Request 42375: Make required mesos log args required.

2016-01-15 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42375/#review114827 --- Ship it! Ship It! - Dmitriy Shirchenko On Jan. 16, 2016, 12:40

Re: Review Request 42375: Make required mesos log args required.

2016-01-15 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42375/#review114826 --- Ship it! Ship It! - Zameer Manji On Jan. 15, 2016, 4:40 p.m., J

Re: Review Request 42375: Make required mesos log args required.

2016-01-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42375/#review114823 --- I believe this will break invocation of the application that don't

Re: Review Request 42375: Make required mesos log args required.

2016-01-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42375/#review114821 --- Master (b563679) is green with this patch. ./build-support/jenkin

Review Request 42375: Make required mesos log args required.

2016-01-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42375/ --- Review request for Aurora, Dmitriy Shirchenko and Zameer Manji. Bugs: AURORA-15