Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

> On Jan. 21, 2016, 6:44 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java, > > line 80 > > > > > > Just to be clear, this command line argument will on

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

> On Jan. 21, 2016, 6:44 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java, > > line 80 > > > > > > Just to be clear, this command line argument will on

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

> On Jan. 22, 2016, 2:44 a.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java, > > line 80 > > > > > > Just to be clear, this command line argument will on

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

> On Jan. 21, 2016, 6:44 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java, > > line 80 > > > > > > Just to be clear, this command line argument will on

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

> On Jan. 21, 2016, 7:44 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java, > > line 80 > > > > > > Just to be clear, this command line argument will on

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

> On Jan. 21, 2016, 7:44 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java, > > line 80 > > > > > > Just to be clear, this command line argument will on

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

> On Jan. 21, 2016, 7:44 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java, > > line 80 > > > > > > Just to be clear, this command line argument will on

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

> On Jan. 22, 2016, 2:44 a.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java, > > line 80 > > > > > > Just to be clear, this command line argument will on

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

> On Jan. 21, 2016, 6:44 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java, > > line 80 > > > > > > Just to be clear, this command line argument will on

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

> On Jan. 22, 2016, 2:44 a.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java, > > line 80 > > > > > > Just to be clear, this command line argument will on

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

> On Jan. 21, 2016, 6:44 p.m., Zameer Manji wrote: > > My primary objection to this review is to how it changes the security > > configuration. I'm +1 to the idea of not accepting modules on the CLI for > > the reasons specified in the review summary and because I think accepting a > > bunch o

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

> On Jan. 21, 2016, 6:44 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java, > > line 80 > > > > > > Just to be clear, this command line argument will on

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42565/#review115765 --- My primary objection to this review is to how it changes the securi

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42565/#review115501 --- Ship it! Master (8d3fb24) is green with this patch. ./build-supp

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42565/ --- (Updated Jan. 20, 2016, 12:21 p.m.) Review request for Aurora, John Sirois and

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

> On Jan. 20, 2016, 12:02 p.m., John Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java, > > line 81 > > > > > > So if I installed a single custom Module in the past

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42565/#review115469 --- Ship it! If my 1st comment below is basically on target, this all

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42565/#review115470 --- Ship it! Master (8d3fb24) is green with this patch. ./build-supp

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42565/#review115466 --- src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java (

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42565/ --- (Updated Jan. 20, 2016, 11:47 a.m.) Review request for Aurora, John Sirois and

Review Request 42565: Remove support for adding guice modules via command line arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42565/ --- Review request for Aurora, John Sirois and Zameer Manji. Repository: aurora D