Re: Review Request 42845: Enable H2 logging to slf4j.

2016-01-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42845/#review116634 --- Master (e2a973e) is green with this patch.

Re: Review Request 42845: Enable H2 logging to slf4j.

2016-01-27 Thread Bill Farner
> On Jan. 27, 2016, 9:56 a.m., Bill Farner wrote: > > Are you sure this patch does what you want? When i apply the patch and run > > the scheduler in vagrant, the `h2database` logger shows as level `WARN` in > > `/logconfig`. When at level `DEBUG`, there is likely far more verbose you > >

Re: Review Request 42845: Enable H2 logging to slf4j.

2016-01-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42845/#review116602 --- Are you sure this patch does what you want? When i apply the

Re: Review Request 42845: Enable H2 logging to slf4j.

2016-01-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42845/#review116604 --- Ship it! Fine to ship, suggested a bit of minor cleanup.

Re: Review Request 42845: Enable H2 logging to slf4j.

2016-01-27 Thread Zameer Manji
> On Jan. 27, 2016, 10:41 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, lines > > 118-119 > > > > > > Please change this to explain that level 4 indicates intent

Re: Review Request 42845: Enable H2 logging to slf4j.

2016-01-27 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42845/ --- (Updated Jan. 27, 2016, 1:38 p.m.) Review request for Aurora, Maxim

Re: Review Request 42845: Enable H2 logging to slf4j.

2016-01-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42845/#review116630 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 27, 2016,

Review Request 42845: Enable H2 logging to slf4j.

2016-01-26 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42845/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: