Re: Review Request 42975: Change the way arguments are passed to scheduler in debian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42975/#review117014 --- Ship it! Ship It! - Bill Farner On Jan. 29, 2016, 12:17 p.m., Kunal Thakar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42975/ > --- > > (Updated Jan. 29, 2016, 12:17 p.m.) > > > Review request for Aurora, John Sirois, Dmitriy Shirchenko, and Bill Farner. > > > Repository: aurora-packaging > > > Description > --- > > The scheduler is unable to start when one of the parameters contains spaces. > The -thermos-executor-flags param is a string and it doesn't get passed along > as a string if we don't surround the variable with quotes > (http://unix.stackexchange.com/questions/131766/why-does-my-shell-script-choke-on-whitespace-or-other-special-characters) > > Also, added the rbt files to allow posting CRs from this repo > > > Diffs > - > > .gitignore 81746232328d6bc4d448a0ce4654174d86972263 > build-support/virtualenv PRE-CREATION > rbt PRE-CREATION > specs/debian/aurora-scheduler.init b280c75860bfdd878c409f282a675b1d52b08729 > > Diff: https://reviews.apache.org/r/42975/diff/ > > > Testing > --- > > Built the artifacts and tested the new debian package by following the > instructions in test/deb/debian-jessie. > > To simulate the failure in the previous version, modify > /etc/default/aurora-scheduler on the test vagrant box: > > THERMOS_EXECUTOR_FLAGS="--enable-announcer --announcer-ensemble > localhost:2181" > > After replacing that line, restart the scheduler. > sudo systemctl restart aurora-scheduler (it should fail without this change) > > > Thanks, > > Kunal Thakar > >
Re: Review Request 42975: Change the way arguments are passed to scheduler in debian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42975/#review117007 --- Ship it! Ship It! - Dmitriy Shirchenko On Jan. 29, 2016, 8:17 p.m., Kunal Thakar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42975/ > --- > > (Updated Jan. 29, 2016, 8:17 p.m.) > > > Review request for Aurora, John Sirois, Dmitriy Shirchenko, and Bill Farner. > > > Repository: aurora-packaging > > > Description > --- > > The scheduler is unable to start when one of the parameters contains spaces. > The -thermos-executor-flags param is a string and it doesn't get passed along > as a string if we don't surround the variable with quotes > (http://unix.stackexchange.com/questions/131766/why-does-my-shell-script-choke-on-whitespace-or-other-special-characters) > > Also, added the rbt files to allow posting CRs from this repo > > > Diffs > - > > .gitignore 81746232328d6bc4d448a0ce4654174d86972263 > build-support/virtualenv PRE-CREATION > rbt PRE-CREATION > specs/debian/aurora-scheduler.init b280c75860bfdd878c409f282a675b1d52b08729 > > Diff: https://reviews.apache.org/r/42975/diff/ > > > Testing > --- > > Built the artifacts and tested the new debian package by following the > instructions in test/deb/debian-jessie. > > To simulate the failure in the previous version, modify > /etc/default/aurora-scheduler on the test vagrant box: > > THERMOS_EXECUTOR_FLAGS="--enable-announcer --announcer-ensemble > localhost:2181" > > After replacing that line, restart the scheduler. > sudo systemctl restart aurora-scheduler (it should fail without this change) > > > Thanks, > > Kunal Thakar > >
Re: Review Request 42975: Change the way arguments are passed to scheduler in debian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42975/#review117003 --- Ship it! Ship It! - John Sirois On Jan. 29, 2016, 1:17 p.m., Kunal Thakar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42975/ > --- > > (Updated Jan. 29, 2016, 1:17 p.m.) > > > Review request for Aurora, John Sirois, Dmitriy Shirchenko, and Bill Farner. > > > Repository: aurora-packaging > > > Description > --- > > The scheduler is unable to start when one of the parameters contains spaces. > The -thermos-executor-flags param is a string and it doesn't get passed along > as a string if we don't surround the variable with quotes > (http://unix.stackexchange.com/questions/131766/why-does-my-shell-script-choke-on-whitespace-or-other-special-characters) > > Also, added the rbt files to allow posting CRs from this repo > > > Diffs > - > > .gitignore 81746232328d6bc4d448a0ce4654174d86972263 > build-support/virtualenv PRE-CREATION > rbt PRE-CREATION > specs/debian/aurora-scheduler.init b280c75860bfdd878c409f282a675b1d52b08729 > > Diff: https://reviews.apache.org/r/42975/diff/ > > > Testing > --- > > Built the artifacts and tested the new debian package by following the > instructions in test/deb/debian-jessie. > > To simulate the failure in the previous version, modify > /etc/default/aurora-scheduler on the test vagrant box: > > THERMOS_EXECUTOR_FLAGS="--enable-announcer --announcer-ensemble > localhost:2181" > > After replacing that line, restart the scheduler. > sudo systemctl restart aurora-scheduler (it should fail without this change) > > > Thanks, > > Kunal Thakar > >
Review Request 42975: Change the way arguments are passed to scheduler in debian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42975/ --- Review request for Aurora, John Sirois, Dmitriy Shirchenko, and Bill Farner. Repository: aurora-packaging Description --- The scheduler is unable to start when one of the parameters contains spaces. The -thermos-executor-flags param is a string and it doesn't get passed along as a string if we don't surround the variable with quotes (http://unix.stackexchange.com/questions/131766/why-does-my-shell-script-choke-on-whitespace-or-other-special-characters) Also, added the rbt files to allow posting CRs from this repo Diffs - .gitignore 81746232328d6bc4d448a0ce4654174d86972263 build-support/virtualenv PRE-CREATION rbt PRE-CREATION specs/debian/aurora-scheduler.init b280c75860bfdd878c409f282a675b1d52b08729 Diff: https://reviews.apache.org/r/42975/diff/ Testing --- Built the artifacts and tested the new debian package by following the instructions in test/deb/debian-jessie. To simulate the failure in the previous version, modify /etc/default/aurora-scheduler on the test vagrant box: THERMOS_EXECUTOR_FLAGS="--enable-announcer --announcer-ensemble localhost:2181" After replacing that line, restart the scheduler. sudo systemctl restart aurora-scheduler (it should fail without this change) Thanks, Kunal Thakar
