Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/#review117520
---



This is on master now.

- Zameer Manji


On Feb. 2, 2016, 3:24 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43112/
> ---
> 
> (Updated Feb. 2, 2016, 3:24 p.m.)
> 
> 
> Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make --announcer-enable optional no-op instead of removing it completely.
> 
> For easy upgrade purpose.
> 
> 
> Diffs
> -
> 
>   NEWS 318979ed5e408e42df0c5a77c35a653f14bc7233 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f4f5cd77b6444c225ec960c7e2cf5349a80bd344 
> 
> Diff: https://reviews.apache.org/r/43112/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/executor:executor
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/#review117519
---


Ship it!




Ship It!

- Zameer Manji


On Feb. 2, 2016, 3:24 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43112/
> ---
> 
> (Updated Feb. 2, 2016, 3:24 p.m.)
> 
> 
> Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make --announcer-enable optional no-op instead of removing it completely.
> 
> For easy upgrade purpose.
> 
> 
> Diffs
> -
> 
>   NEWS 318979ed5e408e42df0c5a77c35a653f14bc7233 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f4f5cd77b6444c225ec960c7e2cf5349a80bd344 
> 
> Diff: https://reviews.apache.org/r/43112/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/executor:executor
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/
---

(Updated Feb. 2, 2016, 11:24 p.m.)


Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.


Changes
---

Put issue number in TODO.


Repository: aurora


Description
---

Make --announcer-enable optional no-op instead of removing it completely.

For easy upgrade purpose.


Diffs (updated)
-

  NEWS 318979ed5e408e42df0c5a77c35a653f14bc7233 
  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
f4f5cd77b6444c225ec960c7e2cf5349a80bd344 

Diff: https://reviews.apache.org/r/43112/diff/


Testing
---

./pants test src/test/python/apache/aurora/executor:executor


Thanks,

Zhitao Li

Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/#review117507
---



Master (2f485e8) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 2, 2016, 10:13 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43112/
> ---
> 
> (Updated Feb. 2, 2016, 10:13 p.m.)
> 
> 
> Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make --announcer-enable optional no-op instead of removing it completely.
> 
> For easy upgrade purpose.
> 
> 
> Diffs
> -
> 
>   NEWS 318979ed5e408e42df0c5a77c35a653f14bc7233 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f4f5cd77b6444c225ec960c7e2cf5349a80bd344 
> 
> Diff: https://reviews.apache.org/r/43112/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/executor:executor
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/#review117505
---




src/main/python/apache/aurora/executor/bin/thermos_executor_main.py (line 62)


Please reference `AURORA-1606` here.


- Zameer Manji


On Feb. 2, 2016, 2:13 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43112/
> ---
> 
> (Updated Feb. 2, 2016, 2:13 p.m.)
> 
> 
> Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make --announcer-enable optional no-op instead of removing it completely.
> 
> For easy upgrade purpose.
> 
> 
> Diffs
> -
> 
>   NEWS 318979ed5e408e42df0c5a77c35a653f14bc7233 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f4f5cd77b6444c225ec960c7e2cf5349a80bd344 
> 
> Diff: https://reviews.apache.org/r/43112/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/executor:executor
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Kunal Thakar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/#review117504
---


Ship it!




Ship It!

- Kunal Thakar


On Feb. 2, 2016, 10:13 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43112/
> ---
> 
> (Updated Feb. 2, 2016, 10:13 p.m.)
> 
> 
> Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make --announcer-enable optional no-op instead of removing it completely.
> 
> For easy upgrade purpose.
> 
> 
> Diffs
> -
> 
>   NEWS 318979ed5e408e42df0c5a77c35a653f14bc7233 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f4f5cd77b6444c225ec960c7e2cf5349a80bd344 
> 
> Diff: https://reviews.apache.org/r/43112/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/executor:executor
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Zhitao Li 


> On Feb. 2, 2016, 10:08 p.m., Bill Farner wrote:
> > Ship It!
> 
> Bill Farner wrote:
> Please also file a ticket to do the actual removal, make it a blocker for 
> https://issues.apache.org/jira/browse/AURORA-1586

https://issues.apache.org/jira/browse/AURORA-1606


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/#review117494
---


On Feb. 2, 2016, 10:13 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43112/
> ---
> 
> (Updated Feb. 2, 2016, 10:13 p.m.)
> 
> 
> Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make --announcer-enable optional no-op instead of removing it completely.
> 
> For easy upgrade purpose.
> 
> 
> Diffs
> -
> 
>   NEWS 318979ed5e408e42df0c5a77c35a653f14bc7233 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f4f5cd77b6444c225ec960c7e2cf5349a80bd344 
> 
> Diff: https://reviews.apache.org/r/43112/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/executor:executor
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/#review117502
---


Ship it!




Ship It!

- Stephan Erb


On Feb. 2, 2016, 11:13 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43112/
> ---
> 
> (Updated Feb. 2, 2016, 11:13 p.m.)
> 
> 
> Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make --announcer-enable optional no-op instead of removing it completely.
> 
> For easy upgrade purpose.
> 
> 
> Diffs
> -
> 
>   NEWS 318979ed5e408e42df0c5a77c35a653f14bc7233 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f4f5cd77b6444c225ec960c7e2cf5349a80bd344 
> 
> Diff: https://reviews.apache.org/r/43112/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/executor:executor
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/
---

(Updated Feb. 2, 2016, 10:13 p.m.)


Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.


Changes
---

Rebase to pick up NEWS change.


Repository: aurora


Description
---

Make --announcer-enable optional no-op instead of removing it completely.

For easy upgrade purpose.


Diffs (updated)
-

  NEWS 318979ed5e408e42df0c5a77c35a653f14bc7233 
  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
f4f5cd77b6444c225ec960c7e2cf5349a80bd344 

Diff: https://reviews.apache.org/r/43112/diff/


Testing
---

./pants test src/test/python/apache/aurora/executor:executor


Thanks,

Zhitao Li

Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Bill Farner 


> On Feb. 2, 2016, 2:08 p.m., Bill Farner wrote:
> > Ship It!

Please also file a ticket to do the actual removal, make it a blocker for 
https://issues.apache.org/jira/browse/AURORA-1586


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/#review117494
---


On Feb. 2, 2016, 2:07 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43112/
> ---
> 
> (Updated Feb. 2, 2016, 2:07 p.m.)
> 
> 
> Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make --announcer-enable optional no-op instead of removing it completely.
> 
> For easy upgrade purpose.
> 
> 
> Diffs
> -
> 
>   NEWS b1713602c2531ac39fc97c2044e024c21808ad63 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f4f5cd77b6444c225ec960c7e2cf5349a80bd344 
> 
> Diff: https://reviews.apache.org/r/43112/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/executor:executor
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/#review117495
---



Please rebase against master to pickup NEWS reorganization.

- John Sirois


On Feb. 2, 2016, 3:07 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43112/
> ---
> 
> (Updated Feb. 2, 2016, 3:07 p.m.)
> 
> 
> Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make --announcer-enable optional no-op instead of removing it completely.
> 
> For easy upgrade purpose.
> 
> 
> Diffs
> -
> 
>   NEWS b1713602c2531ac39fc97c2044e024c21808ad63 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f4f5cd77b6444c225ec960c7e2cf5349a80bd344 
> 
> Diff: https://reviews.apache.org/r/43112/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/executor:executor
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/#review117494
---


Ship it!




Ship It!

- Bill Farner


On Feb. 2, 2016, 2:07 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43112/
> ---
> 
> (Updated Feb. 2, 2016, 2:07 p.m.)
> 
> 
> Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make --announcer-enable optional no-op instead of removing it completely.
> 
> For easy upgrade purpose.
> 
> 
> Diffs
> -
> 
>   NEWS b1713602c2531ac39fc97c2044e024c21808ad63 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f4f5cd77b6444c225ec960c7e2cf5349a80bd344 
> 
> Diff: https://reviews.apache.org/r/43112/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/executor:executor
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/
---

Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.


Repository: aurora


Description
---

Make --announcer-enable optional no-op instead of removing it completely.

For easy upgrade purpose.


Diffs
-

  NEWS b1713602c2531ac39fc97c2044e024c21808ad63 
  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
f4f5cd77b6444c225ec960c7e2cf5349a80bd344 

Diff: https://reviews.apache.org/r/43112/diff/


Testing
---

./pants test src/test/python/apache/aurora/executor:executor


Thanks,

Zhitao Li