Re: Review Request 43262: Backfilling JobConfiguration.Identity

2016-02-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43262/#review118089 --- Ship it! Ship It! - Bill Farner On Feb. 5, 2016, 1:03 p.m.,

Re: Review Request 43262: Backfilling JobConfiguration.Identity

2016-02-05 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43262/#review118088 --- Ship it! Just relaying my homework: The last Identity use is

Re: Review Request 43262: Backfilling JobConfiguration.Identity

2016-02-05 Thread Bill Farner
> On Feb. 5, 2016, 1:08 p.m., John Sirois wrote: > > Can you note the technique you used for finding all last vestigaes of > > missing backfill in the testing done? > > Was this grep-provable as the last bit to fix for example? > > Maxim Khutornenko wrote: > That was mostly an oversight as

Re: Review Request 43262: Backfilling JobConfiguration.Identity

2016-02-05 Thread John Sirois
> On Feb. 5, 2016, 2:08 p.m., John Sirois wrote: > > Can you note the technique you used for finding all last vestigaes of > > missing backfill in the testing done? > > Was this grep-provable as the last bit to fix for example? > > Maxim Khutornenko wrote: > That was mostly an oversight as

Re: Review Request 43262: Backfilling JobConfiguration.Identity

2016-02-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43262/#review118086 --- Ship it! Master (8faf499) is green with this patch.

Re: Review Request 43262: Backfilling JobConfiguration.Identity

2016-02-05 Thread Maxim Khutornenko
> On Feb. 5, 2016, 9:48 p.m., John Sirois wrote: > > Just relaying my homework: The last Identity use is in TaskQuery, but those > > are never stored, so we're good. Yeah, that will be dropped when I un-revert https://reviews.apache.org/r/43080 - Maxim

Re: Review Request 43262: Backfilling JobConfiguration.Identity

2016-02-05 Thread Maxim Khutornenko
> On Feb. 5, 2016, 9:08 p.m., John Sirois wrote: > > Can you note the technique you used for finding all last vestigaes of > > missing backfill in the testing done? > > Was this grep-provable as the last bit to fix for example? That was mostly an oversight as we should have backfilled

Re: Review Request 43262: Backfilling JobConfiguration.Identity

2016-02-05 Thread Bill Farner
> On Feb. 5, 2016, 1:08 p.m., John Sirois wrote: > > Can you note the technique you used for finding all last vestigaes of > > missing backfill in the testing done? > > Was this grep-provable as the last bit to fix for example? > > Maxim Khutornenko wrote: > That was mostly an oversight as

Review Request 43262: Backfilling JobConfiguration.Identity

2016-02-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43262/ --- Review request for Aurora, John Sirois and Bill Farner. Bugs: AURORA-1610

Re: Review Request 43262: Backfilling JobConfiguration.Identity

2016-02-05 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43262/#review118076 --- Can you note the technique you used for finding all last