Re: Review Request 43643: Do not materialize set inside DbTaskStore#fetchTasks

2016-02-19 Thread Zameer Manji
> On Feb. 17, 2016, 1:39 a.m., Stephan Erb wrote: > > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java, > > line 567 > > > > > > Would you mind changing this test slightly and assert the

Re: Review Request 43643: Do not materialize set inside DbTaskStore#fetchTasks

2016-02-19 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43643/ --- (Updated Feb. 19, 2016, 12:44 p.m.) Review request for Aurora, John Sirois and

Re: Review Request 43643: Do not materialize set inside DbTaskStore#fetchTasks

2016-02-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43643/#review119484 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 17, 2016, 3:42

Re: Review Request 43643: Do not materialize set inside DbTaskStore#fetchTasks

2016-02-17 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43643/#review119457 --- Ship it! Ship It! - John Sirois On Feb. 16, 2016, 8:42 p.m.,

Re: Review Request 43643: Do not materialize set inside DbTaskStore#fetchTasks

2016-02-17 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43643/#review119428 --- Ship it! Great catch! One minor nitpick below. src/test/java/

Re: Review Request 43643: Do not materialize set inside DbTaskStore#fetchTasks

2016-02-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43643/#review119409 --- Ship it! Master (9d642dc) is green with this patch. ./build-s

Re: Review Request 43643: Do not materialize set inside DbTaskStore#fetchTasks

2016-02-16 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43643/ --- (Updated Feb. 16, 2016, 7:42 p.m.) Review request for Aurora, John Sirois and M

Review Request 43643: Do not materialize set inside DbTaskStore#fetchTasks

2016-02-16 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43643/ --- Review request for Aurora, John Sirois and Maxim Khutornenko. Repository: auror