Re: Review Request 44106: Do not modify list populated by MyBatis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44106/#review121006 --- Ship it! Master (7e32c43) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Feb. 26, 2016, 11:36 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44106/ > --- > > (Updated Feb. 26, 2016, 11:36 p.m.) > > > Review request for Aurora, Amol Deshmukh and Maxim Khutornenko. > > > Bugs: AURORA-1625 > https://issues.apache.org/jira/browse/AURORA-1625 > > > Repository: aurora > > > Description > --- > > A ConcurrentModificationException can occur when multiple threads are sorting > the same task event list. This is possible because we have enabled MyBatis > caching with the readOnly flag which can use the same instance to populate > different `DbScheduledTask` instances. > > > Diffs > - > > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbScheduledTask.java > 8d0dab0fa995416b462a75a33d5003aa54272854 > > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java > dc5e2bd142676e837b390e4268148831b3669941 > > Diff: https://reviews.apache.org/r/44106/diff/ > > > Testing > --- > > ./gradlew test > > > Thanks, > > Zameer Manji > >
Re: Review Request 44106: Do not modify list populated by MyBatis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44106/ --- (Updated Feb. 26, 2016, 3:36 p.m.) Review request for Aurora, Amol Deshmukh and Maxim Khutornenko. Changes --- Style Fixes Bugs: AURORA-1625 https://issues.apache.org/jira/browse/AURORA-1625 Repository: aurora Description --- A ConcurrentModificationException can occur when multiple threads are sorting the same task event list. This is possible because we have enabled MyBatis caching with the readOnly flag which can use the same instance to populate different `DbScheduledTask` instances. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/storage/db/views/DbScheduledTask.java 8d0dab0fa995416b462a75a33d5003aa54272854 src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java dc5e2bd142676e837b390e4268148831b3669941 Diff: https://reviews.apache.org/r/44106/diff/ Testing --- ./gradlew test Thanks, Zameer Manji
Re: Review Request 44106: Do not modify list populated by MyBatis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44106/#review120996 --- Ship it! Ship It! - Amol Deshmukh On Feb. 26, 2016, 3 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44106/ > --- > > (Updated Feb. 26, 2016, 3 p.m.) > > > Review request for Aurora, Amol Deshmukh and Maxim Khutornenko. > > > Bugs: AURORA-1625 > https://issues.apache.org/jira/browse/AURORA-1625 > > > Repository: aurora > > > Description > --- > > A ConcurrentModificationException can occur when multiple threads are sorting > the same task event list. This is possible because we have enabled MyBatis > caching with the readOnly flag which can use the same instance to populate > different `DbScheduledTask` instances. > > > Diffs > - > > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbScheduledTask.java > 8d0dab0fa995416b462a75a33d5003aa54272854 > > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java > dc5e2bd142676e837b390e4268148831b3669941 > > Diff: https://reviews.apache.org/r/44106/diff/ > > > Testing > --- > > ./gradlew test > > > Thanks, > > Zameer Manji > >
Review Request 44106: Do not modify list populated by MyBatis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44106/ --- Review request for Aurora, Amol Deshmukh and Maxim Khutornenko. Bugs: AURORA-1625 https://issues.apache.org/jira/browse/AURORA-1625 Repository: aurora Description --- A ConcurrentModificationException can occur when multiple threads are sorting the same task event list. This is possible because we have enabled MyBatis caching with the readOnly flag which can use the same instance to populate different `DbScheduledTask` instances. Diffs - src/main/java/org/apache/aurora/scheduler/storage/db/views/DbScheduledTask.java 8d0dab0fa995416b462a75a33d5003aa54272854 src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java dc5e2bd142676e837b390e4268148831b3669941 Diff: https://reviews.apache.org/r/44106/diff/ Testing --- ./gradlew test Thanks, Zameer Manji
