Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/#review124044 --- Master (6537581) is red with this patch.

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/#review123965 --- Fix it, then Ship it! Just one nit from me, otherwise LGTM!

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-19 Thread Kunal Thakar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/ --- (Updated March 16, 2016, 7:43 p.m.) Review request for Aurora, John Sirois,

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-19 Thread Kunal Thakar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/ --- (Updated March 18, 2016, 7:04 p.m.) Review request for Aurora, John Sirois,

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-19 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/#review124244 --- docs/configuration-reference.md (line 472)

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-19 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/#review124076 --- Ship it! Master (6537581) is green with this patch.

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-18 Thread Bill Farner
> On March 16, 2016, 6:33 p.m., Bill Farner wrote: > > Just one nit from me, otherwise LGTM! Oh, nearly forgot - please add docs! - Add a small section and blurb here describing how this would be used (i.e. write the doc you wish you had read before contributing the patch)

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/#review124258 --- Ship it! Master (12be6fb) is green with this patch.

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-15 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/#review123775 --- Fix it, then Ship it! Patch looks good, thanks for your

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-15 Thread Kunal Thakar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/ --- (Updated March 15, 2016, 6:31 p.m.) Review request for Aurora, John Sirois,

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-15 Thread Kunal Thakar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/ --- (Updated March 15, 2016, 6:29 p.m.) Review request for Aurora. Changes

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-14 Thread Bill Farner
> On March 10, 2016, 2:04 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py, line 95 > > > > > > Specifying the command here feels kind of weird. All other options we

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-13 Thread Stephan Erb
> On March 10, 2016, 11:04 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py, line 95 > > > > > > Specifying the command here feels kind of weird. All other options we

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-10 Thread Kunal Thakar
> On March 10, 2016, 10:04 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py, line 95 > > > > > > Specifying the command here feels kind of weird. All other options we

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-10 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/#review123011 ---

Review Request 44532: Allow overriding hostname before announcing

2016-03-08 Thread Kunal Thakar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/ --- Review request for Aurora. Repository: aurora Description --- Allow