Re: Review Request 45167: Fixup install docs.

2016-03-23 Thread John Sirois

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45167/#review125031
---



riceb86 - I'm going to submit this now, but I'll happily circle back and send 
up another RB to fix any issues you find and note here.

- John Sirois


On March 22, 2016, 4:40 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45167/
> ---
> 
> (Updated March 22, 2016, 4:40 p.m.)
> 
> 
> Review request for Aurora, Benjamin Rice and Stephan Erb.
> 
> 
> Bugs: AURORA-1647
> https://issues.apache.org/jira/browse/AURORA-1647
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This set of fixes eliminates the experimental rpm warnings and updates
> the rpm instructions to use the officially released packages.  The deb
> instructions are updated as well, in particular to take advantage of the
> mesosphere deb repository and with movement of special dep installations
> to the appropriate sections requiring them.
> 
> This fix RB does not address the new Debian Jessie debs, instead
> focusing on getting the existing instructions corrected.
> 
>  docs/installing.md | 101 +++---
>  1 file changed, 55 insertions(+), 46 deletions(-)
> 
> 
> Diffs
> -
> 
>   docs/installing.md c3abb332a4a46e62367a39cf73d70f2185657b5a 
> 
> Diff: https://reviews.apache.org/r/45167/diff/
> 
> 
> Testing
> ---
> 
> These changes are rendered here:
>   
> https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1647/docs/installing.md
> 
> I ran through the instructions in full in fresh Vagrant vms and was able
> to launch sample jobs (used aurora-packaging test jobs with cpu droppped to
> `0.5` and s/Service/Job/) and exercise the full UI chain to inspect the
> successful one-shot job and its sandbox & logs.
> 
> 
> Thanks,
> 
> John Sirois
> 
>



Re: Review Request 45167: Fixup install docs.

2016-03-23 Thread Stephan Erb

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45167/#review125029
---


Ship it!




Ship It!

- Stephan Erb


On March 22, 2016, 11:40 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45167/
> ---
> 
> (Updated March 22, 2016, 11:40 p.m.)
> 
> 
> Review request for Aurora, Benjamin Rice and Stephan Erb.
> 
> 
> Bugs: AURORA-1647
> https://issues.apache.org/jira/browse/AURORA-1647
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This set of fixes eliminates the experimental rpm warnings and updates
> the rpm instructions to use the officially released packages.  The deb
> instructions are updated as well, in particular to take advantage of the
> mesosphere deb repository and with movement of special dep installations
> to the appropriate sections requiring them.
> 
> This fix RB does not address the new Debian Jessie debs, instead
> focusing on getting the existing instructions corrected.
> 
>  docs/installing.md | 101 +++---
>  1 file changed, 55 insertions(+), 46 deletions(-)
> 
> 
> Diffs
> -
> 
>   docs/installing.md c3abb332a4a46e62367a39cf73d70f2185657b5a 
> 
> Diff: https://reviews.apache.org/r/45167/diff/
> 
> 
> Testing
> ---
> 
> These changes are rendered here:
>   
> https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1647/docs/installing.md
> 
> I ran through the instructions in full in fresh Vagrant vms and was able
> to launch sample jobs (used aurora-packaging test jobs with cpu droppped to
> `0.5` and s/Service/Job/) and exercise the full UI chain to inspect the
> successful one-shot job and its sandbox & logs.
> 
> 
> Thanks,
> 
> John Sirois
> 
>



Re: Review Request 45167: Fixup install docs.

2016-03-22 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45167/#review124926
---


Ship it!




Master (b5c9e1b) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 22, 2016, 10:40 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45167/
> ---
> 
> (Updated March 22, 2016, 10:40 p.m.)
> 
> 
> Review request for Aurora, Benjamin Rice and Stephan Erb.
> 
> 
> Bugs: AURORA-1647
> https://issues.apache.org/jira/browse/AURORA-1647
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This set of fixes eliminates the experimental rpm warnings and updates
> the rpm instructions to use the officially released packages.  The deb
> instructions are updated as well, in particular to take advantage of the
> mesosphere deb repository and with movement of special dep installations
> to the appropriate sections requiring them.
> 
> This fix RB does not address the new Debian Jessie debs, instead
> focusing on getting the existing instructions corrected.
> 
>  docs/installing.md | 101 +++---
>  1 file changed, 55 insertions(+), 46 deletions(-)
> 
> 
> Diffs
> -
> 
>   docs/installing.md c3abb332a4a46e62367a39cf73d70f2185657b5a 
> 
> Diff: https://reviews.apache.org/r/45167/diff/
> 
> 
> Testing
> ---
> 
> These changes are rendered here:
>   
> https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1647/docs/installing.md
> 
> I ran through the instructions in full in fresh Vagrant vms and was able
> to launch sample jobs (used aurora-packaging test jobs with cpu droppped to
> `0.5` and s/Service/Job/) and exercise the full UI chain to inspect the
> successful one-shot job and its sandbox & logs.
> 
> 
> Thanks,
> 
> John Sirois
> 
>



Re: Review Request 45167: Fixup install docs.

2016-03-22 Thread John Sirois

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45167/
---

(Updated March 22, 2016, 4:40 p.m.)


Review request for Aurora, Benjamin Rice and Stephan Erb.


Changes
---

Provide explicit advice for adjusting `--mesos-root`.

 docs/installing.md | 40 +---
 1 file changed, 29 insertions(+), 11 deletions(-)


Bugs: AURORA-1647
https://issues.apache.org/jira/browse/AURORA-1647


Repository: aurora


Description
---

This set of fixes eliminates the experimental rpm warnings and updates
the rpm instructions to use the officially released packages.  The deb
instructions are updated as well, in particular to take advantage of the
mesosphere deb repository and with movement of special dep installations
to the appropriate sections requiring them.

This fix RB does not address the new Debian Jessie debs, instead
focusing on getting the existing instructions corrected.

 docs/installing.md | 101 +++---
 1 file changed, 55 insertions(+), 46 deletions(-)


Diffs (updated)
-

  docs/installing.md c3abb332a4a46e62367a39cf73d70f2185657b5a 

Diff: https://reviews.apache.org/r/45167/diff/


Testing
---

These changes are rendered here:
  
https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1647/docs/installing.md

I ran through the instructions in full in fresh Vagrant vms and was able
to launch sample jobs (used aurora-packaging test jobs with cpu droppped to
`0.5` and s/Service/Job/) and exercise the full UI chain to inspect the
successful one-shot job and its sandbox & logs.


Thanks,

John Sirois



Re: Review Request 45167: Fixup install docs.

2016-03-22 Thread John Sirois


> On March 22, 2016, 3:26 p.m., Stephan Erb wrote:
> > Looks good! A few notes regarding related sections, even though not 
> > completely correleated with your change.

Changes forthcoming.


> On March 22, 2016, 3:26 p.m., Stephan Erb wrote:
> > docs/installing.md, line 330
> > 
> >
> > I believe everything after the "-" is optional and does not need to be 
> > included.

I tried and it needs at least  `sudo apt-get -y install mesos=0.25.0*`, which I 
was afraid of so I dropped in the `apt-cache` note. These both failed: 
`mesos=0.25.0` `mesos=0.25.0-0.2.70`


> On March 22, 2016, 3:26 p.m., Stephan Erb wrote:
> > docs/installing.md, line 294
> > 
> >
> > Wow, I am surprised. Is that actually working?

No clue - I run linux on my mac and stay well away from OSX!


> On March 22, 2016, 3:26 p.m., Stephan Erb wrote:
> > docs/installing.md, line 169
> > 
> >
> > That whole section seems outdate.

It is targeted so it is true, but I agree, there is no reason to promote 
installing really old versions!


> On March 22, 2016, 3:26 p.m., Stephan Erb wrote:
> > docs/installing.md, line 261
> > 
> >
> > Maybe it is more straight forward here to tell where that value is 
> > configured. Because if it is wrong, the user will have a hard time digging 
> > where and how our Thermos observer is configured.

Its different on each OS, but we already handle these differences so that makes 
sense to me.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45167/#review124889
---


On March 22, 2016, 11:48 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45167/
> ---
> 
> (Updated March 22, 2016, 11:48 a.m.)
> 
> 
> Review request for Aurora, Benjamin Rice and Stephan Erb.
> 
> 
> Bugs: AURORA-1647
> https://issues.apache.org/jira/browse/AURORA-1647
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This set of fixes eliminates the experimental rpm warnings and updates
> the rpm instructions to use the officially released packages.  The deb
> instructions are updated as well, in particular to take advantage of the
> mesosphere deb repository and with movement of special dep installations
> to the appropriate sections requiring them.
> 
> This fix RB does not address the new Debian Jessie debs, instead
> focusing on getting the existing instructions corrected.
> 
>  docs/installing.md | 101 +++---
>  1 file changed, 55 insertions(+), 46 deletions(-)
> 
> 
> Diffs
> -
> 
>   docs/installing.md c3abb332a4a46e62367a39cf73d70f2185657b5a 
> 
> Diff: https://reviews.apache.org/r/45167/diff/
> 
> 
> Testing
> ---
> 
> These changes are rendered here:
>   
> https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1647/docs/installing.md
> 
> I ran through the instructions in full in fresh Vagrant vms and was able
> to launch sample jobs (used aurora-packaging test jobs with cpu droppped to
> `0.5` and s/Service/Job/) and exercise the full UI chain to inspect the
> successful one-shot job and its sandbox & logs.
> 
> 
> Thanks,
> 
> John Sirois
> 
>



Re: Review Request 45167: Fixup install docs.

2016-03-22 Thread Stephan Erb

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45167/#review124889
---



Looks good! A few notes regarding related sections, even though not completely 
correleated with your change.


docs/installing.md (line 154)


That whole section seems outdate.



docs/installing.md (line 246)


Maybe it is more straight forward here to tell where that value is 
configured. Because if it is wrong, the user will have a hard time digging 
where and how our Thermos observer is configured.



docs/installing.md (line 278)


Wow, I am surprised. Is that actually working?



docs/installing.md (line 312)


I believe everything after the "-" is optional and does not need to be 
included.


- Stephan Erb


On March 22, 2016, 6:48 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45167/
> ---
> 
> (Updated March 22, 2016, 6:48 p.m.)
> 
> 
> Review request for Aurora, Benjamin Rice and Stephan Erb.
> 
> 
> Bugs: AURORA-1647
> https://issues.apache.org/jira/browse/AURORA-1647
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This set of fixes eliminates the experimental rpm warnings and updates
> the rpm instructions to use the officially released packages.  The deb
> instructions are updated as well, in particular to take advantage of the
> mesosphere deb repository and with movement of special dep installations
> to the appropriate sections requiring them.
> 
> This fix RB does not address the new Debian Jessie debs, instead
> focusing on getting the existing instructions corrected.
> 
>  docs/installing.md | 101 +++---
>  1 file changed, 55 insertions(+), 46 deletions(-)
> 
> 
> Diffs
> -
> 
>   docs/installing.md c3abb332a4a46e62367a39cf73d70f2185657b5a 
> 
> Diff: https://reviews.apache.org/r/45167/diff/
> 
> 
> Testing
> ---
> 
> These changes are rendered here:
>   
> https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1647/docs/installing.md
> 
> I ran through the instructions in full in fresh Vagrant vms and was able
> to launch sample jobs (used aurora-packaging test jobs with cpu droppped to
> `0.5` and s/Service/Job/) and exercise the full UI chain to inspect the
> successful one-shot job and its sandbox & logs.
> 
> 
> Thanks,
> 
> John Sirois
> 
>



Re: Review Request 45167: Fixup install docs.

2016-03-22 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45167/#review124848
---


Ship it!




Master (d5d7ec0) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 22, 2016, 5:48 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45167/
> ---
> 
> (Updated March 22, 2016, 5:48 p.m.)
> 
> 
> Review request for Aurora, Benjamin Rice and Stephan Erb.
> 
> 
> Bugs: AURORA-1647
> https://issues.apache.org/jira/browse/AURORA-1647
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This set of fixes eliminates the experimental rpm warnings and updates
> the rpm instructions to use the officially released packages.  The deb
> instructions are updated as well, in particular to take advantage of the
> mesosphere deb repository and with movement of special dep installations
> to the appropriate sections requiring them.
> 
> This fix RB does not address the new Debian Jessie debs, instead
> focusing on getting the existing instructions corrected.
> 
>  docs/installing.md | 101 +++---
>  1 file changed, 55 insertions(+), 46 deletions(-)
> 
> 
> Diffs
> -
> 
>   docs/installing.md c3abb332a4a46e62367a39cf73d70f2185657b5a 
> 
> Diff: https://reviews.apache.org/r/45167/diff/
> 
> 
> Testing
> ---
> 
> These changes are rendered here:
>   
> https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1647/docs/installing.md
> 
> I ran through the instructions in full in fresh Vagrant vms and was able
> to launch sample jobs (used aurora-packaging test jobs with cpu droppped to
> `0.5` and s/Service/Job/) and exercise the full UI chain to inspect the
> successful one-shot job and its sandbox & logs.
> 
> 
> Thanks,
> 
> John Sirois
> 
>



Re: Review Request 45167: Fixup install docs.

2016-03-22 Thread John Sirois

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45167/
---

(Updated March 22, 2016, 11:48 a.m.)


Review request for Aurora, Benjamin Rice and Stephan Erb.


Changes
---

Fixup "Installing Mesos" code block indents.

 docs/installing.md | 18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)


Bugs: AURORA-1647
https://issues.apache.org/jira/browse/AURORA-1647


Repository: aurora


Description
---

This set of fixes eliminates the experimental rpm warnings and updates
the rpm instructions to use the officially released packages.  The deb
instructions are updated as well, in particular to take advantage of the
mesosphere deb repository and with movement of special dep installations
to the appropriate sections requiring them.

This fix RB does not address the new Debian Jessie debs, instead
focusing on getting the existing instructions corrected.

 docs/installing.md | 101 +++---
 1 file changed, 55 insertions(+), 46 deletions(-)


Diffs (updated)
-

  docs/installing.md c3abb332a4a46e62367a39cf73d70f2185657b5a 

Diff: https://reviews.apache.org/r/45167/diff/


Testing
---

These changes are rendered here:
  
https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1647/docs/installing.md

I ran through the instructions in full in fresh Vagrant vms and was able
to launch sample jobs (used aurora-packaging test jobs with cpu droppped to
`0.5` and s/Service/Job/) and exercise the full UI chain to inspect the
successful one-shot job and its sandbox & logs.


Thanks,

John Sirois



Review Request 45167: Fixup install docs.

2016-03-22 Thread John Sirois

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45167/
---

Review request for Aurora, Benjamin Rice and Stephan Erb.


Bugs: AURORA-1647
https://issues.apache.org/jira/browse/AURORA-1647


Repository: aurora


Description
---

This set of fixes eliminates the experimental rpm warnings and updates
the rpm instructions to use the officially released packages.  The deb
instructions are updated as well, in particular to take advantage of the
mesosphere deb repository and with movement of special dep installations
to the appropriate sections requiring them.

This fix RB does not address the new Debian Jessie debs, instead
focusing on getting the existing instructions corrected.

 docs/installing.md | 101 +++---
 1 file changed, 55 insertions(+), 46 deletions(-)


Diffs
-

  docs/installing.md c3abb332a4a46e62367a39cf73d70f2185657b5a 

Diff: https://reviews.apache.org/r/45167/diff/


Testing
---

These changes are rendered here:
  
https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1647/docs/installing.md

I ran through the instructions in full in fresh Vagrant vms and was able
to launch sample jobs (used aurora-packaging test jobs with cpu droppped to
`0.5` and s/Service/Job/) and exercise the full UI chain to inspect the
successful one-shot job and its sandbox & logs.


Thanks,

John Sirois