Re: Review Request 45182: Improve mname and structdump documentation

2016-03-22 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45182/#review124918
---


Ship it!




Ship It!

- Maxim Khutornenko


On March 22, 2016, 11:33 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45182/
> ---
> 
> (Updated March 22, 2016, 11:33 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Improve mname and structdump documentation
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/http/Mname.java 
> d6e5fc4e886660311228d411cae1bbb42aaffb19 
>   src/main/java/org/apache/aurora/scheduler/http/StructDump.java 
> f84767a2c01bccc23182672123f9ca6701fcd696 
> 
> Diff: https://reviews.apache.org/r/45182/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build 
> 
> Verified rendering in Vagrant
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 45182: Improve mname and structdump documentation

2016-03-22 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45182/
---

(Updated March 23, 2016, 12:33 a.m.)


Review request for Aurora and Maxim Khutornenko.


Repository: aurora


Description
---

Improve mname and structdump documentation


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/http/Mname.java 
d6e5fc4e886660311228d411cae1bbb42aaffb19 
  src/main/java/org/apache/aurora/scheduler/http/StructDump.java 
f84767a2c01bccc23182672123f9ca6701fcd696 

Diff: https://reviews.apache.org/r/45182/diff/


Testing
---

./gradlew -Pq build 

Verified rendering in Vagrant


Thanks,

Stephan Erb

Re: Review Request 45182: Improve mname and structdump documentation

2016-03-22 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45182/#review124916
---



Master (b5c9e1b) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 22, 2016, 11:09 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45182/
> ---
> 
> (Updated March 22, 2016, 11:09 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Improve mname and structdump documentation
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/http/Mname.java 
> d6e5fc4e886660311228d411cae1bbb42aaffb19 
>   src/main/java/org/apache/aurora/scheduler/http/StructDump.java 
> f84767a2c01bccc23182672123f9ca6701fcd696 
> 
> Diff: https://reviews.apache.org/r/45182/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build 
> 
> Verified rendering in Vagrant
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 45182: Improve mname and structdump documentation

2016-03-22 Thread Stephan Erb 


> On March 23, 2016, 12:12 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/http/Mname.java, line 62
> > 
> >
> > ?

Oh no, what whas I thinking :-)


- Stephan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45182/#review124907
---


On March 23, 2016, 12:09 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45182/
> ---
> 
> (Updated March 23, 2016, 12:09 a.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Improve mname and structdump documentation
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/http/Mname.java 
> d6e5fc4e886660311228d411cae1bbb42aaffb19 
>   src/main/java/org/apache/aurora/scheduler/http/StructDump.java 
> f84767a2c01bccc23182672123f9ca6701fcd696 
> 
> Diff: https://reviews.apache.org/r/45182/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build 
> 
> Verified rendering in Vagrant
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 45182: Improve mname and structdump documentation

2016-03-22 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45182/#review124907
---




src/main/java/org/apache/aurora/scheduler/http/Mname.java (line 59)


?


- Maxim Khutornenko


On March 22, 2016, 11:09 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45182/
> ---
> 
> (Updated March 22, 2016, 11:09 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Improve mname and structdump documentation
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/http/Mname.java 
> d6e5fc4e886660311228d411cae1bbb42aaffb19 
>   src/main/java/org/apache/aurora/scheduler/http/StructDump.java 
> f84767a2c01bccc23182672123f9ca6701fcd696 
> 
> Diff: https://reviews.apache.org/r/45182/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build 
> 
> Verified rendering in Vagrant
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Review Request 45182: Improve mname and structdump documentation

2016-03-22 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45182/
---

Review request for Aurora and Maxim Khutornenko.


Repository: aurora


Description
---

Improve mname and structdump documentation


Diffs
-

  src/main/java/org/apache/aurora/scheduler/http/Mname.java 
d6e5fc4e886660311228d411cae1bbb42aaffb19 
  src/main/java/org/apache/aurora/scheduler/http/StructDump.java 
f84767a2c01bccc23182672123f9ca6701fcd696 

Diff: https://reviews.apache.org/r/45182/diff/


Testing
---

./gradlew -Pq build 

Verified rendering in Vagrant


Thanks,

Stephan Erb