Re: Review Request 45770: Slim the `ServerSet` interface.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45770/#review127411 --- Ship it! Ship It! - Bill Farner On April 5, 2016, 12:51 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45770/ > --- > > (Updated April 5, 2016, 12:51 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-1468 > https://issues.apache.org/jira/browse/AURORA-1468 > > > Repository: aurora > > > Description > --- > > This makes the path to a Curator implementation to satisfy the contract > with `LeaderRedirect` simpler by introducing `ServiceGroupMonitor` > which hides server set change events, just exposing the current active > set via a query method. This is all the `LeaderRedirect` needs since > it is driven by user-generated events (HTTP requests). > > commons/src/main/java/org/apache/aurora/common/net/pool/DynamicHostSet.java >| 6 +--- > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java >| 29 ++--- > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java >| 38 -- > > commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java > | 25 +-- > src/main/java/org/apache/aurora/scheduler/app/ServiceDiscoveryModule.java >| 57 + > src/main/java/org/apache/aurora/scheduler/app/ServiceGroupMonitor.java >| 46 ++ > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java >| 7 ++-- > src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java >| 87 +- > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java >| 3 +- > src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java >| 30 + > src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java >| 58 +++-- > src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java >| 10 +++--- > 12 files changed, 203 insertions(+), 193 deletions(-) > > > Diffs > - > > commons/src/main/java/org/apache/aurora/common/net/pool/DynamicHostSet.java > 837d15cf4d9c0929f6ce92e348c763808f2a33a9 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java > fe6229e963b48a330f16dbfcfd2bf644f08d0b7a > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java > eca13511dc93f5ce5879976f2c7b0cc40be7d342 > > commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java > 56cc32d95041b8c27932c0ee17bd36c83756cb3a > src/main/java/org/apache/aurora/scheduler/app/ServiceDiscoveryModule.java > 240164fbf8eba245a680e2d817fb3c458c677ad9 > src/main/java/org/apache/aurora/scheduler/app/ServiceGroupMonitor.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > a5446e3c8b666cfb69b8900e298edc16a2288052 > src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java > ef712909f6a32882a1ca9d4863a44754b3e94e15 > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java > 918a3dae5d76402371b7f26c43cfdf3df056f1b0 > src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java > 19c8a1fe06a24022da11f74d7c96b2942587 > src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java > 367826646bb4dd300454cac382a9f25b6f2d4218 > src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java > 80e8ebea0c555b478810e9c9f35862dbb7e191a0 > > Diff: https://reviews.apache.org/r/45770/diff/ > > > Testing > --- > > Locally green: > ``` > ./gradlew -Pq build > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 45770: Slim the `ServerSet` interface.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45770/#review127204 --- Ship it! Master (5109788) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On April 5, 2016, 7:51 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45770/ > --- > > (Updated April 5, 2016, 7:51 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-1468 > https://issues.apache.org/jira/browse/AURORA-1468 > > > Repository: aurora > > > Description > --- > > This makes the path to a Curator implementation to satisfy the contract > with `LeaderRedirect` simpler by introducing `ServiceGroupMonitor` > which hides server set change events, just exposing the current active > set via a query method. This is all the `LeaderRedirect` needs since > it is driven by user-generated events (HTTP requests). > > commons/src/main/java/org/apache/aurora/common/net/pool/DynamicHostSet.java >| 6 +--- > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java >| 29 ++--- > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java >| 38 -- > > commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java > | 25 +-- > src/main/java/org/apache/aurora/scheduler/app/ServiceDiscoveryModule.java >| 57 + > src/main/java/org/apache/aurora/scheduler/app/ServiceGroupMonitor.java >| 46 ++ > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java >| 7 ++-- > src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java >| 87 +- > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java >| 3 +- > src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java >| 30 + > src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java >| 58 +++-- > src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java >| 10 +++--- > 12 files changed, 203 insertions(+), 193 deletions(-) > > > Diffs > - > > commons/src/main/java/org/apache/aurora/common/net/pool/DynamicHostSet.java > 837d15cf4d9c0929f6ce92e348c763808f2a33a9 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java > fe6229e963b48a330f16dbfcfd2bf644f08d0b7a > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java > eca13511dc93f5ce5879976f2c7b0cc40be7d342 > > commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java > 56cc32d95041b8c27932c0ee17bd36c83756cb3a > src/main/java/org/apache/aurora/scheduler/app/ServiceDiscoveryModule.java > 240164fbf8eba245a680e2d817fb3c458c677ad9 > src/main/java/org/apache/aurora/scheduler/app/ServiceGroupMonitor.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > a5446e3c8b666cfb69b8900e298edc16a2288052 > src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java > ef712909f6a32882a1ca9d4863a44754b3e94e15 > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java > 918a3dae5d76402371b7f26c43cfdf3df056f1b0 > src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java > 19c8a1fe06a24022da11f74d7c96b2942587 > src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java > 367826646bb4dd300454cac382a9f25b6f2d4218 > src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java > 80e8ebea0c555b478810e9c9f35862dbb7e191a0 > > Diff: https://reviews.apache.org/r/45770/diff/ > > > Testing > --- > > Locally green: > ``` > ./gradlew -Pq build > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Review Request 45770: Slim the `ServerSet` interface.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45770/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1468 https://issues.apache.org/jira/browse/AURORA-1468 Repository: aurora Description --- This makes the path to a Curator implementation to satisfy the contract with `LeaderRedirect` simpler by introducing `ServiceGroupMonitor` which hides server set change events, just exposing the current active set via a query method. This is all the `LeaderRedirect` needs since it is driven by user-generated events (HTTP requests). commons/src/main/java/org/apache/aurora/common/net/pool/DynamicHostSet.java | 6 +--- commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java | 29 ++--- commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java | 38 -- commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java | 25 +-- src/main/java/org/apache/aurora/scheduler/app/ServiceDiscoveryModule.java | 57 + src/main/java/org/apache/aurora/scheduler/app/ServiceGroupMonitor.java | 46 ++ src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java | 7 ++-- src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java | 87 +- src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java | 3 +- src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java | 30 + src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java | 58 +++-- src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java | 10 +++--- 12 files changed, 203 insertions(+), 193 deletions(-) Diffs - commons/src/main/java/org/apache/aurora/common/net/pool/DynamicHostSet.java 837d15cf4d9c0929f6ce92e348c763808f2a33a9 commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java fe6229e963b48a330f16dbfcfd2bf644f08d0b7a commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java eca13511dc93f5ce5879976f2c7b0cc40be7d342 commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java 56cc32d95041b8c27932c0ee17bd36c83756cb3a src/main/java/org/apache/aurora/scheduler/app/ServiceDiscoveryModule.java 240164fbf8eba245a680e2d817fb3c458c677ad9 src/main/java/org/apache/aurora/scheduler/app/ServiceGroupMonitor.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java a5446e3c8b666cfb69b8900e298edc16a2288052 src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java ef712909f6a32882a1ca9d4863a44754b3e94e15 src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 918a3dae5d76402371b7f26c43cfdf3df056f1b0 src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 19c8a1fe06a24022da11f74d7c96b2942587 src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 367826646bb4dd300454cac382a9f25b6f2d4218 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 80e8ebea0c555b478810e9c9f35862dbb7e191a0 Diff: https://reviews.apache.org/r/45770/diff/ Testing --- Locally green: ``` ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois
