Re: Review Request 45886: Generalize ZooKeeper Test Utils.

2016-04-07 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45886/#review127657
---


Ship it!




Ship It!

- Bill Farner


On April 7, 2016, 11:56 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45886/
> ---
> 
> (Updated April 7, 2016, 11:56 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1468
> https://issues.apache.org/jira/browse/AURORA-1468
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This makes way for Curator client based in-process integration tests.
> 
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/{BaseZooKeeperTest.java
>  => BaseZooKeeperClientTest.java} |  57 +-
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperTest.java
>| 110 
> --
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java
>  |  99 
> +
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/CandidateImplTest.java
>|   4 +-
>  commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java  
>  |   4 +-
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java
>|   4 +-
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/SingletonServiceImplTest.java
> |   4 +-
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
>  |   4 +-
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
>   |   4 +-
>  
> src/main/java/org/apache/aurora/scheduler/zookeeper/guice/client/ZooKeeperClientModule.java
>|  15 +++
>  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java   
>  |   4 +-
>  11 files changed, 62 insertions(+), 247 deletions(-)
> 
> 
> Diffs
> -
> 
>   
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
>  PRE-CREATION 
>   
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperTest.java
>  3242035d658501e51acc005b5493aea27ecc3b71 
>   
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java
>  dc4d38907f93a4b558f6f1d8826c7ceded95b3ab 
>   
> commons/src/test/java/org/apache/aurora/common/zookeeper/CandidateImplTest.java
>  076352115c8c8658057ae1c357901ee9bfe09c25 
>   commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java 
> ac6544256abcf15caa077cbd166ef06254f9c194 
>   
> commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java
>  73049d8f3f28326e999d864d2dbcec2c3af3c691 
>   
> commons/src/test/java/org/apache/aurora/common/zookeeper/SingletonServiceImplTest.java
>  82df845449a7045320c9903d5a1fa6bd26ea911e 
>   
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
>  1a2fb115295e8e0da74b98eed115bc165b1f54ee 
>   
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
>  32b937d3d26a2b0ae1c39696014939d1d8e5408a 
>   
> src/main/java/org/apache/aurora/scheduler/zookeeper/guice/client/ZooKeeperClientModule.java
>  bf2111d351e1f4055f956ef8f02a91b58397e22a 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> b449827feebf3c634adb679641ca1b677bc3bb43 
> 
> Diff: https://reviews.apache.org/r/45886/diff/
> 
> 
> Testing
> ---
> 
> Locally green:
> ```
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 45886: Generalize ZooKeeper Test Utils.

2016-04-07 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45886/#review127645
---


Ship it!




Master (915459d) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On April 7, 2016, 6:56 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45886/
> ---
> 
> (Updated April 7, 2016, 6:56 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1468
> https://issues.apache.org/jira/browse/AURORA-1468
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This makes way for Curator client based in-process integration tests.
> 
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/{BaseZooKeeperTest.java
>  => BaseZooKeeperClientTest.java} |  57 +-
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperTest.java
>| 110 
> --
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java
>  |  99 
> +
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/CandidateImplTest.java
>|   4 +-
>  commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java  
>  |   4 +-
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java
>|   4 +-
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/SingletonServiceImplTest.java
> |   4 +-
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
>  |   4 +-
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
>   |   4 +-
>  
> src/main/java/org/apache/aurora/scheduler/zookeeper/guice/client/ZooKeeperClientModule.java
>|  15 +++
>  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java   
>  |   4 +-
>  11 files changed, 62 insertions(+), 247 deletions(-)
> 
> 
> Diffs
> -
> 
>   
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
>  PRE-CREATION 
>   
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperTest.java
>  3242035d658501e51acc005b5493aea27ecc3b71 
>   
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java
>  dc4d38907f93a4b558f6f1d8826c7ceded95b3ab 
>   
> commons/src/test/java/org/apache/aurora/common/zookeeper/CandidateImplTest.java
>  076352115c8c8658057ae1c357901ee9bfe09c25 
>   commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java 
> ac6544256abcf15caa077cbd166ef06254f9c194 
>   
> commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java
>  73049d8f3f28326e999d864d2dbcec2c3af3c691 
>   
> commons/src/test/java/org/apache/aurora/common/zookeeper/SingletonServiceImplTest.java
>  82df845449a7045320c9903d5a1fa6bd26ea911e 
>   
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
>  1a2fb115295e8e0da74b98eed115bc165b1f54ee 
>   
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
>  32b937d3d26a2b0ae1c39696014939d1d8e5408a 
>   
> src/main/java/org/apache/aurora/scheduler/zookeeper/guice/client/ZooKeeperClientModule.java
>  bf2111d351e1f4055f956ef8f02a91b58397e22a 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> b449827feebf3c634adb679641ca1b677bc3bb43 
> 
> Diff: https://reviews.apache.org/r/45886/diff/
> 
> 
> Testing
> ---
> 
> Locally green:
> ```
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Review Request 45886: Generalize ZooKeeper Test Utils.

2016-04-07 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45886/
---

Review request for Aurora and Bill Farner.


Bugs: AURORA-1468
https://issues.apache.org/jira/browse/AURORA-1468


Repository: aurora


Description
---

This makes way for Curator client based in-process integration tests.

 
commons/src/main/java/org/apache/aurora/common/zookeeper/testing/{BaseZooKeeperTest.java
 => BaseZooKeeperClientTest.java} |  57 +-
 
commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperTest.java
   | 110 
--
 
commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java
 |  99 
+
 
commons/src/test/java/org/apache/aurora/common/zookeeper/CandidateImplTest.java 
  |   4 +-
 commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java
   |   4 +-
 
commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java 
  |   4 +-
 
commons/src/test/java/org/apache/aurora/common/zookeeper/SingletonServiceImplTest.java
|   4 +-
 
commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
 |   4 +-
 
commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
  |   4 +-
 
src/main/java/org/apache/aurora/scheduler/zookeeper/guice/client/ZooKeeperClientModule.java
   |  15 +++
 src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
   |   4 +-
 11 files changed, 62 insertions(+), 247 deletions(-)


Diffs
-

  
commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
 PRE-CREATION 
  
commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperTest.java
 3242035d658501e51acc005b5493aea27ecc3b71 
  
commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java
 dc4d38907f93a4b558f6f1d8826c7ceded95b3ab 
  
commons/src/test/java/org/apache/aurora/common/zookeeper/CandidateImplTest.java 
076352115c8c8658057ae1c357901ee9bfe09c25 
  commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java 
ac6544256abcf15caa077cbd166ef06254f9c194 
  
commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java 
73049d8f3f28326e999d864d2dbcec2c3af3c691 
  
commons/src/test/java/org/apache/aurora/common/zookeeper/SingletonServiceImplTest.java
 82df845449a7045320c9903d5a1fa6bd26ea911e 
  
commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
 1a2fb115295e8e0da74b98eed115bc165b1f54ee 
  
commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
 32b937d3d26a2b0ae1c39696014939d1d8e5408a 
  
src/main/java/org/apache/aurora/scheduler/zookeeper/guice/client/ZooKeeperClientModule.java
 bf2111d351e1f4055f956ef8f02a91b58397e22a 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
b449827feebf3c634adb679641ca1b677bc3bb43 

Diff: https://reviews.apache.org/r/45886/diff/


Testing
---

Locally green:
```
./gradlew -Pq build
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```


Thanks,

John Sirois