Re: Review Request 46587: Deprecating --restart-threshold option in 'aurora job restart'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46587/#review130510 --- Ship it! Ship It! - Zameer Manji On April 22, 2016, 2:54 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46587/ > --- > > (Updated April 22, 2016, 2:54 p.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Bugs: AURORA-1631 > https://issues.apache.org/jira/browse/AURORA-1631 > > > Repository: aurora > > > Description > --- > > Dropped `--restart-threshold` from `aurora job restart` and simplified > `InstanceWatcher` and `StatusHealthCheck` logic now that their only caller is > `Restarter`. Also, dropped some other unused code. > > > Diffs > - > > RELEASE-NOTES.md 4b810f2d808cbf0d91c753147d98d1e389106d22 > src/main/python/apache/aurora/client/api/error_handling_thread.py > 530715aedc076355b7f8fc3bcae66d80abe2684d > src/main/python/apache/aurora/client/api/health_check.py > 0503c0b01b205f746837132314138bc5432a415d > src/main/python/apache/aurora/client/api/instance_watcher.py > 6ed815423f48301ecb3faaadcdfa1e46f50b6ca2 > src/main/python/apache/aurora/client/api/job_monitor.py > aa7e9760d0f4f74a5ddf97e0642bf53efc555644 > src/main/python/apache/aurora/client/api/restarter.py > fbe8f20b5c0c719092dba29e3feb6d3b29d88310 > src/main/python/apache/aurora/client/api/scheduler_mux.py > 0832a13a99051a55158f381157e0e487ddf9fa07 > src/main/python/apache/aurora/client/api/task_util.py > b5244ee8132c966e63eabc1dbd8e852db4f23a1d > src/main/python/apache/aurora/client/cli/jobs.py > 3cbd607e7d3cd9e816c90cfdf03ba6ab3a02c416 > src/test/python/apache/aurora/client/api/test_health_check.py > af005be873490f6aba0d0c98ced1c74915a637fc > src/test/python/apache/aurora/client/api/test_instance_watcher.py > 9efe1d452cfcaef24544d42817d1c0256f970f85 > src/test/python/apache/aurora/client/api/test_restarter.py > ff2002e71a84f798d8d6fe29598b103a82f99c09 > src/test/python/apache/aurora/client/api/test_scheduler_mux.py > 021175c6b422e2ebb04dccb2650dbdf44b312f54 > src/test/python/apache/aurora/client/api/test_task_util.py > eda326d3fc53a036117093893c17f285946855c7 > src/test/python/apache/aurora/client/cli/test_restart.py > 54de6cf2a95d5022383e8d6e0b222df0136170b8 > > Diff: https://reviews.apache.org/r/46587/diff/ > > > Testing > --- > > > Thanks, > > Maxim Khutornenko > >
Re: Review Request 46587: Deprecating --restart-threshold option in 'aurora job restart'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46587/#review130214 --- Ship it! Master (95dcca5) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On April 22, 2016, 9:54 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46587/ > --- > > (Updated April 22, 2016, 9:54 p.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Bugs: AURORA-1631 > https://issues.apache.org/jira/browse/AURORA-1631 > > > Repository: aurora > > > Description > --- > > Dropped `--restart-threshold` from `aurora job restart` and simplified > `InstanceWatcher` and `StatusHealthCheck` logic now that their only caller is > `Restarter`. Also, dropped some other unused code. > > > Diffs > - > > RELEASE-NOTES.md 4b810f2d808cbf0d91c753147d98d1e389106d22 > src/main/python/apache/aurora/client/api/error_handling_thread.py > 530715aedc076355b7f8fc3bcae66d80abe2684d > src/main/python/apache/aurora/client/api/health_check.py > 0503c0b01b205f746837132314138bc5432a415d > src/main/python/apache/aurora/client/api/instance_watcher.py > 6ed815423f48301ecb3faaadcdfa1e46f50b6ca2 > src/main/python/apache/aurora/client/api/job_monitor.py > aa7e9760d0f4f74a5ddf97e0642bf53efc555644 > src/main/python/apache/aurora/client/api/restarter.py > fbe8f20b5c0c719092dba29e3feb6d3b29d88310 > src/main/python/apache/aurora/client/api/scheduler_mux.py > 0832a13a99051a55158f381157e0e487ddf9fa07 > src/main/python/apache/aurora/client/api/task_util.py > b5244ee8132c966e63eabc1dbd8e852db4f23a1d > src/main/python/apache/aurora/client/cli/jobs.py > 3cbd607e7d3cd9e816c90cfdf03ba6ab3a02c416 > src/test/python/apache/aurora/client/api/test_health_check.py > af005be873490f6aba0d0c98ced1c74915a637fc > src/test/python/apache/aurora/client/api/test_instance_watcher.py > 9efe1d452cfcaef24544d42817d1c0256f970f85 > src/test/python/apache/aurora/client/api/test_restarter.py > ff2002e71a84f798d8d6fe29598b103a82f99c09 > src/test/python/apache/aurora/client/api/test_scheduler_mux.py > 021175c6b422e2ebb04dccb2650dbdf44b312f54 > src/test/python/apache/aurora/client/api/test_task_util.py > eda326d3fc53a036117093893c17f285946855c7 > src/test/python/apache/aurora/client/cli/test_restart.py > 54de6cf2a95d5022383e8d6e0b222df0136170b8 > > Diff: https://reviews.apache.org/r/46587/diff/ > > > Testing > --- > > > Thanks, > > Maxim Khutornenko > >
Re: Review Request 46587: Deprecating --restart-threshold option in 'aurora job restart'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46587/#review130208 --- Ship it! Ship It! - Stephan Erb On April 22, 2016, 11:54 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46587/ > --- > > (Updated April 22, 2016, 11:54 p.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Bugs: AURORA-1631 > https://issues.apache.org/jira/browse/AURORA-1631 > > > Repository: aurora > > > Description > --- > > Dropped `--restart-threshold` from `aurora job restart` and simplified > `InstanceWatcher` and `StatusHealthCheck` logic now that their only caller is > `Restarter`. Also, dropped some other unused code. > > > Diffs > - > > RELEASE-NOTES.md 4b810f2d808cbf0d91c753147d98d1e389106d22 > src/main/python/apache/aurora/client/api/error_handling_thread.py > 530715aedc076355b7f8fc3bcae66d80abe2684d > src/main/python/apache/aurora/client/api/health_check.py > 0503c0b01b205f746837132314138bc5432a415d > src/main/python/apache/aurora/client/api/instance_watcher.py > 6ed815423f48301ecb3faaadcdfa1e46f50b6ca2 > src/main/python/apache/aurora/client/api/job_monitor.py > aa7e9760d0f4f74a5ddf97e0642bf53efc555644 > src/main/python/apache/aurora/client/api/restarter.py > fbe8f20b5c0c719092dba29e3feb6d3b29d88310 > src/main/python/apache/aurora/client/api/scheduler_mux.py > 0832a13a99051a55158f381157e0e487ddf9fa07 > src/main/python/apache/aurora/client/api/task_util.py > b5244ee8132c966e63eabc1dbd8e852db4f23a1d > src/main/python/apache/aurora/client/cli/jobs.py > 3cbd607e7d3cd9e816c90cfdf03ba6ab3a02c416 > src/test/python/apache/aurora/client/api/test_health_check.py > af005be873490f6aba0d0c98ced1c74915a637fc > src/test/python/apache/aurora/client/api/test_instance_watcher.py > 9efe1d452cfcaef24544d42817d1c0256f970f85 > src/test/python/apache/aurora/client/api/test_restarter.py > ff2002e71a84f798d8d6fe29598b103a82f99c09 > src/test/python/apache/aurora/client/api/test_scheduler_mux.py > 021175c6b422e2ebb04dccb2650dbdf44b312f54 > src/test/python/apache/aurora/client/api/test_task_util.py > eda326d3fc53a036117093893c17f285946855c7 > src/test/python/apache/aurora/client/cli/test_restart.py > 54de6cf2a95d5022383e8d6e0b222df0136170b8 > > Diff: https://reviews.apache.org/r/46587/diff/ > > > Testing > --- > > > Thanks, > > Maxim Khutornenko > >
Review Request 46587: Deprecating --restart-threshold option in 'aurora job restart'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46587/ --- Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1631 https://issues.apache.org/jira/browse/AURORA-1631 Repository: aurora Description --- Dropped `--restart-threshold` from `aurora job restart` and simplified `InstanceWatcher` and `StatusHealthCheck` logic now that their only caller is `Restarter`. Also, dropped some other unused code. Diffs - RELEASE-NOTES.md 4b810f2d808cbf0d91c753147d98d1e389106d22 src/main/python/apache/aurora/client/api/error_handling_thread.py 530715aedc076355b7f8fc3bcae66d80abe2684d src/main/python/apache/aurora/client/api/health_check.py 0503c0b01b205f746837132314138bc5432a415d src/main/python/apache/aurora/client/api/instance_watcher.py 6ed815423f48301ecb3faaadcdfa1e46f50b6ca2 src/main/python/apache/aurora/client/api/job_monitor.py aa7e9760d0f4f74a5ddf97e0642bf53efc555644 src/main/python/apache/aurora/client/api/restarter.py fbe8f20b5c0c719092dba29e3feb6d3b29d88310 src/main/python/apache/aurora/client/api/scheduler_mux.py 0832a13a99051a55158f381157e0e487ddf9fa07 src/main/python/apache/aurora/client/api/task_util.py b5244ee8132c966e63eabc1dbd8e852db4f23a1d src/main/python/apache/aurora/client/cli/jobs.py 3cbd607e7d3cd9e816c90cfdf03ba6ab3a02c416 src/test/python/apache/aurora/client/api/test_health_check.py af005be873490f6aba0d0c98ced1c74915a637fc src/test/python/apache/aurora/client/api/test_instance_watcher.py 9efe1d452cfcaef24544d42817d1c0256f970f85 src/test/python/apache/aurora/client/api/test_restarter.py ff2002e71a84f798d8d6fe29598b103a82f99c09 src/test/python/apache/aurora/client/api/test_scheduler_mux.py 021175c6b422e2ebb04dccb2650dbdf44b312f54 src/test/python/apache/aurora/client/api/test_task_util.py eda326d3fc53a036117093893c17f285946855c7 src/test/python/apache/aurora/client/cli/test_restart.py 54de6cf2a95d5022383e8d6e0b222df0136170b8 Diff: https://reviews.apache.org/r/46587/diff/ Testing --- Thanks, Maxim Khutornenko