Re: Review Request 47076: Changing ResourceMapper interface arg type

2016-05-06 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47076/#review132091
---


Ship it!




Ship It!

- Zameer Manji


On May 6, 2016, 11:10 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47076/
> ---
> 
> (Updated May 6, 2016, 11:10 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Minor change to `ResourceMapper.mapAndAssign()` to take `IAssignedTask` 
> instead of `IScheduledTask`. The `IScheduledTask` is never used there.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 
> 1b88fc3178c44c5e21a9e5ffb432bddbf8f7098f 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceMapper.java 
> c06ce8dbe74fe44675d2597fd915c24cf5867915 
>   src/main/java/org/apache/aurora/scheduler/state/StateManager.java 
> 66bfd72e3977deafb4d4d835d0458f8df053074d 
>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
> 2b4fac1d7228050cbf808ae9f0e06730970c8613 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 1a3886f9018160fc9daeefcd9470cccb95bccd07 
>   src/test/java/org/apache/aurora/scheduler/resources/PortMapperTest.java 
> c94f7a9944870797a5542baf5d726390f7d0 
>   
> src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java 
> c53a21d127a58fe90f4974d62afb613805f121f0 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> 2370178e2f5c61723fae388d3c0948fffdf1e3ed 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> ca10323b8b0a1d2b63bc3e502a94f660a1a9dade 
> 
> Diff: https://reviews.apache.org/r/47076/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>



Review Request 47076: Changing ResourceMapper interface arg type

2016-05-06 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47076/
---

Review request for Aurora and Zameer Manji.


Repository: aurora


Description
---

Minor change to `ResourceMapper.mapAndAssign()` to take `IAssignedTask` instead 
of `IScheduledTask`. The `IScheduledTask` is never used there.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 
1b88fc3178c44c5e21a9e5ffb432bddbf8f7098f 
  src/main/java/org/apache/aurora/scheduler/resources/ResourceMapper.java 
c06ce8dbe74fe44675d2597fd915c24cf5867915 
  src/main/java/org/apache/aurora/scheduler/state/StateManager.java 
66bfd72e3977deafb4d4d835d0458f8df053074d 
  src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
2b4fac1d7228050cbf808ae9f0e06730970c8613 
  src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
1a3886f9018160fc9daeefcd9470cccb95bccd07 
  src/test/java/org/apache/aurora/scheduler/resources/PortMapperTest.java 
c94f7a9944870797a5542baf5d726390f7d0 
  src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java 
c53a21d127a58fe90f4974d62afb613805f121f0 
  src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
2370178e2f5c61723fae388d3c0948fffdf1e3ed 
  src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
ca10323b8b0a1d2b63bc3e502a94f660a1a9dade 

Diff: https://reviews.apache.org/r/47076/diff/


Testing
---


Thanks,

Maxim Khutornenko